From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAEB6C433E7 for ; Tue, 1 Sep 2020 14:44:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E2322192A for ; Tue, 1 Sep 2020 14:44:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BRuImVfi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E2322192A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tJoengamhX17OeaScctgh9ZmVkFxIEJbAUDIZ79FXpQ=; b=BRuImVfi29AXofI6vTGNSWWWv ZnHDYh5MXJ9rFDUBitWawLH4wJqRsHjv8Q3j9JYoBeRlNyryT/rEnA6rLJ68rXD1g3TWnmrZpGKni iEo9Fe15+PBE1g3qEbOFFTq0sJR8Uby/ogW3CtBIFPP+WIdb+k11s96BdynUxmfnsv3FHBDFNfHxE aq9IvibEzMpbeJ6giF8WVnHgvKjNaD9vBtmuo9TMmeRDYYts3unZw186AGVSqfCtlZ2hg8u0mZPZL wUltjR0do6jpcx+VsHAP6NCOf5lzXvcBxMXfXrb+GVCwD6Diri4dWDPz+Ar9+RX1c9cyVGa8fU5CS aribennWg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kD7Ua-0005ld-RI; Tue, 01 Sep 2020 14:42:36 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kD7UX-0005kt-Uw for linux-arm-kernel@lists.infradead.org; Tue, 01 Sep 2020 14:42:35 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: gtucker) with ESMTPSA id 46FC8299AB2 Subject: Re: [PATCH v2 1/4] ARM: exynos: clear L310_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val To: Krzysztof Kozlowski , Russell King References: <267a81e550a0b5d479c82b5908e2a2caa4c9c874.1597061474.git.guillaume.tucker@collabora.com> From: Guillaume Tucker Message-ID: Date: Tue, 1 Sep 2020 15:42:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200901_104234_103593_59D6943D X-CRM114-Status: GOOD ( 23.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Rob Herring , Kukjin Kim , kernel@collabora.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/09/2020 14:51, Krzysztof Kozlowski wrote: > On Tue, 1 Sep 2020 at 15:45, Krzysztof Kozlowski wrote: >> >> On Tue, 1 Sep 2020 at 15:34, Guillaume Tucker >> wrote: >>> >>> Hi Krzysztof, Russell, >>> >>> On 10/08/2020 13:22, Guillaume Tucker wrote: >>>> The L310_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable >>>> sequence. There is no need to set it in the default register value, >>>> this was done before support for it was implemented in the code. It >>>> is not set in the hardware initial value either. >>>> >>>> Clean this up by removing this flag from the default l2c_aux_val, and >>>> add it to the l2c_aux_mask to print an alert message if it was already >>>> set before the kernel initialisation. >>>> >>>> Signed-off-by: Guillaume Tucker >>>> --- >>>> >>>> Notes: >>>> v2: fix flag name L310_AUX_CTRL_NS_LOCKDOWN >>>> >>>> arch/arm/mach-exynos/exynos.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> I believe this v2 series has addressed all previous comments and >>> you were waiting for the 5.9 merge window to end. The patches >>> all still apply cleanly on v5.9-rc3. Do you want me to resend >>> the series anyway or is there anything else needed at this point? >>> >>> Maybe one thing that wasn't completely clear in v1 was whether >>> patch 2/4 was the right approach. I've explained the reason >>> behind it but didn't get a final reply from Russell[1]. >> >> I am sorry, my bad. I already applied this one and 3/4 (dts). >> Apparently I forgot to reply with confirmation and Patchwork did not >> notify you for some reason. No problem, I see them in linux-next now. Thanks! >> Patch 2/4 does not look like one for me so I would need ack from >> Russell to take. Did you submit it to the ARM patches queue? I've CC-ed linux-arm-kernel@lists.infradead.org on the whole series. Did you mean anything else by the ARM patches queue? >> Patch 4/4 will wait for v5.10-rc1 as it depends on 1/4 and it is DTS patch. > > Correct: Patch 4/4 will wait for v5.10 because it depends on the DTS patch. Sure, in fact patch 4/4 depends on the DTS one (3/4) and also on the l2c fix (2/4) as otherwise prefetch would actually not be enabled. So it sounds like both remaining ones 2/4 and 4/4 are actually now pending Russell's ack. Best wishes, Guillaume [1] https://lore.kernel.org/lkml/46fa1159-fcd6-b528-b8e8-2fba048236b2@collabora.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel