From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0ADD7C67861 for ; Mon, 8 Apr 2024 06:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7jIUTtJJ8D5FIznV57Bu9e8jhlweRCX8gTN6NPzSaRg=; b=1ihbnuhit521bI 9BPTlCjSsZpFUTBNn7ClAoEWcHsHU5h5ZLwDBGesP5gq0Pno+Q1JyxazFrCUKP5jx7zf14jFcfVen UTR6CyfzHnPaj8bguSrZdJq0yrvYbSTcPKEo43O129muKXSni8d3ePZpFDBB8EvQki/06+4vm5fwc Qwn3l50YgcyIbuuDprJeSO7By0M2ghteCIAtnEbQJD9ZLdS4F+s28xM35qJMsTnFkYUJ3cKP0f2ro 6jOnrz8b65q78FFiK8kfx9SMCNsYO2h51Q1LzGBNPS+JJX2RLuQBc93tjRcgMplZijYmsS0CjCxB5 y4dNZcFAQNkzdvN2J/yQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtie1-0000000EXM7-0O6E; Mon, 08 Apr 2024 06:38:17 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtidw-0000000EXJf-09Kg for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2024 06:38:15 +0000 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a46ea03c2a5so684666566b.1 for ; Sun, 07 Apr 2024 23:38:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712558290; x=1713163090; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=2w/InBAZl4oWhjZ0Ps1WovnvdcDfPtJEQD8Wh/hdLVE=; b=Yrh5WMNoykt3PvqHr9vPpiW7HBL6QOVeRj2hciVQfOQTDU6RIUsSYRGDlJBOQ+bfge Ry4pu1cDFWx4CC+2u+HJAxYB6wwQIC9p/GdjOh2zZgfoJX0iRJTrybOh4oTARrvob+9i 0WYrHxPiuUMkOh7BLQf9VNcAnnsRxcxIYxwO8KcTngGdP75zXsrXabb29oFs10Tys+yF w/DI56oW0asOA2zVvE8ynSpIivko6IGJeoFq7uNqOEG92eILINcjikVM+O7wDRBhBhGd +GpAWyZfW/mGCsjnz/erBb4bJ5IPzAdX4hGBqYLuUvp+LXsPXF0QHV1QdMOBawmKr3gG IxzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712558290; x=1713163090; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2w/InBAZl4oWhjZ0Ps1WovnvdcDfPtJEQD8Wh/hdLVE=; b=DQeFZuZ8nRg8liAhM/xJVVZAqbBfxIwWEXyIeWqv5gAZGntXJrfNW251adkTLhHw+r vDxdDAoO9R/PUAlfabHb6hrJwBF9DtWhp3ie+rta0YNp4getXroLZxEI2tYymPV9vkZf dXLjwDktFKiDGyFbHfvDANSUJ9bnen5vb4Y4lzxBtfdO5k1G4D0Wr4U+HZ39j6ifKyTv kFFvbIb010kc8brRYP782MGmBrwQKX7d44mI4vtwPG/KqTanLzhmGTFYNp//QAZkHVup r6OUa/2gglUZ6T97m1a0VL1a1RVAWxj0xNPz6gWD2QT75OUYFYYX2QmNJO2STftBM33H rtKw== X-Forwarded-Encrypted: i=1; AJvYcCU21BMOQXnEEKa2O+1mrf1MRc/auXndyE+h7EqizJGMBIEKkUv4tdGxfky7zIB6uVbNKA7Cik3+BF6/7tYEH1NHnd2KXlmOr09rQRBf2103hIdfTH4= X-Gm-Message-State: AOJu0YzF6fDPzsVJPcIrKiuQ/mtzviAedjAEWSx4FtSFEGEFr+3LJ08u kXciVfDfiklJXtRQCjx5NtN9eLY3LkomZJLW9jCCSwjGnRzfXEexc3QQU3EfYVk= X-Google-Smtp-Source: AGHT+IFGFoGB9wEcbDwB5hRjnY45bxmlcOVce7oiWq0/ZW53C83YQi+of41gg2gmA7rSpvxjCVYHqw== X-Received: by 2002:a17:907:1b03:b0:a51:dc1f:b2fb with SMTP id mp3-20020a1709071b0300b00a51dc1fb2fbmr935999ejc.12.1712558289781; Sun, 07 Apr 2024 23:38:09 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id ld11-20020a170906f94b00b00a51d8a3a632sm666159ejb.168.2024.04.07.23.38.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Apr 2024 23:38:09 -0700 (PDT) Message-ID: Date: Mon, 8 Apr 2024 08:38:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] dt-bindings: media: imx8-jpeg: Add clocks entries To: Mirela Rabulea , shawnguo@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, festevam@denx.de, festevam@gmail.com, alexander.stein@ew.tq-group.com, Frank.li@nxp.com, ming.qian@nxp.com Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, s.hauer@pengutronix.de, kernel@pengutronix.de, mchehab@kernel.org, hverkuil@xs4all.nl, linux-media@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org References: <20240408030734.1191069-1-mirela.rabulea@nxp.com> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240408030734.1191069-1-mirela.rabulea@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240407_233812_326101_284381A4 X-CRM114-Status: GOOD ( 21.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/04/2024 05:07, Mirela Rabulea wrote: > From: Fabio Estevam > > The JPEG decoder/encoder present in iMX8QXP and iMX8QM SoCs need > the PER and IPG clocks to be functional, so add the clock entries. > > This also fixes the following schema warning: > > imx8qm-apalis-eval.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml# > > Signed-off-by: Fabio Estevam > Signed-off-by: Mirela Rabulea > --- > Please correct subject. You already got comments on this. https://lore.kernel.org/linux-devicetree/2fb8c43c-c079-e04e-f727-3bc1dc29996e@linaro.org/ > Changes since v3: > - Add items for clocks (per Krzysztof's feddback) > - Add description for clocks (per Conor's feddback to the other similar patch from Alexander) > - Add "media:" to the subject Where? It was there before, so what did you change? > - Add Mirela's signed-off > - For the similar patches that were sent for this issue, should Co-developed-by/Signed-off-by be added? Alexander Stein? Frank Li? > > Changes since v2: > - Remove clock-names. (Mirela) > > .../devicetree/bindings/media/nxp,imx8-jpeg.yaml | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > index 3d9d1db37040..cc040feb77d7 100644 > --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > @@ -31,6 +31,14 @@ properties: > reg: > maxItems: 1 > > + clocks: > + description: > + The JPEG decoder/encoder requires two clocks for it's wrapper (AXI and APB), > + and one clock for it's core engine (AXI, same source as for the wrapper) Description is now redundant, drop it. > + items: > + - description: AXI DMA engine clock for fetching JPEG bitstream from memory (per) > + - description: IP bus clock for register access (ipg) > + > interrupts: > description: | > There are 4 slots available in the IP, which the driver may use > @@ -49,6 +57,7 @@ properties: > required: > - compatible > - reg > + - clocks > - interrupts > - power-domains Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel