From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CEF06C25B78 for ; Tue, 4 Jun 2024 20:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X16A+rz/kOkjA60ONTmJ6HUYtkvXETITC/f9pVviMxk=; b=YHVdrtQRo9DMkK hHCB1lWgZem7hWoaY7CDhH1eSeXvPEZM0d4y5LAPEumG3giak/KMzgrznkfeFwPtWmD+yWNjsnFDm qHU79VhCBpiN/oS2lswua10HksGBJo7tPbbV6oWpjF5zaZWKzaxBVEZ1nHcIFtNIu0ewJREdIJKX8 wZ/m3tCrFHkrYXpIML/WMEGciMZ36h6mwgtcLHTxzRc56Nb6B1cQ3Jli8iYUfAwSBfz/ZQJtGBRjY 2E+MyHLqibQx6mi0Y638ZF1c6KjEZkKq7h8S3pt/Q+ojNWUbBceoAsCQzgo2XnI1JO+DFXoQ6I4Ic G8r53txAa9piGEVweWnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEb1J-00000003kPn-3nFl; Tue, 04 Jun 2024 20:44:37 +0000 Received: from wfout2-smtp.messagingengine.com ([64.147.123.145]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEb1G-00000003kOz-0eY5 for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2024 20:44:36 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.west.internal (Postfix) with ESMTP id 5ED041C00103; Tue, 4 Jun 2024 16:44:27 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Tue, 04 Jun 2024 16:44:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1717533867; x=1717620267; bh=DUlLXHTsEg 6djmJNv5xbb47t6tnsAq3EkbdxwP3J7f0=; b=rt5wkcnM5nfIBC1sUpUxILqk/h 3hUNWTKdIdRhZUbhMnvdZvnU4dUS48V7gGT34W/W56hmC9hjAAVha8kUw0JWkJDf gS5z8hUszl1kNWEo+ijtgL/mbufSt0U1UAFyGubzl2+yTiSBnzg/NU1ViuJsfoIM 8NggfvouU0v3DWa2VGemv/HplpzozxKD8uF4Km4ckxmlzqVor8lEq5mkoHY3C8XU nd7SeQ7/kfqTcPgsFikusF2cY6UrI91h+w7dbxIKlMgPftcbhATmqPeYmb8HMxte HefpVq/tN7Rx4eBc5qBMsK8SHewA5T7v5L5aGd1LyvJn513HrqpOgYWp+Hzg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1717533867; x=1717620267; bh=DUlLXHTsEg6djmJNv5xbb47t6tns Aq3EkbdxwP3J7f0=; b=EgwAZyHxsON2JAOoKIyxIn0R6dgGdjsaUa/l5E7LmzLR wi8kUXc1jAv7EAMIyONKUqW1LCylDdn1cLZcIjkW6msibQZ+fb8+9hs0zEXY/JSn CjYhQgBmWyvMkE6Qp4qIXyoSAbeiNNI/f6yBPxdC76s8n+p8zw5v89vsoo3cSNH2 O0b+Dt//Ft25UQUhW2dbD0bZ3XFkwcXwfzpsvBqSaEpjI+OXl5HfIwyemwrbp4LU q+fb1oAuXmVkOmgCJFaKODjPAsRwWuu/cuXZccftPuvsoijH9de/dVwL0x81XIoS w5e4kLZMG2LcZayDZUw3GJgZxTcsVQDYZWUyHhIw/g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdelgedgudegkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeevhfffledtgeehfeffhfdtgedvheejtdfgkeeuvefgudffteettdekkeeu feehudenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 6F0A5B6008D; Tue, 4 Jun 2024 16:44:26 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-497-g97f96844c-fm-20240526.001-g97f96844 MIME-Version: 1.0 Message-Id: In-Reply-To: <20240604201251.GA791043@ziepe.ca> References: <20240528153717.2439910-1-arnd@kernel.org> <20240604155536.GA20674@willie-the-truck> <20240604201251.GA791043@ziepe.ca> Date: Tue, 04 Jun 2024 22:44:06 +0200 From: "Arnd Bergmann" To: "Jason Gunthorpe" , "Will Deacon" Cc: "Arnd Bergmann" , "Catalin Marinas" , "Baoquan He" , "Kefeng Wang" , "Peter Zijlstra" , "Mark Rutland" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] arm64/io: add constant-argument check X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240604_134434_485592_AA93C32E X-CRM114-Status: GOOD ( 18.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 4, 2024, at 22:12, Jason Gunthorpe wrote: > On Tue, Jun 04, 2024 at 04:55:37PM +0100, Will Deacon wrote: >> On Tue, May 28, 2024 at 05:37:11PM +0200, Arnd Bergmann wrote: >> >> I think this is superseded by Mark's diff in reply to v1, right? >> >> https://lore.kernel.org/r/ZlcODqVXTDh6n0h-@J2N7QTR9R3 >> >> If so, Mark, please can you post that as a proper patch so that we can >> get this fixed? > > I wouldn't say superseded, but I agree with Mark that we should have > the __always_inline added to the __iowrite64_copy() and > __const_memcpy_toio_aligned64() in addition to the stuff here. > > When I originally wrote this I copied the fairly common pattern of > having the builtin_constant_p test inside a macro, but I see now it is > quite common to put that into an inline. Putting it in the inline is > definately much better, so I like Arnd's patch. > > Arnd can you just make that addition and repost this? > Yes, sorry for failing to follow up earlier. I'm doing a little more build testing now, will send soon. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel