From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5250C636CC for ; Thu, 16 Feb 2023 10:19:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zUgW9OLnuXULYCzvg7/IUW5cNO76QFw8OzV0uzM4fhI=; b=3YDacngqIVfWO+ Oe9ieIDxOaIfWKjaL0EOoa5KC7Ctp4WZkdW08xmGJhmJ4GTzF7g2vmZAus50cGaG0eoafJV7QpV5M LQj3kwjZOey7OVRSL4M8sy9tmGurEmnS+OVN5rW/XtTI/LblhBXz0FZIURMGB3/+LmPwlDN9yhiQO einzhOiSdgS+h2rV+TF41gHkD/GrBghlobJysdjHAk9UIuJlrp0vZFrtwawYsGovUk6gf71VCwWAp /jPy4Ke6RV+Ofv8246HapGBGSAzFor7IbfH5SFAZCgr1Mj0l3IPJH8TBbwLLYgR7te4Ga8nsDYTZG ba3VKUhLMwqgxPtPR3Jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSbLO-009Vxc-VE; Thu, 16 Feb 2023 10:18:27 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSbLL-009Vw6-W6 for linux-arm-kernel@lists.infradead.org; Thu, 16 Feb 2023 10:18:25 +0000 Received: by mail-ej1-x62c.google.com with SMTP id jg8so3946259ejc.6 for ; Thu, 16 Feb 2023 02:18:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7xRm+/4FpVvgULsREaJ7c5e2nJTQURFW8fIUCxaU0fg=; b=TmElzeXhZ8MfrNoiINxw/tdWJq2JGa6TL8u+fpv007IvJnZRydkm2lddBKE1nx2BJJ Rfv6dGu43MeuPWiqvwnEh5bxb7+qjyc/LzEX5x1vlgxKJF3OdhBEwql+A+97nHFA0Xa4 IvUmUVjQostyxhOlmOZzCEeqa5ffZOfSuaj69rc5UgAYg+4/XpRFek4EnZKBBOZn871u vwzWNyQ8O3IZDGCt4XDzFwktjB46cBdlc3a7ipg9KSBXplNap+g0l6jyltHtPU9ieZe6 Xx8KX7HD25nSAQT8aAwjNm3bT42KF9/yH/9VsVTwqQ5QPFXssZs3867EYV2HGO4kQSeV AWLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7xRm+/4FpVvgULsREaJ7c5e2nJTQURFW8fIUCxaU0fg=; b=PkJQqYewxN9y3iAVLdY2dmg3/liU+wCsJXmg4/RqxhhVoVTf0E/9+tG6gy2pGVqwc3 qEBCQDteSl1/VJLaqRtcYvdvSNHOyNjlQikpwyMT5scniCpwn+uemzJc5XSrKJ3Fv4QC YjkX0dr5KidgIDYSwwjWXlItkM7gDERzJONEsEPYsLOVfFEaC/+7GUbwmN95EKgMDgXc CEH5S/EoVr/VEOPZL0RKIkoCC+d3U7n1E86hZ9+HGFjdfBko5je+XNcHwitn9PsEg5GX lJNQGK1l/q7nhloWdla/2tk3iI1LcqV+ZqxzA6OfOaisOTbT5Vz1lS24hiLFWZWLBmPh JDNg== X-Gm-Message-State: AO0yUKUm9iq0p2Bg/Fo+UyRs4NC/oqtG2VaUdRb44kaqXBWAP9VBgu3Q iq1qXTViz+A9OP1hHHZQMVq/uA== X-Google-Smtp-Source: AK7set+DarsZaH/hWMGy/10viYDOBB2pRRqKtjz34oEaeF2il4rj0qe7sZICD8Ug1ebcxd/f0RjKUQ== X-Received: by 2002:a17:906:3e56:b0:878:7f6e:38a7 with SMTP id t22-20020a1709063e5600b008787f6e38a7mr7620274eji.44.1676542700243; Thu, 16 Feb 2023 02:18:20 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id x17-20020a1709064a9100b008b12614ee06sm610840eju.161.2023.02.16.02.18.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 02:18:19 -0800 (PST) Message-ID: Date: Thu, 16 Feb 2023 11:18:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 2/3] ASoC: dt-bindings: sama7g5-pdmc: add microchip,startup-delay-us binding Content-Language: en-US To: Claudiu.Beznea@microchip.com, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, lars@metafoo.de, perex@perex.cz, tiwai@suse.com, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230214161435.1088246-1-claudiu.beznea@microchip.com> <20230214161435.1088246-3-claudiu.beznea@microchip.com> <485d74fe-bfb5-c55e-724f-304476624abd@linaro.org> <954cdf90-c41a-4e21-31e0-88a0baf26065@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <954cdf90-c41a-4e21-31e0-88a0baf26065@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230216_021824_069958_892BB627 X-CRM114-Status: GOOD ( 15.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/02/2023 11:15, Claudiu.Beznea@microchip.com wrote: > On 16.02.2023 12:04, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 14/02/2023 17:14, Claudiu Beznea wrote: >>> Add microchip,startup-delay-us binding to let PDMC users to specify >>> startup delay. >>> >>> Signed-off-by: Claudiu Beznea >>> --- >>> .../devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml b/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml >>> index c4cf1e5ab84b..9b40268537cb 100644 >>> --- a/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml >>> +++ b/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml >>> @@ -67,6 +67,12 @@ properties: >>> maxItems: 4 >>> uniqueItems: true >>> >>> + microchip,startup-delay-us: >>> + description: | >>> + Specifies the delay in microseconds that needs to be applied after >>> + enabling the PDMC microphones to avoid unwanted noise due to microphones >>> + not being ready. >> >> Is this some hardware delay? Or OS? If OS, why Linux specific delay is >> put into DT? > > It's the delay used in software workaround that IP needs to filter noises. Then this sounds like OS? Linux related properties usually do not belong to DT. > The IP is not fully featured to do this kind of filtering on its own thus > this software workaround. This delay may depend on used microphones thus > for different kind of setups (PDMC + different microphones) I introduced > this in DT. I understand your driver needs delay and I am not questioning this. I am questioning why this is suitable for DT? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel