From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A6D8CED61E for ; Wed, 9 Oct 2024 07:51:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iZkPBbRSepvAA/AJkm6TNe9b3MmJazsErRm3wcrYPlA=; b=sYQyFbFkku/9Gz9DCc2pHzKCUN 5QbviZ9HSIjKp44iymcr2hDuZiDQGgY4vgmfE1igG3YPAOQy8vWcvYw0o/IyeDQbJKxfTMYRzauOy hv/5/1MJKlnumrCPWMVD6jYUV1SeH1hK86L5Tx82/iOBvNTMLimm4FpvCJEhj9Es6Mn7roFjJftzV fXjb+23/Da9eDiQ2rQx95OC2QUVuIfiQ7ABy8UWwy9AnWjsy3KfaGr52CBukMnixb7/ynQ7vfxwHf G4cf17oRBLEiLxWkaAuefddGDHUbz+Bd65XB3cxGrXEAI2x73gcPLOK54TNxw78maWlKNwcXbszfN nvFCTjzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syRTR-00000008JVX-2SWE; Wed, 09 Oct 2024 07:51:09 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syRL8-00000008Hcw-430H; Wed, 09 Oct 2024 07:42:36 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1728459753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iZkPBbRSepvAA/AJkm6TNe9b3MmJazsErRm3wcrYPlA=; b=iXPR7tY8UXX+GJ2VbkU4ERkSe/+4svjnd3dqAd/4GbfIi7VBCiR0jTjsNXtMtSnr/8FQuN SVFATgW9R5O/sSTAPaimvLh63TIz+0gOLfMCV+bssLkOHs1Iz5juRg4cfpxcQ7IfVJ1QYl tIG0/7G/oiGr6NcpoZ4iHY+MMHCRooCLrB1BGJWzs0IZ3dCtMeBzmAxmcY6AdA0TLyzBxn gbY+WRJjrr+5RnPCQz7hWTtQQ6Rkk6ZpAGRwoen3xYqfo70GXLNdJphX87bNi9YKdxQHx3 BnBWKMc6kWVbekkYXzpeqiJSaWxw3+N75Kradm3tqIIpisH505hud61+FEgWhw== Date: Wed, 09 Oct 2024 09:42:32 +0200 From: Dragan Simic To: Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Caesar Wang Subject: Re: [PATCH v2 13/14] ARM: dts: rockchip: Fix the spi controller on rk3036 In-Reply-To: <20241008203940.2573684-14-heiko@sntech.de> References: <20241008203940.2573684-1-heiko@sntech.de> <20241008203940.2573684-14-heiko@sntech.de> Message-ID: X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241009_004235_259918_555B8557 X-CRM114-Status: GOOD ( 14.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Heiko, On 2024-10-08 22:39, Heiko Stuebner wrote: > Compatible and clock names did not match the existing binding. > So set the correct values and re-order+rename the clocks. > > It looks like no rk3036 board did use the spi controller so far, > so this was never detected on a running device yet. Wow, that's quite surprising. > Fixes: f629fcfab2cd ("ARM: dts: rockchip: support the spi for rk3036") > Cc: Caesar Wang > Signed-off-by: Heiko Stuebner Looking good to me, thanks for the patch. It all matches with what drivers/spi/spi-rockchip.c actually expects. Reviewed-by: Dragan Simic > --- > arch/arm/boot/dts/rockchip/rk3036.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/rockchip/rk3036.dtsi > b/arch/arm/boot/dts/rockchip/rk3036.dtsi > index 09371f07d7b4..63b9912be06a 100644 > --- a/arch/arm/boot/dts/rockchip/rk3036.dtsi > +++ b/arch/arm/boot/dts/rockchip/rk3036.dtsi > @@ -553,11 +553,11 @@ i2c0: i2c@20072000 { > }; > > spi: spi@20074000 { > - compatible = "rockchip,rockchip-spi"; > + compatible = "rockchip,rk3036-spi"; > reg = <0x20074000 0x1000>; > interrupts = ; > - clocks = <&cru PCLK_SPI>, <&cru SCLK_SPI>; > - clock-names = "apb-pclk","spi_pclk"; > + clocks = <&cru SCLK_SPI>, <&cru PCLK_SPI>; > + clock-names = "spiclk", "apb_pclk"; > dmas = <&pdma 8>, <&pdma 9>; > dma-names = "tx", "rx"; > pinctrl-names = "default";