From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5EE48C4332F for ; Fri, 2 Dec 2022 08:02:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=grQnPEgx6evdruSsceL/GqTxZtkS5dQ/8F3NcaHLDHI=; b=xnEA6eAq7vAi/t m/XCaf5gBMrSELbsCr6yK/bzPbOJ3MAhErEbTUAGLENGRs5ax5a1eU11y0jaYK/tPQEmBNAOSKu0h wanVECs+Jo1MwohlKgW3jV5olKmgc2bs5+ers8QtczEcM/+DIenj2qvAoXcALoNPHq5pvXxfHIQAZ 2cNUvYn3h0zB3NU+ParONFibT0GReHANFpiCDQLVTd4dwdYMkj12sm34h9mhRjy5ZLjXzSS3hz9+G 3CLXy83uTCCeXhqhBefNmLRuZJ0+wRel8fuikmQ9XhwnwlKIDqo0Sm5pZXNwmZtZimpWz/23uMzoz qquZzNf22AWrG/EqKQcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p10yh-00EKJL-CI; Fri, 02 Dec 2022 08:00:59 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p10yd-00EKHk-L0; Fri, 02 Dec 2022 08:00:57 +0000 X-UUID: b468fad6902c4bdf89ec38e421a1a5f2-20221202 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=OC06ZioKCxr1TzH6pR3Ogotxqv2EI13zydY5nhD9WO8=; b=tSFHzVfeH3PkxTJ5jd+cOAO/Lo4vAwBSH/Yl9INPrqYOCZMWKzgMyqTMPj2EcgQCvEx3AmOjR//YsG1dd3j7JSaWjDtuT4SILg4IvaiDD0ERuhPsKUofN9UXGArbvnYUUpkFVT12pN4xcj7LJNMPnISXFqKj2K6FxS1y8RCnZms=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.14,REQID:10a9f766-3b9f-4ef3-b14c-2745f222fe4f,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:dcaaed0,CLOUDID:54b2f61e-5e1d-4ab5-ab8e-3e04efc02b30,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: b468fad6902c4bdf89ec38e421a1a5f2-20221202 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 842916534; Fri, 02 Dec 2022 01:00:47 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Fri, 2 Dec 2022 16:00:10 +0800 Received: from APC01-PSA-obe.outbound.protection.outlook.com (172.21.101.239) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Fri, 2 Dec 2022 16:00:10 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UIKD2y7qSu99IFwssashLAhlhgr4VPSWj37a2TsUANbTDg95V4U2iNQYOme63woBDMtl+8BjzzOgc7evXgZyjPjbQ+XEh68jV9NMFwIGtVEKrtuEe4AccfCQIKz2DZL3LDGSHgiqR8qJ/ko2WH3z11yhah3nslyouekznOpi29MUmkBzf5LshNxnNncHocJF6teEzag551xvNpFl2b1bZySp0wS4HW5lEUNvE+d1Cl0W1EkNc1PLdhHUBgAtmYlCPnIUN0EdSyoFdf8jCL8xgY/BItxwnGLPvl7xpeihFIp6/yCHx3dizBOvlKzVHQosOOWBqw15Ra9/qXsHKwQqOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OC06ZioKCxr1TzH6pR3Ogotxqv2EI13zydY5nhD9WO8=; b=GFa147ZtsgWVC3PZ4df/itmR3bjlNtDgGoNT6JqH4LsB1utBnoQXXES25cLFFTACSGOMkbOjaVLJGDHp5QuUE0gPDLhes+4nfr2zFvf8DXr4eT4t8526LGLWsjaIjzee5JsIdarIDZ8mm3nJS2pn5JSG/JcopLKorCPY082g425RWVHDrlHOUBBW/pIURWyeDCOB+rOmvljqLIjyIAwiVJoKLmmL6qnCMnNMG57y95ngPqQVFXElQs9hsi+BmR4ALvXKAKSv/jFGSYptwbxoBnkyHVX+b0IoWZZgp4KF+Bc+fYKJ5LPCMsuaqNcYAVyaGcCzRs53Q8PVKy6imJljqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OC06ZioKCxr1TzH6pR3Ogotxqv2EI13zydY5nhD9WO8=; b=SBh3zbbGaeob7BvwxLnuA0JO5chtv+LN8HgZBDCgrXquwd0e2O6UbVwfH/drHrkmhgzSgs/FqBZfZ/x3YjUfYtpcAPWQlV2LF6dNW6fDZ72JJjd99JL14ieXABsV4QF6VXzV0FgUosdIjHh2+bTaF+fdlOoivLpmSPcV6dK4r60= Received: from TYZPR03MB6919.apcprd03.prod.outlook.com (2603:1096:400:28c::9) by KL1PR0302MB5268.apcprd03.prod.outlook.com (2603:1096:820:40::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Fri, 2 Dec 2022 08:00:05 +0000 Received: from TYZPR03MB6919.apcprd03.prod.outlook.com ([fe80::af56:be8f:f:85b2]) by TYZPR03MB6919.apcprd03.prod.outlook.com ([fe80::af56:be8f:f:85b2%9]) with mapi id 15.20.5880.010; Fri, 2 Dec 2022 08:00:05 +0000 From: =?utf-8?B?QWxsZW4tS0ggQ2hlbmcgKOeoi+WGoOWLsyk=?= To: "wenst@chromium.org" , "angelogioacchino.delregno@collabora.com" CC: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" Subject: Re: [PATCH] arm64: dts: mt8192: Add adsp power domain controller Thread-Topic: [PATCH] arm64: dts: mt8192: Add adsp power domain controller Thread-Index: AQHZBVc4xOksO3burUGPCkRUXau3V65Yvf0AgAAA5oCAAAgPAIAAB0yAgAABWwCAAW3hAA== Date: Fri, 2 Dec 2022 08:00:04 +0000 Message-ID: References: <20221201073328.1559-1-allen-kh.cheng@mediatek.com> <8ae2a510-abf6-6e1b-9893-293db7d930e7@collabora.com> <28d94df0-6e87-3019-dc10-a587f84488fb@collabora.com> In-Reply-To: <28d94df0-6e87-3019-dc10-a587f84488fb@collabora.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB6919:EE_|KL1PR0302MB5268:EE_ x-ms-office365-filtering-correlation-id: 1841f646-fa8c-4469-7c79-08dad43b38f3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IJnrLwz2jdUjR//WBg1hdy7NFRc5kBnPRlvN4NYx7u8tnrdmgQyRpNpO7Pnj7yJVbQV/vwhOERasaJoR6nRBryplyXwuvIYkx5eZQ4J6SZkBtCnK6TDbk7qUwwGrOZT+VSNFiN5TfCW+b8T0jDLSHMy4McBrqarb5ybNPUBEyUJbJOGIcEqwV6eoQSlMpbaOmHARr/4Zr6c3qCJVa3GAkMbZuyj3U0kpheBzRyrUGd4mah13zq4p1yUyGi9bGvPsWf4yY5XNW7yDv8Fxx28MOnmRu4NK7uzQF9oRKDnry0l11Wh050Xp+Kg/7kB8k4RQLP4eensj6nUkOhIzZ9ZRb1+9SJrYoWD5t0iJpO/RBTxWQqrAVpNBPWtuVjLL+/egbr5LvkGWJrZmgY1VtVoJF/OpxLhG73KlZC3iiVuWkFpPGio6TmDBops82Hkp8S84ZUv0QoJPljEkSytfpFvHzbuaJZ4NbQHxdfVTS1vaMf7xUiuonTz7vgK5TAr+pnKFZqlCjCb9m4x1D7fJ3bMUXYtNnw55DgzAaD6EPuNSD/eF3TVvsOW6BWKMDqfO1PgGqGVKZbpfEZXhEM3auR8mnQK0PGQ5YhNQ1UNogqM6D9vBXZj6sywaWX59B6rQxx7NlXopyMp3dlPayNwrJdl3ZNDbm0yCRzrJLo4OPUAI+CFJYnhLRkrG/CZ+IjDuoa2lmse5WQqQvQ18onAGZtDWeaCapD0HoRpC7vQ9agYtYdA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB6919.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(346002)(366004)(396003)(376002)(451199015)(2616005)(186003)(6506007)(966005)(54906003)(86362001)(478600001)(110136005)(316002)(38070700005)(85182001)(38100700002)(83380400001)(36756003)(26005)(122000001)(53546011)(6512007)(5660300002)(6486002)(4326008)(66476007)(66446008)(71200400001)(8936002)(66946007)(76116006)(8676002)(2906002)(66556008)(41300700001)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cGpZRno2aTF0bTVSdEtROEZTNWtHZmhGOU5ZY1FEUWVMS3BjOWhGRkdBU2Ja?= =?utf-8?B?MkZWZktsd2ZZQUk3OFNCRzRDN3gyMkZiWE5KRVZDdWE0bUVwR3psQW04NDdD?= =?utf-8?B?TG1raVF2RWlFRGtreDVaeFYrM1I3aHdYbXlUc0pJVGN0VVpRTExISnEwQVJ0?= =?utf-8?B?bXFia0FmSjBRRE1CK1V5ZmY2VTFCenMxRXp4RlF4V1d6UUUrcUxpTU5ZZkxr?= =?utf-8?B?Q1lGSjZnbHhGazROMTN4MkNnZDk0S09DdlZYMUp5RVhtYmZrK2REMjV5UzBP?= =?utf-8?B?RmVTUGlnU055MXIxRWZ0VXo2VVZVcXdzSlRVZWFuRCtJRStIek5ISjAxajBI?= =?utf-8?B?K0JkcUdnSTRhTWtXTTR3Zy83S2JvQ0ZNeXh1eG0zdVpBeXA4UHV2REZRYnkv?= =?utf-8?B?SmdCdXRsbEJEcUlaZlc5cWZkaFptZC9YdXovRjJ0MWxNM3BwbXovTEhUT2gz?= =?utf-8?B?VE83dkZPcHZhQ1hKUm9kS0RHczkzN05RamF1M1l6MVA4ZWVzMmhKUHBYdnlR?= =?utf-8?B?YUhTaE9sNXRIODF5Z240UVRoUXFSMFEwQVFRNU9WNkVaOEdyUkw4eTkrbmFO?= =?utf-8?B?d2pIcjFoak8zSDk0bS9vUWdXaUhBQzdob0pzVWh5UFREZVg5cnhIN1kxMlNz?= =?utf-8?B?Qmd2VkZ5WTl2a2hwVW5tZ0VjTG93YmNHdjBNckdYVWl5M2cwWjBoNk14N04x?= =?utf-8?B?UzdGMjNnQ3FOWmg5SEFDOEMzVko4MEo1RUc0Y1cxMmhwbnJFYkxQK1BXYSsx?= =?utf-8?B?NDNvSXF4NXJWTlZuWDVLZXA5eGk3cXYxNStBUVNvWHcxVVU1SDY4RWxWRFU2?= =?utf-8?B?VmgyeXNEM0FuOHd0Z0JNcUhoaTYwaWtKYnJzN1A3Q25vZzNqbUZ2SDRHTUd0?= =?utf-8?B?M3pZTE9VYW5WVnMxTGkwbWdGa2s2bXpWTmowcTRyRnZRUVp4U21oYk83QSt3?= =?utf-8?B?amtqZE1tR3lyeG5DVGs4eGdkSnNTZUFyK3YwaXBncnBBbENDZDNKZmtqeVB2?= =?utf-8?B?d2VZcmV3U3l1Vm9IVjQ1MVV0OXRUZW5qdDN0VG5malJXeTQyZDBDVE03d3Y2?= =?utf-8?B?UVplWG9xR05HczNhZzloMUlvTCtuRFdnVDdqZXl1YUsxY0ltMzBKOWNTZVZD?= =?utf-8?B?YzdYT2E2aFFJNFpWbWpWVHNiTDZ6S0Z3QVdDSU0xdHZiRGU0eWxKR3JycVlF?= =?utf-8?B?L295d095bElqVE5Ta3gwa2preTdhT1JRcHBOWXgvVVBUVjFJWFpGdllBM1F5?= =?utf-8?B?c1JsN1RGYkxDc1pDamMxYm9ON1RsVzhLcCtEWGN2TUZ2RGFIZDRLUkFyOFUw?= =?utf-8?B?WGpmRDlOTmp2dVM4enl0cW9RbEtEZGRBVVpaRTFJRGpvMzdpMkkyOEtINlRa?= =?utf-8?B?dFJpd3dZdnlYM1Zqa01WN0FNWDdEb1VYZ0t2RjFMMFN5UlhxVlJIRkhQY09S?= =?utf-8?B?ZHM3OEZiTEVFLzVVb2NCODFubXJKQlVoNWJNcDRwK1VuMWVzWWt3NkNTNVJ4?= =?utf-8?B?bWxZVkV4UlVidVdCdzhYNUVMZ2IrMkluSW9namk5aFpmTklOUlNlemxTOUNx?= =?utf-8?B?eVp2Z2N5Q2Fjck5rR1JpeXZydTYzd3V2cVdGTEhCbWVLQmJsVzBKMlB0eU9n?= =?utf-8?B?OFlJRzU5Y1hZc2ZXL29TL3lVZnBUckdPK2tJRTA5d29LMGh4bEpkRkxsTDZP?= =?utf-8?B?cWFkSjdHdjlQWUNLMFRYMWFhbkFWYnUwMjMydzBzekNUSnI0bVBQSGtwNE1u?= =?utf-8?B?ZFVrdnd2QXVwM0JucHgxcEsyWVphMnBRSXpXZEFWZ1Y1TEJuQ2JXWWdJdnFt?= =?utf-8?B?QXNGM3ZaQXJQaW8rY3R5TjEwbzlMVXdRaG5LcGpFbTg2NmNSaERNekJqQlRZ?= =?utf-8?B?YmF6NlFFYmtZanY1K2o5T2wyeVVpS3VqZFdiMkQ2UEhrNkc5SFc4UGZqOE5J?= =?utf-8?B?VFBsRm10MG55ZzZONHVVVG41QWh2ZGtuVHRrUm5MaFVJcXZnSDY1d1lPZ20r?= =?utf-8?B?NnVyM3huMkRsMGl1QmZ4QmNhRi92ajZUbk95RCt4TS85QmNpMnNRQXp1Z3hB?= =?utf-8?B?WjZzYzBFQ2VDczJ2c3l4T21RUmNjM1hSNk51YjlvVWd6eVp2bmRqRytVVmVQ?= =?utf-8?B?NWpYMmRiaUtxNkd5WHh6MlVNYnBoaGtwVnZxTjRRelI4cjNia1NCTG5rdTVk?= =?utf-8?B?Smc9PQ==?= Content-ID: <155D51069081424EA52CF1C1A5A57BCA@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6919.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1841f646-fa8c-4469-7c79-08dad43b38f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2022 08:00:04.9518 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sXTBc/B8ULEqzcbafbF64P1YcqjswBCfoajd0UwNLhfxkzMhKFu9FrABzwkhZSveZU5TQgwt3FI+kObwtqzygoPlvut4mBvQtp97ClubxFU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0302MB5268 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221202_000055_758979_3408B722 X-CRM114-Status: GOOD ( 37.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Angelo and Chen-Yu, On Thu, 2022-12-01 at 11:10 +0100, AngeloGioacchino Del Regno wrote: > Il 01/12/22 11:05, Chen-Yu Tsai ha scritto: > > On Thu, Dec 1, 2022 at 5:39 PM AngeloGioacchino Del Regno > > wrote: > > > > > > Il 01/12/22 10:10, Chen-Yu Tsai ha scritto: > > > > On Thu, Dec 1, 2022 at 5:07 PM AngeloGioacchino Del Regno > > > > wrote: > > > > > > > > > > Il 01/12/22 08:33, Allen-KH Cheng ha scritto: > > > > > > Add adsp power domain controller node for mt8192 SoC. > > > > > > > > > > > > Signed-off-by: Allen-KH Cheng > > > > > > --- > > > > > > Ref: > > > > > > https://lore.kernel.org/all/2ec80bd8-dfef-d2e6-eb41-6e6088043e33@collabora.com/ > > > > > > [Allen-KH Cheng ] > > > > > > --- > > > > > > --- > > > > > > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 8 ++++++++ > > > > > > include/dt-bindings/power/mt8192-power.h | 1 + > > > > > > 2 files changed, 9 insertions(+) > > > > > > > > > > > > > > > > Allen, thanks for this one, but it's incomplete... > > > > > > > > > > First of all, you must add the power domain on the driver > > > > > itself, specifically, > > > > > in drivers/soc/mediatek/mt8192-pm-domains.h - otherwise this > > > > > change will have no > > > > > effect! > > > > > > > > Actually it's worse. The driver doesn't know about the new > > > > power domain, > > > > and so it will fail to probe. We might need to make the power > > > > domain driver > > > > fail gracefully and skip unknown power domains. > > > > > > > > > > Right. It's worse. I don't know, though, if gracefully skipping > > > unknown power > > > domains in the driver would be a good decision... as sometimes > > > error messages > > > go unnoticed. > > > > > > When the platform "explodes" instead, you're forced to read that > > > log carefully > > > and get it working again... Anyway, I'm only thinking out loud, > > > nothing less and > > > nothing more than that :-) > > > > Me too. :) > > > > > By the way, we can probably expand on that topic a bit later, as > > > it's outside of > > > the scope of this specific change. > > > > > > Back to topic, if we get one series containing both changes > > > (devicetree, bindings > > > and driver) with the right Fixes tags and/or Cc stable, we > > > shouldn't have such > > > issue on backports so we can probably ignore that potential > > > issue, I think? :-) > > > > Everything goes through the soc tree, so they should appear in > > Linus's tree > > and get picked by stable at more or less the same time. I think we > > would > > want the driver change to appear before the dts change, for > > bisectability's > > sake (because of header dependencies and driver errors). > > > > So we probably want: > > 1. driver + binding header changes > > 2. dtsi changes > > > > And have these merged through fixes so that the history between > > them is linear. > > > > Perfect, I fully agree. > Thank you for your comments. I need to check internally with my coworkers for driver and will update v2. Best Regards, Allen > > > > ChenYu > > > > > Cheers, > > > Angelo > > > > > > > ChenYu > > > > > > > > > ...Then, as Chen-Yu said, you should also add the power > > > > > domain to the scp_adsp > > > > > clock node as that's solving the lockup issue... > > > > > > > > > > .......and last, but not least: we need a Fixes tag to > > > > > backport this fix, here > > > > > and on the commit that adds the missing power domain in the > > > > > driver. > > > > > > > > > > Thanks, > > > > > Angelo > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > > > > > b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > > > > > index 424fc89cc6f7..e71afba871fc 100644 > > > > > > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > > > > > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > > > > > @@ -514,6 +514,14 @@ > > > > > > }; > > > > > > }; > > > > > > }; > > > > > > + > > > > > > + power-domain@MT8192_POWER_DOM > > > > > > AIN_ADSP { > > > > > > + reg = > > > > > > ; > > > > > > + clocks = <&topckgen > > > > > > CLK_TOP_ADSP_SEL>; > > > > > > + clock-names = "adsp"; > > > > > > + mediatek,infracfg = > > > > > > <&infracfg>; > > > > > > + #power-domain-cells = > > > > > > <0>; > > > > > > + }; > > > > > > }; > > > > > > }; > > > > > > > > > > > > diff --git a/include/dt-bindings/power/mt8192-power.h > > > > > > b/include/dt-bindings/power/mt8192-power.h > > > > > > index 4eaa53d7270a..63e81cd0d06d 100644 > > > > > > --- a/include/dt-bindings/power/mt8192-power.h > > > > > > +++ b/include/dt-bindings/power/mt8192-power.h > > > > > > @@ -28,5 +28,6 @@ > > > > > > #define MT8192_POWER_DOMAIN_CAM_RAWA 18 > > > > > > #define MT8192_POWER_DOMAIN_CAM_RAWB 19 > > > > > > #define MT8192_POWER_DOMAIN_CAM_RAWC 20 > > > > > > +#define MT8192_POWER_DOMAIN_ADSP 21 > > > > > > > > > > > > #endif /* _DT_BINDINGS_POWER_MT8192_POWER_H */ > > > > > > > > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel