From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B0A9C7618E for ; Fri, 21 Apr 2023 20:07:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/s2IUbTKgKwylDPq5ELsv/4GdLF4icMepAhZpKk2CpI=; b=3GFj2ICQwSDFe0 oRciREogES09EpunLW+dbYH0p5mZ2oY+2mCAyfumY94zFC55rheCvRtsdK9FqASJ46qk6fGWRnoWe zLD1bX8ROn8dh5+lIQtYGp5yTomPDMLLH66g7fGwi7x/EoWH+alCIuBbjIjsC19QE/t64Hi60SKoD n6GQOAABT/Vl/WNbyxZ+ZX5lD0rglt0dMUbwqWnyyUhfNIJdlZcFcJJWowHAlirxlmTWk6awyi0dG 4YTe7H/q8oBq7PxoeDwLza2xcnpzUdaGn5uZZUPgxaIZtS1tOgOXNwmL9nYmh4Kh1GlM5g84XCQMk wiZb140dfZZnsQaNUzTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ppx1u-00BmHE-2a; Fri, 21 Apr 2023 20:06:50 +0000 Received: from mail-pf1-f170.google.com ([209.85.210.170]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ppx1r-00BmGd-1A; Fri, 21 Apr 2023 20:06:48 +0000 Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-63d2ba63dddso2200109b3a.2; Fri, 21 Apr 2023 13:06:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682107606; x=1684699606; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Dfyv5FN7xF6QzY/YKdeFbK9UZIryP5DcTEQcPzQtdzY=; b=GNR4VBD7rjwA1eoPY9Jjcnt7LXkXDMLQjWXsBza4iyKU/pDQCvqCcJ+ygb5/Wx9UI4 kUwpK5EcS/721+8QAVA9lwWhDeGRAb6Hf+ND78pHLUETxDgxnAD9za0bmXnAde2G4ERH rElZAUIef/fb/NS/awVzq4qiQG4gkNuHiYlNTSXYl5lZGJ8fWxSFBTB9Y+209fwXy5u7 gdfmDkFwHsCKd9E7wkUtKk43nB7KOiTPxoZ2judueG2TeKexV+4zI4Iwf/dxGbo9e/KJ FQqHPzpJihfT7XsLKWZPBlta0M1srlgVS+0MfruAebO73AeQu1GtXOLeZsboX39S32TA Acow== X-Gm-Message-State: AAQBX9fi5FJn0xkJw0Y8RYsX7wMKEeCKwfZKQRWwAYG1nWUPbnfjKjwb tUCDUU/VOAOPYPsklazfdf8= X-Google-Smtp-Source: AKy350ZXdc4qGBNAbdHsNqr7fR3Yeo/NPEkEskreo/KMkEW84H+StzQOr19IbrV3KCX8h/loRQwoLw== X-Received: by 2002:a05:6a00:2e8f:b0:626:1523:b10d with SMTP id fd15-20020a056a002e8f00b006261523b10dmr7418054pfb.4.1682107606102; Fri, 21 Apr 2023 13:06:46 -0700 (PDT) Received: from [192.168.3.219] ([98.51.102.78]) by smtp.gmail.com with ESMTPSA id l6-20020a656806000000b0051b71e8f633sm2956011pgt.92.2023.04.21.13.06.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Apr 2023 13:06:45 -0700 (PDT) Message-ID: Date: Fri, 21 Apr 2023 13:06:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 3/5] scsi: ufs: core: Fix mcq nr_hw_queues Content-Language: en-US To: Po-Wen Kao , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Matthias Brugger Cc: wsd_upstream@mediatek.com, peter.wang@mediatek.com, stanley.chu@mediatek.com, alice.chao@mediatek.com, naomi.chu@mediatek.com, chun-hung.wu@mediatek.com, cc.chou@mediatek.com, eddie.huang@mediatek.com, mason.zhang@mediatek.com, chaotian.jing@mediatek.com, jiajie.hao@mediatek.com References: <20230307065448.15279-1-powen.kao@mediatek.com> <20230307065448.15279-4-powen.kao@mediatek.com> From: Bart Van Assche In-Reply-To: <20230307065448.15279-4-powen.kao@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230421_130647_421470_ED44FC86 X-CRM114-Status: GOOD ( 16.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/6/23 22:54, Po-Wen Kao wrote: > Since MAXQ is 0 based value, add one to obtain number of hardware queue. > > Signed-off-by: Po-Wen Kao > Reviewed-by: Bean Huo > Reviewed-by: Manivannan Sadhasivam > Reviewed-by: Bart Van Assche > Reviewed-by: Stanley Chu > --- > drivers/ufs/core/ufs-mcq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c > index a39746b2a8be..c7b807f58dca 100644 > --- a/drivers/ufs/core/ufs-mcq.c > +++ b/drivers/ufs/core/ufs-mcq.c > @@ -150,7 +150,8 @@ static int ufshcd_mcq_config_nr_queues(struct ufs_hba *hba) > u32 hba_maxq, rem, tot_queues; > struct Scsi_Host *host = hba->host; > > - hba_maxq = FIELD_GET(MAX_QUEUE_SUP, hba->mcq_capabilities); > + /* maxq is 0 based value */ > + hba_maxq = FIELD_GET(MAX_QUEUE_SUP, hba->mcq_capabilities) + 1; > > tot_queues = UFS_MCQ_NUM_DEV_CMD_QUEUES + read_queues + poll_queues + > rw_queues; Please resend this patch. Thanks, Bart. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel