From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7D63C4345F for ; Sun, 14 Apr 2024 10:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ca2C/mWlFbxTu0BUuKliY2tYHKmNbEnymWluA2mbYNs=; b=WtXgazzYpZOy1++2RkzhyDAC8i mHddV1KlS/trpHzoNGZmwdT7BwJLYZpznC9J30FFMj3OqvRlfLpG3vRK1xbdGAQmEHsqYXL5wgD0f 9dFbO0sDRgodWkJZpUp4VbQAKic8ZF3LS7LYZDNClYUtKzpC5v1MFFMQAbt7rcBqaC+qCim5QagVv bXowvoG2MHOjDbevUT9TSLkMrpvf6oAa5iNkZx75pi7UU6nmf75TyKKWczMEqoPM3JMBIX6WHH5xq nFnYybybNhTmHtDGQUQvyLUxlVIQrWtLVColWDP0SE1zT3vnFeHtKOKRqZ91Ex/SsRMttHLIVUGRE Zi/lAHOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvwlz-00000005E7K-0iBx; Sun, 14 Apr 2024 10:07:43 +0000 Received: from mout.gmx.net ([212.227.15.19]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rvwlv-00000005E5z-0et5 for linux-arm-kernel@lists.infradead.org; Sun, 14 Apr 2024 10:07:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1713089245; x=1713694045; i=wahrenst@gmx.net; bh=BcXnyFLSiecfEm9hOusCZzYCTA6xHvCbglcnW+Su5Vc=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=AXrl34k4NiaR2xaCHzeaEXjYxpdn6m+RgoiOMGSVaIIq+ebfvFIGsR9fkBn9Vtrb +gXCgsJ4X7Gy508BafjwLAEN60VUQ9cz4in8dYLRJmEmSNoaniKWwTPZKDkXjDgLc j7Wn7lcB30e1n80Wn4O55TY/eoPXZvUhbaHGJJKFsEW0oJmHlEt8hYSmjer7TulEX 9zeG+Ir5+aYzW3JW7pW9p/OraVRmvi1b8jGbzh1Q9pxW4iprrhk2d8mQmq/3k3tdU 7HfLZIps80ScP4PruUT1xDug+E+WxeaO/DVHccwpL2OoqrLkHVgNQPxCAfpE7ByZN zrq4lcDKgtckw/9eIw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.167] ([37.4.248.43]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MkHMZ-1sbI0L4Bq5-00kcXr; Sun, 14 Apr 2024 12:07:25 +0200 Message-ID: Date: Sun, 14 Apr 2024 12:07:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/6] Add support for BCM2712 SD card controller To: Andrea della Porta , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Linus Walleij , Adrian Hunter , Kamal Dasu , Al Cooper , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Jonathan Bell , Phil Elwell References: Content-Language: en-US From: Stefan Wahren In-Reply-To: X-Provags-ID: V03:K1:accCx00poYGsvNcwQW0/34oRbtZyJ0evPPlSzcwec8RRGSsPtyL H8/yzIccKZRoXazP5Vorco9XbWGpZRbWwNDZ/I8xg3F7us6hcBusj0i3Gu5f3xS83sgaujI Kwvn2AG/sgbeHzNZEwEXEbUHp+pKoxo/by/mYab/eGqg6UXM+A6WFfnnX9jVq9Rmgz6x/gi pNbnG+q7hTDHFLJLi+uwg== UI-OutboundReport: notjunk:1;M01:P0:jbo1m5rDERM=;opjDWYBWEtwH5Lex+q8wTD3WUsl qVKp2vcCJLptK1C8b1MDSIniJP9yVPydZ/XY6XCZyJoC2kTI7RrMG97ZBpgpo7AauVWkzOdQ8 6u8j/QbbJD266Avl37xxYavcbszqnXRa5NjPzJtO3fmPaq6HS5qCuyyUQ/ZFUPkDK1jLBpg6w tJr+QJ/1wuaAfAxziJoHCyAMYGVSvd4+iwZrCp1+M21x+3G9ypX52kSWHLHGCmpKvUjKDlVYM UUUDEaqjw4t5t1A7TRJQu33otVggqtVjR740XPT9SzqrdePwqE7g91MXMiQ30VJAus3Q7Q5eM +scKWV3/tKLfLQmZUn5q4mcyNsrlArCKImQdG3z/r2DwXpDx2GGmG47LdNek8HL0auYLInfDd tiGBdXTLLNA282dbQvz+EtMG6dUP0wisxX2Soz+WK/BbuYiJxsXB/HgKzkTFEbObtRfT0nplx 9sfP9ZVfHIJCH958kpy7yjuBbxtDKd9c3rHVXDQDE+wyzpP4xGdfAt1Jg0cZunPnHWQSThVQv k7flYjpdL9hFbiVav+0ldEjT5cJYWxU5aKMJk566fhcwUjs0gvkLszDnicLBKtGHz4pK0n/1m fLFI2YN6taln4gU24mX1nRRSGf/wiq+i219Re1eBBmtz4bbszjHKeRehARinA7MZTsc05cWYC B3kgaHHg9LCLKekT9PmarzNNZ/W0RpbmLMl59U8nviS03hPF9NoFIN50BjyOV6rbvuwVMJzhf MP0X+fYTmXR5R2GedhU5hqyJoBHWTEBMyXuxAP+XTJFaF4P0xh5dbfYxyDQSGCLnPpxAxLWG2 CJR7fnkjB4Xg+sfcGA5IMJndBSbtEgLwrdsML7dNBZ7Z4= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240414_030739_667532_4D730B3B X-CRM114-Status: GOOD ( 25.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrea, Am 14.04.24 um 00:14 schrieb Andrea della Porta: > Hi, > > This patchset adds support for the SDHCI controller on Broadcom BCM2712 > SoC in order to make it possible to boot (particularly) Raspberry Pi 5 > from SD card. This work is heavily based on downstream contributions. since your goal is minimal Raspberry Pi 5 support, i suggest to use this as the subject for this patch. > Patch #1 and 2: introduce the dt binding definitions for, respectively, > the new pin cfg/mux controller and the SD host controller as a preparatory > step for the upcoming dts. > > Patch #3: add a somewhat reasonable (*almost* bare-minimum) dts to be used > to boot Rpi5 boards. Since till now there was no support at all for any > 2712 based chipset, both the SoC and board dts plus definitions for the > new Pin and SD host controller have been added. The patch still seems to contain a lot unnecessary stuff (Wifi, BT, SPI), please try to remove as much as possible for the minimal support (just boot via debug UART & SD card) in order to make review easier. Btw this patch must be after pinctrl & SDHCI support. > Patch #4: the driver supporting the pin controller. Based on [1] and > successive fix commits. > > Patch #5: add SDHCI support. Based on [2] and the next 2 fix commits. > Drop the SD Express implementation for now, that will be added by patch > #6. > > Patch #6: this patch offers SD Express support and can be considered totally > optional. The callback plumbing is slightly different w.r.t. the downstream > approach (see [3]), as explained in the patch comment. Not sure what is the best, > any comment is highly appreciated. I don't think this should be necessary for minimal Raspberry Pi 5 support. Maybe this should be addressed later. More important would be an additional patch which enables the necessary drivers in arm64/defconfig. > > Tested succesfully on Raspberry Pi 5 using an SDxC card as the boot device. > > Still untested: > - SD Express due to the lack of an Express capable card. > Also, it will need PCIe support first. > - card detection pin, since the sd was the booting and root fs device. > > Many thanks, > Andrea > > Links: > [1] - https://github.com/raspberrypi/linux/commit/d9b655314a826724538867bf9b6c229d04c25d84 > [2] - https://github.com/raspberrypi/linux/commit/e3aa070496e840e72a4dc384718690ea4125fa6a > [3] - https://github.com/raspberrypi/linux/commit/eb1df34db2a9a5b752eba40ee298c4ae87e26e87 > > Andrea della Porta (6): > dt-bindings: pinctrl: Add support for BCM2712 pin controller > dt-bindings: mmc: Add support for BCM2712 SD host controller > arm64: dts: broadcom: Add support for BCM2712 > pinctrl: bcm: Add pinconf/pinmux controller driver for BCM2712 > mmc: sdhci-brcmstb: Add BCM2712 support > mmc: sdhci-brcmstb: Add BCM2712 SD Express support > > .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 51 +- > .../pinctrl/brcm,bcm2712-pinctrl.yaml | 99 ++ > arch/arm64/boot/dts/broadcom/Makefile | 1 + > .../boot/dts/broadcom/bcm2712-rpi-5-b.dts | 313 +++++ > arch/arm64/boot/dts/broadcom/bcm2712-rpi.dtsi | 81 ++ > arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 841 +++++++++++ > drivers/mmc/host/Kconfig | 1 + > drivers/mmc/host/sdhci-brcmstb.c | 275 ++++ > drivers/pinctrl/bcm/Kconfig | 9 + > drivers/pinctrl/bcm/Makefile | 1 + > drivers/pinctrl/bcm/pinctrl-bcm2712.c | 1247 +++++++++++++++++ > 11 files changed, 2918 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/pinctrl/brcm,bcm2712-pinctrl.yaml > create mode 100644 arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > create mode 100644 arch/arm64/boot/dts/broadcom/bcm2712-rpi.dtsi > create mode 100644 arch/arm64/boot/dts/broadcom/bcm2712.dtsi > create mode 100644 drivers/pinctrl/bcm/pinctrl-bcm2712.c > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel