From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BAD2109B46C for ; Tue, 31 Mar 2026 13:43:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pIeCjgcoxzvgwKq13OIJQCoW/Qy2uQ6qa9GKE3BMxxQ=; b=ImSp+RmEJ2UIylDEcRBcrFQKWo 7XQzsh8sswS3TbA61yDWogUFeYHdr9PzX9jaBiPhMhQ+VTmzCW7+B5buxcFQCEf6s14GJkslaU20C Q0JgHiviG7aLQ094+OFjXLSLmLQCamfql01NWH/0VLZGlEecgLOdYibAXXqfIquA4VVSuQo2EVsQ2 5v5spTcAxOmw3V857Y9fTLVKBOImxm8OYoaeGWmVnW7MP2jDSnSx4D3H2vtjxUSgZSWBmrtzG+edn aOP519tsUHE9VPFm+B//VulHO6nCT4B7ow+Y8blX4Nk0rqK2DPUr1QbSQHfTKya9YxOjM1gYJgGCe F+JNM0Gw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w7ZNX-0000000D1SB-3cYJ; Tue, 31 Mar 2026 13:43:35 +0000 Received: from mail-francesouthazon11011026.outbound.protection.outlook.com ([40.107.130.26] helo=MRWPR03CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w7ZNV-0000000D1Rq-21wd for linux-arm-kernel@lists.infradead.org; Tue, 31 Mar 2026 13:43:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fLpK0zdnM7ozymWABAj5GvDs0+hbU7v0RazrHkSYz/eLFfyREO14Zdyo4qoTwnLQtTxOiWD/oy+equOpo1x9ET3SpoDtnRnJ8hIE+VgC8ARUpOigzYVu0ctWjvEDwolbIIKw3XHv4Js0xtVx1IxzoJDk9hMXVQQCZ3RePITuF46Ch5TTxHeUaGMVNP3wwBEEhgXDV+pGkN7GUqBNtfebO7nqTtJQywP3jYTWuFNlmol+WfsysVjyGvlSWK9lEHFGQfVT9teMrv1sWsAyI+yJSaoDjuMbyJdMdxMFKlZog9fUF8MW7EEyhf1Yp8KD27Xe7XCo7LBgefMT+RuOBiNTqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pIeCjgcoxzvgwKq13OIJQCoW/Qy2uQ6qa9GKE3BMxxQ=; b=p6iZySfPxKfvnuc0i1LBkjqIlfatbGySJTicbxWpK2MYa364AYlf4h+aLt8srCDowosswetUvKUlSsfSylMNAmftggYJH7UqLq0t+E5SEvLQL+yOlZxfcxEsSC0LpZ9gNbksprc0olWAymO3+Hmmh49D23fcYS7lpl7iHdR6oUWzigQzO05bFpHSvUxok7hpuEJlRg12tMRK0Pu4cYAnTBr8a1R8QJzvzpSkv25bTEu9x2O+EUoOZaVztR8ul+6hNL6fLFpbPWgufgxI27PD18gl0H++JeJv43v300nLldr+abGWBFnNXek1iC9idGdyjbSwwIrAGpfy8C104kFIfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pIeCjgcoxzvgwKq13OIJQCoW/Qy2uQ6qa9GKE3BMxxQ=; b=HpCKXy9G34Oj6IJCHATD38FzHA67UCbJwFFu8156HZGNfdaVeRigA/bCGSSRwRvJz7e6SZ1r88ntWSXfzNg11Uz5g9nh8FIiiiKCzmicmk2EGgduSfTNbo8x/UMI+1fbTm9ERgh/WMOAAcu30jK0Rqu+lCZOLl0YAaRNNi7zbdyAimGznoNbqzHilufQiKtj/T1o+Ci8sSrJc7SEq8QUaJMzQzOBqY0BmspIRE5CYYyrWvl7gYFNlImSEIMKYSkQAqzJFjpDsN5Kv03vV54CzvGXqWscghP56M9S6r0PQHSf+vNN9hyug5WmlZbzY8vSFhMUMBvG/zf7vxstz3Oedg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from AM9PR04MB8179.eurprd04.prod.outlook.com (2603:10a6:20b:3b5::20) by PR3PR04MB7276.eurprd04.prod.outlook.com (2603:10a6:102:8c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.28; Tue, 31 Mar 2026 13:43:25 +0000 Received: from AM9PR04MB8179.eurprd04.prod.outlook.com ([fe80::a551:cde0:6730:1d85]) by AM9PR04MB8179.eurprd04.prod.outlook.com ([fe80::a551:cde0:6730:1d85%6]) with mapi id 15.20.9745.027; Tue, 31 Mar 2026 13:43:25 +0000 Message-ID: Date: Tue, 31 Mar 2026 16:43:19 +0300 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 01/10] dt-bindings: mfd: add support for the NXP SIUL2 module To: Arnd Bergmann , Krzysztof Kozlowski , Ghennadi Procopciuc Cc: Linus Walleij , Bartosz Golaszewski , Krzysztof Kozlowski , Conor Dooley , Chester Lin , Matthias Brugger , Ghennadi Procopciuc , Larisa Grigore , Lee Jones , Shawn Guo , Sascha Hauer , Fabio Estevam , Aisheng Dong , Jacky Bai , Greg Kroah-Hartman , "Rafael J . Wysocki" , Alberto Ruiz , Christophe Lizzi , devicetree@vger.kernel.org, Enric Balletbo , Eric Chanudet , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, "open list:GPIO SUBSYSTEM" , linux-kernel@vger.kernel.org, NXP S32 Linux Team , Pengutronix Kernel Team , Vincent Guittot , Rob Herring References: <20260120115923.3463866-1-khristineandreea.barbulescu@oss.nxp.com> <20260120115923.3463866-2-khristineandreea.barbulescu@oss.nxp.com> <20260121021913.GA1704619-robh@kernel.org> <7d200097-51bc-4404-be8b-f536d0ecfc25@oss.nxp.com> <21531cdd-5ab9-493e-a722-61b98117e2c4@kernel.org> <22a5a072-847e-4cfd-8abd-e37163f73265@oss.nxp.com> <3c454da1-d949-4258-87ce-8b545000bf01@app.fastmail.com> <5f1b651b-1064-4280-a7e0-b7d66c396cde@oss.nxp.com> <4c46909d-641b-4389-bc4a-29394cb1d46d@oss.nxp.com> Content-Language: en-US From: Khristine Andreea Barbulescu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS4PR09CA0013.eurprd09.prod.outlook.com (2603:10a6:20b:5e0::19) To AM9PR04MB8179.eurprd04.prod.outlook.com (2603:10a6:20b:3b5::20) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR04MB8179:EE_|PR3PR04MB7276:EE_ X-MS-Office365-Filtering-Correlation-Id: 18c9fa1c-aa5f-49f8-eb3d-08de8f2b7b15 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|19092799006|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: fvZoQnCpk9obq9AvDeLkVSe77jO+y/AG/7/odt8UWM7zfPwdowCj2AXY2LuZ9994RDx42qN3VtRaDetyFpdJAPdJQFjeK6//fNLCsQP7FUikBAVBByUHMHRqPkyNhCu3fquRC44sdtguP6auD7B9lo9n40Gy2wW1ANiwiygb9zS3o5MnEiVWweWc9nRV1yBjLAGKxUywjqJ//2dbFC4DKuE15bMe/Ij8NXWC9llWyHcdD/MLzgS2nd3Mr1RYHouae2t9Wx6JhN6TeTijOYUcSSPzzanjUr70FYHtB8+ma+sehmzdTpiPxpEVaWK/PM1I1Wm8gXNS3MXI/HPM6TX69D0tSliXjVV/Owkb5B3NzwtS5jSP16NtaD+N5F3E2IWofcRdTMSkojGmN09jS6dAWYohrqgpf+Zt1JMkCgTDvtkw8INYEVCl4GCnvUlfHOAz4obx4xwTmuf4Ax3PbiKFWtaXicJpd5lvu19X/kqETmhMC6nohTM2C5wB7Y+AE5jzJ44YRFLYcRjyx0jcLysWrsibbc/1NZ3qPjW6wRlWmO5wAZmfYRN1kufe9YShPilV08FCKJYFpUxd4cBRTGNciVaUE3iQfBZ42FiNpsV/ahBLsrjZstaSNxJCkmaAXPi/3lBSskyUWkrpTw+P/nYnCSO4UgD5AYa/yf2dn2XlHRiCrfwwCznbYItw0irvcnNYsu8unxVNTF1iisGjigjxPnqcJQJsDi66hudVo3Q0MtvnQV/pYAq+vxyZ8IPvTunf X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR04MB8179.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(19092799006)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K21DS1U5TTNTaEZrOVBqTEw0ZGNSclJDcVBzeXpCL0VNWW0zUHNhQXBMTlE5?= =?utf-8?B?SEZ0cHNyVlQxem1LeTgxRDlYcjg0c2RWRnE2eUpmc0I4bENyYVdVa2h3N3py?= =?utf-8?B?WS80MjZKQmRoZ3RzS2tOcUJ6Qlh4Um0yZWtKQ0c3d3YyUG54TllOeU5EbFFS?= =?utf-8?B?QkJUOStPaDQwOHhyOUxkS2MyR1puaUhxUGhyTFNWZmx6dHNFbW1CdXoxWmlW?= =?utf-8?B?T1B5a3pxMkt6L1JlcExEeHNKS0RMWGZZM05CdXQxL0RRZExzZU8wYXA1ekgw?= =?utf-8?B?Z2lsNzVheWgvVlpZWWlTNTRzSDVQM1ZCWUxJTEV1bUJMYkFsWTlQdjlkS2hZ?= =?utf-8?B?Tmt2NURpdGRXOHViVmJoSEZuOVJPVFdjZjRXRTdDdWo3Y1hxZ0dsOFJqcWNL?= =?utf-8?B?MEtnN0lldU42OUU5Zm9mNWlrS2pIUkE1WlNHeFhUUGUxV25PVHA4bFZYWDFE?= =?utf-8?B?ektxU0NRRUdhVjA2UldwQWlUTnhIMmVER0pBYkdDN2FnTGZDbnJNZk1Wb2pT?= =?utf-8?B?cDAvWmFZaW1nVW9IS3ZQMzJ2WnI1cWNLRlJNLzNmT2R2SmFEV1JtZzdqTDlR?= =?utf-8?B?VjdEVnFkRnVod1dRZ0FMYllGMkY2WllSOFpGdGdHSHRwMVZnV29SUzhSRzJQ?= =?utf-8?B?cm9ENytwQTk3dGpIUWhRajQ3VStKWHZzd0hHakU5R1pMUVNlcW9DUlh4dWs3?= =?utf-8?B?RnFWS2Q5c1UzcUo4dkZtdUJsdzlEc1pXY2t2VkZqdG1wdUNNaTlQUkIxQVlk?= =?utf-8?B?c1hSemdtRXF2WDl0OTFiVXkyQlFrU0J4Zk5vODFKZlMzL0srRmRLRTAvWnR5?= =?utf-8?B?eG9hdXdwRE1FS2NkSHZUUkpnTmx6UDNqaEhiNEp6T1czd1p2MlZqQU5qYjYr?= =?utf-8?B?d1hNYUFUVm9JMExvcUlHZkhGbHRKSVhYYURPV3dKWmdXN0NpcGh1cTVEaysx?= =?utf-8?B?OWxDNHVJZkVYSGc3MU5BOWduR3VzSi94TUFNV1lSQXRkZFlVcGRWSDJrZDRU?= =?utf-8?B?WkxJOVZyUHZsbW1zKzhFNDRzRlpxbE5hRk80VWQ0QWExNCtEN2g3YVRGcHdk?= =?utf-8?B?ZUZrQTlUZmZDcFo3K1VtVmo1cmcxUUFJTENVV1dWSlQwbktnOUc5bDVFdm1p?= =?utf-8?B?VTNyM1ZIc0pidmZDSk9BbTNvNmFBR3Y2R055R2hOZXdJTVc2MGdyTXF0dWtZ?= =?utf-8?B?UmQ0a05SMVUyaXdTaEVEaW95R1haclBwWTIxeE9ITmJpR0ZQZDRXcUFvakk5?= =?utf-8?B?TUt6ejBwQ2JXbzlLWHhVUDV4TzRPa0U2RVI5cDFtV20rSWRHZE9tWDMzbTRa?= =?utf-8?B?OVlRMHZ6dlhrelVzUFlzSXZTQkRpTDVsUGZheERvMTZBS1I5SjIxNmJRWFZM?= =?utf-8?B?YzVCNERlaGsrWmo1SnkzYVYreUJNamdvOTZCNUgzYkExWWVETnFGOFNBRlVq?= =?utf-8?B?d3lpSC9kYkI3c05UVjdRMXpUS1NkZGRVdkFjL2lGcFNoL0FCUGYyTUVwZGtu?= =?utf-8?B?cytaeGhqQVRmNCs1dzd1YkxFMU9xRFdtNHdxYi9Vb1I4Y2dVT253ek9aclNQ?= =?utf-8?B?eklIdEE1Y1FNOTFlZHVTL2xDRTI2RWRSdWgwY2xyQkYvczluZ1V2a3lPZFkx?= =?utf-8?B?bHpidlVkNVVWNGhJeHdTQ1plZXZSV3ZPTkZLU2hRb1RBK2N2Vm9pWGl0alpi?= =?utf-8?B?bkcra1NqTHpwK1BSaDRNcmIyVWpidVhuem0vdFN5MHBoUldPc2FEa3NBekgv?= =?utf-8?B?djQ1RWgxcXhtcTNXYjFKNzJETmZLRHVoR2NHbTV5WkpYM2pZTFNsZ0V6OTNH?= =?utf-8?B?R25KUHJQTVk2eEUxbE9tMlg0TjFiWGVRTHpheHBsUTJIcC9YUHRBZHl4aUoy?= =?utf-8?B?RFk4d2F5dHd5N2RndHNDQ05BZEI5elc5WkJ0QWMwa3JkOWNqN21LUzEzaFZP?= =?utf-8?B?QkRVd0R3cyt2V3dTaWdPeTFvMVdkUVNwcWxJSU5vdWRBYlZqRXd2Kzhua1lG?= =?utf-8?B?SzY3RXdjZ2YwWGlNSUI3MTNhVGpWQVRBemhnSnhjRis1M2U1RDlWZE51bWlw?= =?utf-8?B?QmdWRTZXaXNQMnhsRExGOUlBcUl5Lys0eStLdFMzUmwxbVdqWFF3R0FkajR6?= =?utf-8?B?VXM3Zjg3Sm1JQWUzQ1owMEJhYUwyamwzcFVwdC9JaWkweVl0WjhpMlRsR25a?= =?utf-8?B?c0Q4c3VBYTgveWpHU0haQjhSUDRKdVJObHVOTjluTUIwakpTNGdweElyMGxi?= =?utf-8?B?cVZQc1l4L0RzcVhORTNKbXdUUWRheDBiMFdhaXpHTFhFTTV6UXRtVVJqdjN2?= =?utf-8?B?LytaalJLUlpDaE9tYlN2bncvUHZteVY2V3NleDBkckRvUUc4Y3ppWFlpZGFq?= =?utf-8?Q?D7VDyLku2Y4AV0RiwmohNRX9JV/lvvVaes8wa?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18c9fa1c-aa5f-49f8-eb3d-08de8f2b7b15 X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8179.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2026 13:43:24.9598 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AmKJyK4ww1nQI5syrkVYtF+f/OMG+I32sSRnK5ASji/g6C0ZhnEgAFpHoKmZAJKTo9w5S8NPPVLpVf5X4mZbQGN7ks/JAqwBPh8DKkqhjtXpn8MFUFA0YVoRQ5bTaHbi X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7276 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260331_064333_553210_F3309515 X-CRM114-Status: GOOD ( 26.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/31/2026 1:11 PM, Arnd Bergmann wrote: > On Tue, Mar 31, 2026, at 09:48, Khristine Andreea Barbulescu wrote: >> >> With the current layout, the SIUL2 node itself now contains the two >> MMIO ranges directly, while the remaining child node is only the >> pinctrl/GPIO function. > > The thread started by saying this is an MFD "It can export information > about the SoC, configure the pinmux&pinconf for pins and it is also > a GPIO controller with interrupt capability." Having a combined > pinctrl/gpio/irqchip driver is normal, but can you clarify what > you plan to do with the "information about the SoC" part? > > Was this a "soc_device" driver, or something else? Have you > concluded now that this is not going to be needed at all? > In that case, I guess having a monolithic driver is > indeed simpler than an MFD. > Hi Arnd, Our initial intention had been to expose that SoC-information as discussed in the earlier revisions of this series. However, taking the review feedback into account, the current direction is to stop handling those SoC information registers in the Linux driver altogether and instead rely on a boot firmware to pass that information forward, as you suggested. With this approach, the SIUL2 driver would no longer be responsible for any separate SoC-information functionality. In that case, I understand your point that a monolithic pinctrl/GPIO/irqchip driver is a better fit than keeping the MFD structure. > What I wonder about then is whether the binding needs to be changed > at all. With the current nxp,s32g2-siul2-pinctrl.yaml binding > and pinctrl-s32g2.c implementation, you seem to have a monolithic > device already, though missing the gpio functionality. Rather > than completely replacing this, I assume the easiest way then > would be to add the PGPD registers into this device node, right? > There is indeed the option of extending the current nxp,s32g2-siul2-pinctrl.yaml binding and adding the GPIO related register areas to that existing device node. > It is still a bit weird to list the individual register areas > inside of the larger device here, but that still seems better > than an incompatible binding change. > > Arnd However, as you mentioned, this is still weird because it means listing individual register areas of the larger device inside. For this reason, I was wondering whether it would still be acceptable to move forward with the new binding introduced in this series, but simplify it so that it describes a single monolithic SIUL2 pinctrl/GPIO device instead of an MFD, following the example node I included in my previous reply [1]. [1] https://lore.kernel.org/linux-gpio/20260120115923.3463866-4-khristineandreea.barbulescu@oss.nxp.com/T/#m778088251774a15bde7463350d6e75d5e9b9b57d Best regards, Khristine