From: david@lechnology.com (David Lechner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: davinci: board-da830-evm: fix GPIO lookup for MMC/SD
Date: Thu, 26 Apr 2018 20:39:49 -0500 [thread overview]
Message-ID: <fdc2aa31-de60-d44b-2ae6-ba5b52ef0360@lechnology.com> (raw)
In-Reply-To: <20180424143506.25793-2-nsekhar@ti.com>
On 04/24/2018 09:35 AM, Sekhar Nori wrote:
> The GPIO chip is called davinci_gpio.0 in legacy mode. Fix it, so that
> mmc can correctly lookup the wp and cp gpios. Also fix the GPIO numbers
> as they are not offsets within a bank.
>
> Note that it is the gpio-davinci driver that sets the gpiochip label to
> davinci_gpio.0.
>
> Fixes: b5e1438cf98a ("ARM: davinci: da830-evm: use gpio descriptor for mmc pins")
> Reported-by: David Lechner <david@lechnology.com>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---
> arch/arm/mach-davinci/board-da830-evm.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-da830-evm.c b/arch/arm/mach-davinci/board-da830-evm.c
> index 004f9c8de032..d1e8ce7b4bd2 100644
> --- a/arch/arm/mach-davinci/board-da830-evm.c
> +++ b/arch/arm/mach-davinci/board-da830-evm.c
> @@ -205,12 +205,17 @@ static const short da830_evm_mmc_sd_pins[] = {
> -1
> };
>
> +#define DA830_MMCSD_WP_PIN GPIO_TO_PIN(2, 1)
> +#define DA830_MMCSD_CD_PIN GPIO_TO_PIN(2, 2)
> +
> static struct gpiod_lookup_table mmc_gpios_table = {
> .dev_id = "da830-mmc.0",
> .table = {
> /* gpio chip 1 contains gpio range 32-63 */
> - GPIO_LOOKUP("davinci_gpio.1", 2, "cd", GPIO_ACTIVE_LOW),
> - GPIO_LOOKUP("davinci_gpio.1", 1, "wp", GPIO_ACTIVE_LOW),
> + GPIO_LOOKUP("davinci_gpio.0", DA830_MMCSD_CD_PIN, "cd",
> + GPIO_ACTIVE_LOW),
> + GPIO_LOOKUP("davinci_gpio.0", DA830_MMCSD_WP_PIN, "wp",
> + GPIO_ACTIVE_LOW),
> },
> };
>
>
Reviewed-by: David Lechner <david@lechnology.com>
next prev parent reply other threads:[~2018-04-27 1:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 14:35 [PATCH 0/4] ARM: davinci: GPIO look-up fixes for legacy boot Sekhar Nori
2018-04-24 14:35 ` [PATCH 1/4] ARM: davinci: board-da830-evm: fix GPIO lookup for MMC/SD Sekhar Nori
2018-04-27 1:39 ` David Lechner [this message]
2018-04-24 14:35 ` [PATCH 2/4] ARM: davinci: board-da850-evm: " Sekhar Nori
2018-04-27 1:40 ` David Lechner
2018-05-15 22:53 ` Adam Ford
2018-05-16 10:14 ` Sekhar Nori
2018-05-16 13:34 ` Adam Ford
2018-04-24 14:35 ` [PATCH 3/4] ARM: davinci: fix GPIO lookup for I2C Sekhar Nori
2018-04-27 1:43 ` David Lechner
2018-05-01 11:36 ` Sekhar Nori
2018-04-24 14:35 ` [PATCH 4/4] ARM: davinci: board-omapl138-hawk: fix GPIO numbers for MMC/SD lookup Sekhar Nori
2018-04-27 1:58 ` David Lechner
2018-05-01 12:16 ` [PATCH 0/4] ARM: davinci: GPIO look-up fixes for legacy boot Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdc2aa31-de60-d44b-2ae6-ba5b52ef0360@lechnology.com \
--to=david@lechnology.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox