From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F8B6C43334 for ; Tue, 14 Jun 2022 08:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DRKWGoD2hdy4NRdsE1PIuZjj5ysjcsYBSC4FBPPDAoQ=; b=sDhWxeme2XfQvD JaNsRF/nW/Xppe9ozYRYCo0/51R8tQG1C7CLCnHYzSL4ZJt0PB6NXjAzSAUmkOPbJTsyM1FN9fljx KHoBB20xNUHHwE4+KGv0iEBTD8Mryaf3Ru2vHfoX3kBq84XNbKxZTI62sc/lbiID9y2W3z9oEQKDI 0+b9OTx4PQTu7N/mROsrmlpNN8Dlfw210/yPKJN+dvIkS3utdDL1tFYGjUsbTpY8hrqvGLDUIzG7Q 2WXc8h/hAQLyy9q9uvWJgzBBxq8PRiWkGjd6sWEODpzeAxwtmM+eaWqkR6XOMTqp95MYlCyt2fyhL /tZR4F51FIgnhRYkFGOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o11ok-008Dzh-7M; Tue, 14 Jun 2022 08:22:30 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o11of-008Dxj-S6 for linux-arm-kernel@lists.infradead.org; Tue, 14 Jun 2022 08:22:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1655194945; x=1686730945; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=seANASrcvsnON1nTF3ew/+EZ70yfMptdnyivQmOmb30=; b=WFhy+ylYGEgkmcbTdglPw6JSZt7eekXPwK7Ppi5NvMuTEUe+jfTjR+VR +23ULYWkBbTBKUegKbEskSyF6SfUAKN9N/gxTrQr2iWog/tvhTUsNAiyV Md6tTC+uDojYa2TzpRN+JKdnJMy9MAnIKD61Dd/LBEE9+HPuwgkIpqI/b WDUgA5mkA7vRPRFGc4uuvWP1sHQD65dDWH49XTt9++w5+Siu7aN+kS1/S NXgpw/flERG6X83cNV3w4JwgMuFwhRFgPaTmeIZXTq9JUO7ujlEN3SSJl +xk3oK8ThHGD2cdzGojmn6+Dx8g2nFgAdl/qmN5MT/qP2uLrbj6tBlxLx Q==; X-IronPort-AV: E=Sophos;i="5.91,299,1647327600"; d="scan'208";a="163240812" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 Jun 2022 01:22:24 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.87.72) by chn-vm-ex02.mchp-main.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Tue, 14 Jun 2022 01:22:24 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17 via Frontend Transport; Tue, 14 Jun 2022 01:22:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YjJebnBxUmepr46tlr4wlZ7XpqE4tYcdIzDTwBCo29fsO677xHXpq7aaRgLOHTklL5dJ+vIlZfsXrA3cu0sK6D4DxTui8HV2fi/Er8k9nAUS6ltb949o8fKA9tOO2ji+bpHbUPDGl5jLVq1eSBCSkQBEcyqFl+BDqfSTIPE8Id//q3zBQlgrIsH8hUbPDLQ+StWpnj4CXp2DpDe4Lc7IPRns7cPPkABB5w5Fft2dyX7kqWl7rluYlbrscs96GI02dipOhGRZCFnfVnPuKB3dQdDHfZdrbHM56o4R/L+mEIw79M1+z3xsaKtq0J6ItDY28lLfkKcQb9kLvnt14F4qWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=seANASrcvsnON1nTF3ew/+EZ70yfMptdnyivQmOmb30=; b=D85MfOu0hJQGz6HWC3HEWV/yOPz2zQdGPKpY/T0OIHalBNneuiuUlD5Rvv45PXPre2dJtwCnx/iPgpDuR0a59WHbj9j6zX+wCaOa2as7eKKqU3PrJmrL9Vwnk/5mm/TmbQJSDRYHGqermmL/Ij8QOiuvUwMAkPDL8KoHbVNr7m/TPVHZv4QRPjw+oYlnHE6PBKCRbuFAUATRTLrQCOLdjIY9AY5F9zAQ0OC+lKvGu+c+tbwCxdxiQjdx5KOEM0/kS6sdWq3zCQGcEGU1IbQ8aVemBMgeBaWfe2P4OxOgmXThwcgNbL7eHX+DFFHw3Ck7eODWZyvwF5LhFEpkpffevg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=seANASrcvsnON1nTF3ew/+EZ70yfMptdnyivQmOmb30=; b=NrwcEFVh0BMgmNpkkUrI1lwJpvrMHMZHL4kAnIVSeVIrZBDnnME7GU9/RQVCUe73gaS6Guh3BLOeBML8xRFJmqdJDCwooYpKSS2bJ/JQcMNVmnsHVHMGVc0BD9TlEHlH13mMSDpMEF3+HaurRAiDBO80TcALgASZutEX9CQISEw= Received: from BN6PR11MB1953.namprd11.prod.outlook.com (2603:10b6:404:105::14) by BN6PR11MB1698.namprd11.prod.outlook.com (2603:10b6:404:42::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.12; Tue, 14 Jun 2022 08:22:22 +0000 Received: from BN6PR11MB1953.namprd11.prod.outlook.com ([fe80::5cfe:8088:aa93:fce8]) by BN6PR11MB1953.namprd11.prod.outlook.com ([fe80::5cfe:8088:aa93:fce8%3]) with mapi id 15.20.5332.022; Tue, 14 Jun 2022 08:22:22 +0000 From: To: Subject: Re: [PATCH 06/16] iio: adc: at91-sama5d2_adc: add 64 and 256 oversampling ratio Thread-Topic: [PATCH 06/16] iio: adc: at91-sama5d2_adc: add 64 and 256 oversampling ratio Thread-Index: AQHYf8ffTYo8IJ39v06rHAtyU8xGiQ== Date: Tue, 14 Jun 2022 08:22:22 +0000 Message-ID: References: <20220609083213.1795019-1-claudiu.beznea@microchip.com> <20220609083213.1795019-7-claudiu.beznea@microchip.com> <20220611184731.7c100a08@jic23-huawei> In-Reply-To: <20220611184731.7c100a08@jic23-huawei> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e76cc47a-aae7-44fc-298e-08da4ddf019c x-ms-traffictypediagnostic: BN6PR11MB1698:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EOXKTR0JygIhKt6RoVi+DjqSon7OLL15h3CQKPTgI6/FQ6hFwMUD9XumB0qDkg16HzwgtRFKLxz6mghq4nDmDqjDvXU5gOoHIwoW/keHd8c64XxzPSxDsztF5r1TbZDYF8Gc47DYXwtrCaqcs8kjoloI33DJIgi8rtWAxRWx1kWD0+nffK/l2AFrdgWDQgaVmyHtUd+fCyB/jN5iesAwDTBj/kfHWQDXnuJU3+JyMhejp25OHbAu/7ThRiBvNejBiMG4Z3Blu9q0YoJX9GnpwBImQ7URbNwMWSy74lB9oYZwgJegYMky0nByKEx6aMsiFSTpoVvbgmxOKW9SeyxRAENWyIW6RyQswrb0tjlbIQ1aJsbZ+Eh1fe9uRgzF+78H2sdgMO4b8xTlJ3B14qxKXqwpi24y4qxOwTtbOWW2Q77iQ95OaqkFm9q2Eokcv7h8lJH8I9wp+9T+133ENdQU6TueOeWrp4znM9upe/tatqeyfJm24NpLP/Zps7K/J8kwQbqtw897mmzqTIqD7VUbWX4kOaXmneWm1H0l96EsIfaZqYnaHtDN2sPpLAO/mSc2/eG8ZkgM7Hzw+WoKamsKrN8YToLLqs66viMIVa3na95SjJal3IK9VpA79OtG/n65t8sOAPl47dizORbUyMiK+//QeWh9O4oq+kjYqnRuu2wCeOxcT7gH1uah5ctXCUy68FPYOy1+xw5RwvmBCA/B/SdiCkKMNST7BtDBjXqLAKkInQJ9RHPMNCcWKMALzKDD2ZzHyz4PAYz3BVu2l/9PIg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB1953.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(66946007)(316002)(508600001)(6486002)(53546011)(91956017)(54906003)(6512007)(71200400001)(36756003)(86362001)(6916009)(5660300002)(8676002)(26005)(2616005)(2906002)(64756008)(4326008)(66446008)(66476007)(66556008)(31686004)(76116006)(7416002)(8936002)(31696002)(186003)(83380400001)(6506007)(38100700002)(122000001)(38070700005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RG5JdWhhUUxEMlNaUmFON1E1b3hmZVFXNkVBZXRPOWJmd0RVYTA0RnJzb3dj?= =?utf-8?B?Y3ZkQVRQQko3WUI0WEk2dUtUN0t4ano0UkJoYW1Ca2ZTeUhWMjdyb1dWL0Qx?= =?utf-8?B?Tmdra0Foc21ncVlLcXcxYXkxMGg3dmQ1ZU1iSWhMTE1NelMweWRDMkk2SkhX?= =?utf-8?B?Q1RsNElyeUZRa3NQdHZ6eFhxMDNRY0FaYTZzK2IzK052N2VDYmpmeGZpRjZP?= =?utf-8?B?L3RqVlZUSitLMGZDQ1BaRy9HdHBTYnhHc2w5eEJqcHI5c1JCcmlSVW12Y3Fo?= =?utf-8?B?MEI4c2Rlb0FNb2hlT2tHV3I3WGs0VjNnWHZMSW1KaEVTNXl1cmRUMktwTTNL?= =?utf-8?B?aHVHeWlMOVZ3eEF1R1oxUnJ3TzN5UXFXYkIzRlArcW96TUFSbFBoMEZMMVBD?= =?utf-8?B?TTQvK1pPNEpFaU9lL0RIWmdPK004cEhhU2xxQVY3RzB0dXc1NEN6REpRdVlz?= =?utf-8?B?cFpVQnlxWkY3QmVwYlFvQWRXQWZrVkxUQTdleGVpazk5VjQ2UlV2V0pEVy9l?= =?utf-8?B?NFdsak1oZ3RmZnFhckI2TzAwSjV3VWp0Mm9ZNzNPOXliakVLSUNDWUZBR0Ix?= =?utf-8?B?bVk4cjdDUE5nMmJNeWZ1emdiaU9GZWdSMHg1cExJRGEyOHUxeUgyTkZOaDFn?= =?utf-8?B?Z3NvQnM2VHZmWG10cGt4bXZvVU1yTlowRDIrSkxnWHY0djRRakRkTEdRN2pw?= =?utf-8?B?ZUlJb2ZQYkdFOU80aUtuU0oyWVJGenlnTXZNK0pyRk9DMkpkSll2dGlDeGIv?= =?utf-8?B?S3JwMi92bmV2MktrbzJnZm9tVFlCeFVuUitDOVQyOUQrbFBZZEJEN29sT1M1?= =?utf-8?B?SDlidkRKZ0FVVGlSSUlyeDlqTUFVRFBMdWdjYWZoeGRsZzJYRVN3YUF6TlZo?= =?utf-8?B?SlMrbHJiM1lzViszckZSUW1LZm5lWUlGQkQxckNqWmprZURxaU4yWmsxdWgz?= =?utf-8?B?d2FxOUpnaXJSMGVibXkxODdjcWxMbHYvMmFkOUdhS0plNHlOL2IxNXVrcXdP?= =?utf-8?B?eXYvejF5elBTQTY2VExyN1cxTkZPNStvM3FNdzVwZTNrb29SSjMxVzQyeXFw?= =?utf-8?B?Y1ZkR2w2MzBkTVIzTFJUWlcybVY1U2pXRnB2RW96MmQzelNkWUlIQ0Z3anlp?= =?utf-8?B?TVd0TUdWVzBRbU4va2ZXcTA2YzNPbDd6aW9DM1VsSE1yeWZIQXFGcFU5eC9X?= =?utf-8?B?R3JiY2NTSlEzQlJ0azYycm9mTnl2dGNLUk4wT3lEUlhUYUZVSU16dk15RDBw?= =?utf-8?B?N2pnUkJnbGtqRXNSYjRJeUpPOFF3V2x4RVZtRUJ0cnBWazRRTU9uU2V5b2JE?= =?utf-8?B?aHFmV0RYcGNtR29RUXVBWlJxL1RJRGN5VlJuZFZnZFVCUXpvNU1ZeklvcmJW?= =?utf-8?B?NHZzSERyZXBVeFRXSTVMUndReFNqd0FPMndDVDN1Uk0yVXpvUVVxTjh2NUtE?= =?utf-8?B?UmRPL09ML1Jhdk1KRW5jcTJJdkp1WTl1M3VYcjQ4Z2FNais4Qmo2a2h6QnVC?= =?utf-8?B?Ukh0R0hWWVkzVWpObGtMNE55WmtkS1dsRjlzSmptM1B5Nkh4R2FENTFieWJF?= =?utf-8?B?aXFvTTBLdzY3T0VGdDNuWVRvS3FXS2M0SGk3V0d0SE9vQ0trN09HdzM2dmJw?= =?utf-8?B?cytac092OFNSMUlzekVzUStRL2dzQ1BYMnpmZ08xKzl3WkNvaEZibWNLQ1ll?= =?utf-8?B?WFZVWmhtem9KRmlWaHIxQU1tZFJLMDFIK1RqZ052c1p4L1RxWjJaendnVTR1?= =?utf-8?B?OE5zTEo2cFN3MkpWVlI2VDljcWw5eE5hZUdYNFc5THNRTC91aEUrSHo5d1ZW?= =?utf-8?B?dE9aV2xTVkdOcGlGK0JzMVp4ZUVsYlN0VVlYa21DOGVQS1N2eS85U0FyOVBz?= =?utf-8?B?WUlndWFwaUJlb0tJYkI0K0xWdHFyNU1wYXc1WnF4aHFubzEvVHpzOVkrOUYv?= =?utf-8?B?Q09aeFE0ZEFpd1BtZ3ZRWDRQdGwrRWFlQ1pDK0FBYm01UitqbWVkbUtEMXpV?= =?utf-8?B?dWVMaVQrZW5DejNPdjd1NWk0YzNkY09kMmdDL0xOZUQ0N3oxck1PeXk5Tkd2?= =?utf-8?B?U21zc09HaktERTdmbnZ2dEo0WGp1RzJNTVN5ajl0b0NaRUc5TTFBY0piZTlZ?= =?utf-8?B?ZWFGdTlsUlp1RVMzRXZYaFhuRlZqRUN2SDRxZ3E2dXF1T2E3NHJKUTlzYStY?= =?utf-8?B?ZTdTTjZNU2ovdWg1YW14cGhSRHdmbFI0V3VvbEV6L0FuazBNdVdGdm1zcGVV?= =?utf-8?B?N2FlU1A3eTFFRXd6WGlwWHVsOGhsWDVacFhWaE1iNUFMMXdmTHk4RDlPZWRj?= =?utf-8?B?cFNBd0hndDVhdkI3a2dlOU0yTEJhdTl4ck0wVmRZYU5DY0g4b2gyT2QvTEZ5?= =?utf-8?Q?1G/+Hh0GVaQe196k=3D?= Content-ID: <876BD6B9A7869543AB9BCBA1306038D0@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1953.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e76cc47a-aae7-44fc-298e-08da4ddf019c X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2022 08:22:22.5778 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ViQLrKTYEZKT/gBANHX8PDDEQUVA2MvrdQCwllgtpKWZQPGUK2A7PUYoiNcMt0CfKFcYqZNPlDnUCeC8G5PfngdKXgqxorJ6fYnWm7Rjm8o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1698 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_012226_120316_43553011 X-CRM114-Status: GOOD ( 17.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, lars@metafoo.de, ludovic.desroches@atmel.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Eugen.Hristev@microchip.com, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11.06.2022 20:47, Jonathan Cameron wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Thu, 9 Jun 2022 11:32:03 +0300 > Claudiu Beznea wrote: > >> Add 64 and 256 oversampling ratio support. It is necessary for temperature >> sensor. >> >> Signed-off-by: Claudiu Beznea >> --- >> drivers/iio/adc/at91-sama5d2_adc.c | 31 +++++++++++++++++++++++++++--- >> 1 file changed, 28 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c >> index 7321a4b519af..b52f1020feaf 100644 >> --- a/drivers/iio/adc/at91-sama5d2_adc.c >> +++ b/drivers/iio/adc/at91-sama5d2_adc.c >> @@ -142,6 +142,8 @@ struct at91_adc_reg_layout { >> #define AT91_SAMA5D2_EMR_OSR_1SAMPLES 0 >> #define AT91_SAMA5D2_EMR_OSR_4SAMPLES 1 >> #define AT91_SAMA5D2_EMR_OSR_16SAMPLES 2 >> +#define AT91_SAMA5D2_EMR_OSR_64SAMPLES 3 >> +#define AT91_SAMA5D2_EMR_OSR_256SAMPLES 4 >> >> /* Extended Mode Register - Averaging on single trigger event */ >> #define AT91_SAMA5D2_EMR_ASTE(V) ((V) << 20) >> @@ -308,6 +310,8 @@ static const struct at91_adc_reg_layout sama7g5_layout = { >> #define AT91_OSR_1SAMPLES 1 >> #define AT91_OSR_4SAMPLES 4 >> #define AT91_OSR_16SAMPLES 16 >> +#define AT91_OSR_64SAMPLES 64 >> +#define AT91_OSR_256SAMPLES 256 > > These defines seems a bit silly. Better to use the values inline than > to have these. > >> >> #define AT91_SAMA5D2_CHAN_SINGLE(index, num, addr) \ >> { \ >> @@ -640,7 +644,9 @@ static const struct at91_adc_platform sama7g5_platform = { >> .osr_mask = GENMASK(18, 16), >> .osr_vals = BIT(AT91_SAMA5D2_EMR_OSR_1SAMPLES) | >> BIT(AT91_SAMA5D2_EMR_OSR_4SAMPLES) | >> - BIT(AT91_SAMA5D2_EMR_OSR_16SAMPLES), >> + BIT(AT91_SAMA5D2_EMR_OSR_16SAMPLES) | >> + BIT(AT91_SAMA5D2_EMR_OSR_64SAMPLES) | >> + BIT(AT91_SAMA5D2_EMR_OSR_256SAMPLES), >> .chan_realbits = 16, >> }; >> >> @@ -774,6 +780,18 @@ static int at91_adc_config_emr(struct at91_adc_state *st, >> emr |= AT91_SAMA5D2_EMR_OSR(AT91_SAMA5D2_EMR_OSR_16SAMPLES, >> osr_mask); >> break; >> + case AT91_OSR_64SAMPLES: >> + if (!(osr_vals & BIT(AT91_SAMA5D2_EMR_OSR_64SAMPLES))) >> + return -EINVAL; >> + emr |= AT91_SAMA5D2_EMR_OSR(AT91_SAMA5D2_EMR_OSR_64SAMPLES, >> + osr_mask); >> + break; >> + case AT91_OSR_256SAMPLES: >> + if (!(osr_vals & BIT(AT91_SAMA5D2_EMR_OSR_256SAMPLES))) >> + return -EINVAL; >> + emr |= AT91_SAMA5D2_EMR_OSR(AT91_SAMA5D2_EMR_OSR_256SAMPLES, >> + osr_mask); >> + break; >> } >> >> at91_adc_writel(st, EMR, emr); >> @@ -791,6 +809,10 @@ static int at91_adc_adjust_val_osr(struct at91_adc_state *st, int *val) >> nbits = 13; >> else if (st->oversampling_ratio == AT91_OSR_16SAMPLES) >> nbits = 14; >> + else if (st->oversampling_ratio == AT91_OSR_64SAMPLES) >> + nbits = 15; >> + else if (st->oversampling_ratio == AT91_OSR_256SAMPLES) >> + nbits = 16; >> >> /* >> * We have nbits of real data and channel is registered as >> @@ -1679,7 +1701,8 @@ static int at91_adc_write_raw(struct iio_dev *indio_dev, >> switch (mask) { >> case IIO_CHAN_INFO_OVERSAMPLING_RATIO: >> if ((val != AT91_OSR_1SAMPLES) && (val != AT91_OSR_4SAMPLES) && >> - (val != AT91_OSR_16SAMPLES)) >> + (val != AT91_OSR_16SAMPLES) && (val != AT91_OSR_64SAMPLES) && >> + (val != AT91_OSR_256SAMPLES)) > Dropping this partial validity check and moving into a default in the switch statement > in config_emr() would be nice cleanup (I also replied to earlier patch based on what > is visible here). Sure, I'll check it. > >> return -EINVAL; >> /* if no change, optimize out */ >> mutex_lock(&st->lock); >> @@ -1897,7 +1920,9 @@ static IIO_CONST_ATTR(hwfifo_watermark_max, AT91_HWFIFO_MAX_SIZE_STR); >> static IIO_CONST_ATTR(oversampling_ratio_available, >> __stringify(AT91_OSR_1SAMPLES) " " >> __stringify(AT91_OSR_4SAMPLES) " " >> - __stringify(AT91_OSR_16SAMPLES)); >> + __stringify(AT91_OSR_16SAMPLES) " " >> + __stringify(AT91_OSR_64SAMPLES) " " >> + __stringify(AT91_OSR_256SAMPLES)); > > At somepoint it would be good to move this over to the read_avail() callback rather than > hand rolling it. We are slowly working through doing this for all the IIO drivers > but it will take a long time yet! I'll check this, too. > >> >> static struct attribute *at91_adc_attributes[] = { >> &iio_const_attr_oversampling_ratio_available.dev_attr.attr, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel