From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A040EE57D1 for ; Wed, 31 Dec 2025 04:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7VNylGeHty3hhb1+O1+8twZmND0tnjr8y4TdbwY0GSg=; b=YeZI5O1V0Wc3DgFNFsVeL1Yx4/ U8mGFbBXa/wmgtvs2nHdjl0xgRQyu7waitowvo5kJ/GCnqKf7xaBq9JynwnOE3GFURxQ4uKSetx+k KbGanf/D8JB6Tgfoca6p4arylx+hEcTlmBA9age2dq/B9UMyj5PcbQ+uKiTDkLkIz4ls8ci9TVDCf 1RBs7jgdzf0nCVWhwLSok38KHC9VquJ2MtPnagNFxKMbdFEBh2b/A2gnslsRjuSLjcUKOh95hRf9R 4JbIoljGb6nBJ66Gh+sSW23WnZe+GeBivYc3rvf+YgHYrMYAlo4UeWc80XxVhCtxA8Fh6E00AEQQZ fqPkCyIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vanON-00000005fJY-46OW; Wed, 31 Dec 2025 04:00:59 +0000 Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vanOK-00000005fIn-2jrh for linux-arm-kernel@lists.infradead.org; Wed, 31 Dec 2025 04:00:58 +0000 Received: by mail-ot1-x335.google.com with SMTP id 46e09a7af769-7c52fa75cd3so11921931a34.3 for ; Tue, 30 Dec 2025 20:00:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1767153655; x=1767758455; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7VNylGeHty3hhb1+O1+8twZmND0tnjr8y4TdbwY0GSg=; b=aiYD1rl92DlsqkfHGzwW1QIGnNnmb9nlolHDW8aHt+yQvxAqgrX1c0juMnx+0BrKUw PUjrMDUYbhUuGntw9U+RYntlqUI8xr2SA2qUxXNhW6THITf5C7G/u0+fnYRNPNR+q0PQ sJ19udJD/KUfAxfNO7/gUSzBqyX8TfYx6Fp9A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767153655; x=1767758455; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7VNylGeHty3hhb1+O1+8twZmND0tnjr8y4TdbwY0GSg=; b=wQ+ZufJPrElJgeHzZkDNFdsDHJ9yst6GYz2u245SIEqjff2bla9ZRRFwiAYsgl4z0P ZU737MXWXM/AvYU9A32gwNbvugb1v+A4s4on4pe/lDjfqLNIRqSP0mDB7TNmcmSG4adc da/WifPRN2DK8nYuqU1DS2jkuJbDZhT4yfdn0rRYUwPJHpWssIVJ2i2/caDbPkSxbUpO NF7D2eZkJjH6qL8DWcRxQQSO86X1SBulZ2eHtS54VU626mEC36NlG2FQaMN+ccFFPRrc W4qwoEXcK/njdTGlAiO5l5rGb+P2iM+/ZSOGobmo7greT4hL1o+qABgrCuJw6lhjIMm1 pCdA== X-Forwarded-Encrypted: i=1; AJvYcCXiTYRhuren/PWIcodUojOKkejVRZw3auBw5m25TQIMd3EE/tzBLyFRb6ZpwTx9vX/04YjyK4UVvG2x0xXGTQbl@lists.infradead.org X-Gm-Message-State: AOJu0YyHuU6UXYRnBPGJyjIEN9zl5JucQ709Eb5NIh1kkHifW3C2ha9l WiFHMCKf++ggq2H5+X90SwFCH1OEvlCHYVGBizsMV1g/lZFU4KHmv2V9kHJsbAWng7E= X-Gm-Gg: AY/fxX7ckg2HwcwxevYOHgDYWjEZkDwfYL6UG/rgMynwg3nihkCYD877r26VrA3Q6RU uM6nWsMmiDHc9hB2Yw/5kx93HKCpkVHoz/W7seOEGMilG4DzbN+yDS0Q6CRS5BsbdnI/eoyi5Ru BWtdzlhFq0YTSpDGcwZB7P/NwcWI7PomVWDlRDnqu16secwXL0Y5UzYX4cm6iCmk1vOdnTTgh0B +r8S4FZX35WhxW2olFBI0tRCKnduQqnMYGGkgHhCBl09x0VW3S/nH9I8ZN0JH12T5gakuf9FSKd G7g00d/irnXD5To2LdiWmysgAmkWhRuJ9Jfe7orPfI7SRq2wPdqbp7tAaAmCexQKNTogJ6TszLT v3ocmjPMAFeGMY/ROiBwB8mvBaIXfTAF9YtjYwW3U9TUjbNOSf5LUIUsC2NPR+v14Y8G+jxRwWb GCp7ysglu0YhjaHEGqG4L8xVA= X-Google-Smtp-Source: AGHT+IF9F/siqhgAslvMOnVu4nsfQJ2/g/8vSzR2SppngNQxxoARtodDwAouloJqhdkdH2KDxgw/hQ== X-Received: by 2002:a05:6830:6688:b0:7c7:5974:3563 with SMTP id 46e09a7af769-7cc66a15846mr16285625a34.29.1767153655626; Tue, 30 Dec 2025 20:00:55 -0800 (PST) Received: from [192.168.1.14] ([38.175.187.108]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7cc66727e37sm24112013a34.1.2025.12.30.20.00.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Dec 2025 20:00:54 -0800 (PST) Message-ID: Date: Tue, 30 Dec 2025 21:00:53 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Linux 6.19-rc1 mediatek mt7921e broke badly To: Eric Biggers , Linus Torvalds Cc: Matthew Schwartz , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Mikhail Gavrilov , Mario Limonciello , Johannes Berg , quan.zhou@mediatek.com, Felix Fietkau , lorenzo@kernel.org, ryder.lee@mediatek.com, linux-wireless@vger.kernel.org, Linux Kernel Mailing List , Linux ARM , linux-mediatek@lists.infradead.org, shuah , Shuah Khan References: <756e3f65-b2f2-4da3-985a-17754a7a872d@t-8ch.de> <6fc04df5-b753-4b2d-b978-0e59a7f48ff7@linux.dev> <20251231015712.GA2299@sol> Content-Language: en-US From: Shuah Khan In-Reply-To: <20251231015712.GA2299@sol> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251230_200056_699685_3488D39D X-CRM114-Status: GOOD ( 16.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/30/25 18:57, Eric Biggers wrote: > On Tue, Dec 30, 2025 at 05:27:13PM -0800, Linus Torvalds wrote: >> On Tue, 30 Dec 2025 at 15:57, Shuah Khan wrote: >>> >>> I would recommend reverting f804a5895eba instead of trying >>> fix it. Then find a better way to eliminate extra newline that >>> shows up in dmesg when firmware build date happens to have >>> a newline. >> >> Yeah. Let's revert it. >> >> And the way to fix the extra newline is trivial: just remove it from >> the "dev_info()" format string. >> >> Our kernel printing logic will add a newline for the next line anyway >> if it is missing (unless somebody explicitly uses PR_CONT). >> >> Can whoever saw the problem confirm that just a revert and a "remove >> \n from that dev_info()" fixes the output for them? > > That works for me. The revert by itself makes the FORTIFY_SOURCE crash > go away and reintroduces a blank line in the log. Removing the \n from > the string passed to dev_info as well makes the blank line go away. > I just sent the revert. I will try removing \n from dev_info() later on tomorrow. My quick trial still showed extra line which didn't make sense to me. More trials have to wait for tomorrow. thanks, -- Shuah