From: "Rafał Miłecki" <zajec5@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
Guenter Roeck <linux@roeck-us.net>
Cc: "Wim Van Sebroeck" <wim@linux-watchdog.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] watchdog: bcm63xx_wdt: fix fallthrough warning
Date: Wed, 27 Oct 2021 22:40:07 +0200 [thread overview]
Message-ID: <fe1b90d7-4898-694b-02ae-97baa3377206@gmail.com> (raw)
In-Reply-To: <7bb51f0f-6ba1-d91a-6e1c-7c7c4f5f3cbc@gmail.com>
On 27.10.2021 19:39, Florian Fainelli wrote:
> On 10/27/21 10:31 AM, Guenter Roeck wrote:
>> On Wed, Oct 27, 2021 at 02:31:35PM +0200, Rafał Miłecki wrote:
>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>
>>> This fixes:
>>> drivers/watchdog/bcm63xx_wdt.c: In function 'bcm63xx_wdt_ioctl':
>>> drivers/watchdog/bcm63xx_wdt.c:208:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>>
>>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>>
>> [reluctantly]
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>
>> ... because the driver should really be converted to use the watchdog subsystem,
>> by someone with the necessary hardware to test it.
>
> The driver should ideally be removed and we should use bcm7038_wdt.c
> moving forward. Rafal, is this something you can try on 4908?
I wasn't sure if I should proceed with bcm63xx_wdt.c or bcm7038_wdt.c so
I chose 63xx. Possibly a bad decision, I'm not sure.
I've already bcm63xx_wdt.c changes developed locally to support BCM4908.
I just need to add Documentation/dt-bindings/ part. I'll do that
tomorrow. Then you can let me know if that's acceptable or should I
refactor my changes.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-27 20:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 12:31 [PATCH] watchdog: bcm63xx_wdt: fix fallthrough warning Rafał Miłecki
2021-10-27 17:28 ` Florian Fainelli
2021-10-27 17:31 ` Guenter Roeck
2021-10-27 17:39 ` Florian Fainelli
2021-10-27 20:40 ` Rafał Miłecki [this message]
2021-10-27 22:13 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe1b90d7-4898-694b-02ae-97baa3377206@gmail.com \
--to=zajec5@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rafal@milecki.pl \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox