From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Javier Martinez Canillas <javierm@redhat.com>,
linux-kernel@vger.kernel.org
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Arnd Bergmann <arnd@arndb.de>,
Gregory CLEMENT <gregory.clement@bootlin.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Robert Elliott <elliott@hpe.com>,
Russell King <linux@armlinux.org.uk>,
Stefan Hansson <newbie13xd@gmail.com>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] ARM: exynos_defconfig: Enable zram as loadable modules
Date: Mon, 10 Apr 2023 18:47:12 +0200 [thread overview]
Message-ID: <fe1e74a2-e933-7cd9-f740-86d871076191@linaro.org> (raw)
In-Reply-To: <20230410124907.3293869-1-javierm@redhat.com>
On 10/04/2023 14:49, Javier Martinez Canillas wrote:
> Enable zram and dependencies as loadable modules. This allows to use the
> /dev/zramX virtual block devices as swap stored in system memory.
>
> Options were taken from commit 5c824e8be64d ("ARM: omap2plus_defconfig:
> Enable zram as loadable modules") that does the same for OMAP2+ platforms.
Neither this commit msg nor above omap commit explain why do we want it.
I know what zram is, I know its purpose, but the commit should answer
why we want it in defconfig.
To me it is not a matching defconfig at all:
1. Not a feature related to Exynos hardware,
2. Not needed for basic boot (systemd) or debug.
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> ---
>
> arch/arm/configs/exynos_defconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index b0f0baa3a6c4..2d5be864b4ca 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -37,6 +37,8 @@ CONFIG_MODULES=y
> CONFIG_MODULE_UNLOAD=y
> CONFIG_PARTITION_ADVANCED=y
> CONFIG_CMA=y
> +CONFIG_ZSMALLOC=m
> +CONFIG_PGTABLE_MAPPING=y
> CONFIG_NET=y
> CONFIG_PACKET=y
> CONFIG_UNIX=y
> @@ -84,6 +86,8 @@ CONFIG_NFC_SHDLC=y
> CONFIG_NFC_S3FWRN5_I2C=y
> CONFIG_DEVTMPFS=y
> CONFIG_DEVTMPFS_MOUNT=y
> +CONFIG_ZRAM=m
> +CONFIG_ZRAM_WRITEBACK=y
> CONFIG_BLK_DEV_LOOP=y
> CONFIG_BLK_DEV_CRYPTOLOOP=y
> CONFIG_BLK_DEV_RAM=y
>
> base-commit: e3adc46da349d4a4cda1c58d8186c5bce0b011fd
BTW, I think the base commit makes sense if it is "well-known commit". I
have latest master and next and commit is unknown.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-10 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 12:49 [PATCH] ARM: exynos_defconfig: Enable zram as loadable modules Javier Martinez Canillas
2023-04-10 16:47 ` Krzysztof Kozlowski [this message]
2023-04-10 17:51 ` Javier Martinez Canillas
2023-04-10 18:05 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe1e74a2-e933-7cd9-f740-86d871076191@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=elliott@hpe.com \
--cc=gregory.clement@bootlin.com \
--cc=javierm@redhat.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=newbie13xd@gmail.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox