From mboxrd@z Thu Jan 1 00:00:00 1970 From: timur@codeaurora.org (Timur Tabi) Date: Wed, 8 Nov 2017 11:12:09 -0600 Subject: [PATCH V2 2/3] dmaengine: qcom_hidma: add support for the new revision In-Reply-To: References: <1510158582-5343-1-git-send-email-okaya@codeaurora.org> <1510158582-5343-2-git-send-email-okaya@codeaurora.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/08/2017 10:58 AM, Sinan Kaya wrote: > Besides, C compiler also won't let me put two arrays together like this. > > struct my_struct { > struct some_struct array1[] > struct some_struct array2[] > } Why not this: const struct of_device_id hidma_msi_of_ids[] = { {.compatible = "qcom,hidma-1.1",}, {.compatible = "qcom,hidma-1.2",}, {}, }, static const struct acpi_device_id hidma_msi_acpi_ids[] = { {"QCOM8001", QDF2XXX_V1}, {"QCOM8002", QDF2XXX_V2}, {}, }; struct hidma_cap { const struct of_device_id *of; const struct acpi_device_id *acpi; }; static struct hidma_cap hidma_msi_cap = { hidma_msi_of_ids, hidma_msi_acpi_ids } Keep in mind that you also need to add MODULE_DEVICE_TABLE entries, which you can't really do with your approach. MODULE_DEVICE_TABLE(of, hidma_msi_of_ids); MODULE_DEVICE_TABLE(acpi, hidma_msi_acpi_ids); -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.