From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF9CFC55178 for ; Tue, 27 Oct 2020 13:56:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6194C2074B for ; Tue, 27 Oct 2020 13:56:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fBcXzPgY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QVNO1js2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6194C2074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=soriSPkKdOCMO9pDDGjQUFXRDVD3yDLX4wFMMAKgwpA=; b=fBcXzPgYd0nO8QGezhmDNSMHl eqmSeFXYF+QU21glLCiwPmx2BS3y9/J4TjOPw03zeJRH8ZmTmvdiHFIL30b8JkvQgQ+m0ms559TFT c+ZDZp50mkhLePlCFxX0sbIi8N5cK66oKuHILKvpDS6sBjX+rwmBVl9rsiDKRAli4nQku++tVic8b pBCOaLHoeqAPbe6LfA1dibxgDPQuBEp5yIuj/Jg481caYWCmTz1f5pMjIZvuyNwdI99NJUDkFKCqQ 6F+Bxzy639eKt7r2D7t4r/eCqyZ+mCeuv5GwvmILYpLBgnMYqdr8AWvI6ZqcojSjLRZmAaR3B5G9V ZegZi8Zbw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXPRH-0008U6-AO; Tue, 27 Oct 2020 13:55:03 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXPRD-0008TT-UO for linux-arm-kernel@lists.infradead.org; Tue, 27 Oct 2020 13:55:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603806899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ngy9t9+mZDVeXCahPtqT6RsIxpk8fj+GjpvS3FzPgDo=; b=QVNO1js2AGPl71Gb51EybzUSCWkMfF3FcEHgFjGsXXemF7QzC097zcRMEWW8PztHIzkYdc ZcBasi8QPKxN/j9fYq5CCxolk5IA8cYd15gdSUJiAo/+4d4uWhVh26qsuQOtRq6IWFmXsb ibmouXHnQ0Wc85aUTQmFWp7Af3kXoeU= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-593-4tPKrJjHPhyWz2KJcOPm5A-1; Tue, 27 Oct 2020 09:54:55 -0400 X-MC-Unique: 4tPKrJjHPhyWz2KJcOPm5A-1 Received: by mail-ed1-f72.google.com with SMTP id cb27so706532edb.11 for ; Tue, 27 Oct 2020 06:54:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ngy9t9+mZDVeXCahPtqT6RsIxpk8fj+GjpvS3FzPgDo=; b=ebTR+uCOIgfEShiC6cwkl13VZU/hi9HUX7+tr/s3pFPdeWoq1Zykub5uNKjA+60tFW AUumQoEeF+SKPBJDQqLRpIZZQHqxZkrAPleYfeSJGW7b4w9cWvN9oElqFzTJItnfKTMb AC4LUlnQ2nSl3uoa8k/YQo/SVcm7FsRZfXWVgyTffIdUE/SO1ov/QI//Qia2D2YWbuD0 /Q3MIXljOHIAnnd0Tkr0P86qQa1TgwkatvZsKZ81RV1rtEj3UqyX8SPBdN8+GkegfZyq kgNteHB/CVSYIs2jd1uI6c12uawY5p2Ny4RnCxGpXpLtP/gLt7qzmcp4iHCVvert3Ej+ S7Zg== X-Gm-Message-State: AOAM5316wAgQOKAouAI/Ynpou194X3Bw2/1CKQ3RL9pqfLSUa1MEZItG 9DQ1HiQDw0hwhRzUgl/V1Z4YxSsqMcU+zUKIG6bMOMKJYFUkZio07ohGoAuhQNR643sN0nulS4x TI8GBPLc2zz5afa8onooESH0ST+6gm00h+Gg= X-Received: by 2002:aa7:db07:: with SMTP id t7mr2433220eds.161.1603806894610; Tue, 27 Oct 2020 06:54:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxOWMHIOJb9ZQeE/rAhdam2sVdYl3IBDyDW1OMzfCBuJWAVzpMjkn8z+c+E6aL/ohN3DVq4Ew== X-Received: by 2002:aa7:db07:: with SMTP id t7mr2433197eds.161.1603806894417; Tue, 27 Oct 2020 06:54:54 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id v14sm1082691ejh.6.2020.10.27.06.54.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2020 06:54:53 -0700 (PDT) Subject: Re: [PATCH 2/7] ata: ahci: mvebu: Support A8k compatible To: sven.auhagen@voleatech.de, axboe@kernel.dk, robh+dt@kernel.org, tglx@linutronix.de, maz@kernel.org, gregory.clement@bootlin.com References: <20201007154554.66650-1-sven.auhagen@voleatech.de> <20201007154554.66650-3-sven.auhagen@voleatech.de> From: Hans de Goede Message-ID: Date: Tue, 27 Oct 2020 14:54:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201007154554.66650-3-sven.auhagen@voleatech.de> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201027_095500_049460_121836E6 X-CRM114-Status: GOOD ( 21.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, jason@lakedaemon.net, devicetree@vger.kernel.org, antoine.tenart@bootlin.com, viresh.kumar@linaro.org, rjw@rjwysocki.net, maxime.chevallier@bootlin.com, linux-ide@vger.kernel.org, thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 10/7/20 5:45 PM, sven.auhagen@voleatech.de wrote: > From: Miquel Raynal > > The ahci_platform.c driver was historically the one bound to the A8k > AHCI compatible string, but before adding a quirk for this compatible, > it is probably cleaner to put all Marvell EBU code in one place: the > ahci_mvebu.c driver. > > Signed-off-by: Miquel Raynal Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/ata/ahci_mvebu.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/ata/ahci_mvebu.c b/drivers/ata/ahci_mvebu.c > index 43bb2db59698..1cdc126882eb 100644 > --- a/drivers/ata/ahci_mvebu.c > +++ b/drivers/ata/ahci_mvebu.c > @@ -96,6 +96,11 @@ static int ahci_mvebu_armada_3700_config(struct ahci_host_priv *hpriv) > return 0; > } > > +static int ahci_mvebu_armada_8k_config(struct ahci_host_priv *hpriv) > +{ > + return 0; > +} > + > /** > * ahci_mvebu_stop_engine > * > @@ -230,6 +235,10 @@ static const struct ahci_mvebu_plat_data ahci_mvebu_armada_3700_plat_data = { > .host_flags = AHCI_HFLAG_SUSPEND_PHYS, > }; > > +static const struct ahci_mvebu_plat_data ahci_mvebu_armada_8k_plat_data = { > + .plat_config = ahci_mvebu_armada_8k_config, > +}; > + > static const struct of_device_id ahci_mvebu_of_match[] = { > { > .compatible = "marvell,armada-380-ahci", > @@ -239,6 +248,10 @@ static const struct of_device_id ahci_mvebu_of_match[] = { > .compatible = "marvell,armada-3700-ahci", > .data = &ahci_mvebu_armada_3700_plat_data, > }, > + { > + .compatible = "marvell,armada-8k-ahci", > + .data = &ahci_mvebu_armada_8k_plat_data, > + }, > { }, > }; > MODULE_DEVICE_TABLE(of, ahci_mvebu_of_match); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel