From: Andrew Lunn <andrew@lunn.ch>
To: MD Danish Anwar <danishanwar@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>, Nishanth Menon <nm@ti.com>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Tero Kristo <kristo@kernel.org>,
srk@ti.com, r-gunasekaran@ti.com
Subject: Re: [PATCH 3/3] arm64: dts: ti: k3-am642-evm: add overlay for icssg1 2nd port
Date: Thu, 7 Dec 2023 22:40:27 +0100 [thread overview]
Message-ID: <fe6499b3-fbda-4e2d-9b5e-92cc60d3a79c@lunn.ch> (raw)
In-Reply-To: <20231207081917.340167-4-danishanwar@ti.com>
> + mdio-mux-2 {
> + compatible = "mdio-mux-multiplexer";
> + mux-controls = <&mdio_mux>;
> + mdio-parent-bus = <&icssg1_mdio>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + mdio@0 {
> + reg = <0x0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + icssg1_phy2: ethernet-phy@3 {
> + reg = <3>;
> + tx-internal-delay-ps = <250>;
> + rx-internal-delay-ps = <2000>;
> + };
> + };
That looks odd. A mux generally has > 1 mdio bus. Otherwise its not
really a mux.
And this mux hardware exists all the time right? So it should be in
the .dtsi file.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-07 21:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 8:19 [PATCH 0/3] Add AM64x ICSSG Ethernet support MD Danish Anwar
2023-12-07 8:19 ` [PATCH 1/3] arm64: dts: ti: k3-am64-main: Add ICSSG IEP nodes MD Danish Anwar
2023-12-07 8:19 ` [PATCH 2/3] arm64: dts: ti: k3-am642-evm: add ICSSG1 Ethernet support MD Danish Anwar
2023-12-07 13:18 ` Nishanth Menon
2023-12-07 13:28 ` Anwar, Md Danish
2023-12-07 13:43 ` Nishanth Menon
2023-12-07 13:53 ` Anwar, Md Danish
2023-12-07 21:34 ` Andrew Lunn
2023-12-08 4:35 ` Anwar, Md Danish
2023-12-07 8:19 ` [PATCH 3/3] arm64: dts: ti: k3-am642-evm: add overlay for icssg1 2nd port MD Danish Anwar
2023-12-07 13:27 ` Nishanth Menon
2023-12-07 14:06 ` Anwar, Md Danish
2023-12-07 16:44 ` Andrew Davis
2023-12-08 4:34 ` Anwar, Md Danish
2023-12-07 21:40 ` Andrew Lunn [this message]
2023-12-08 7:28 ` Anwar, Md Danish
2023-12-11 10:00 ` MD Danish Anwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe6499b3-fbda-4e2d-9b5e-92cc60d3a79c@lunn.ch \
--to=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=r-gunasekaran@ti.com \
--cc=robh+dt@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox