From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56E10C433B4 for ; Thu, 1 Apr 2021 17:50:20 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC9F160FF3 for ; Thu, 1 Apr 2021 17:50:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC9F160FF3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FgypX/2J5pwAA0M+4qfKNPfE3n8WKbmIUix3+0T18qY=; b=fV0hEXPGvfnNCQkDu4PxmdMLo HDzR2pRJVSkBBPDGqAncri6IVLP5l1Fwp1NOCrVoMl0aFxg5Z0XsXFKThwX0d1P8msWGq+iLX16ht 0Z/6go4Mfs5qpuUAGT8OOYEmtTgO7HrWHS/9tn+EFcurD8s/dYGgYXZzTenWAD63oynjLEN3l2tmK taOojwVT8dQQqXE5OR9LiTrwji1AqvaTBnFijRWP0OMslLqJ2MkfWBWtvgjicg/exeuy9KdAMWG1v A2B9LnQrSSgsnqraYcWxW6Q9NPbQfuKTQ6fF2mUX40xRgLUJ8omUJdh27JwetQ7BFfvX/h4C8ZP73 /yrJ+hSSA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lS1RK-00AaWP-Em; Thu, 01 Apr 2021 17:49:06 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lS1RF-00AaVc-Ft for linux-arm-kernel@lists.infradead.org; Thu, 01 Apr 2021 17:49:03 +0000 Received: from [192.168.254.32] (unknown [47.187.194.202]) by linux.microsoft.com (Postfix) with ESMTPSA id CF79820B5680; Thu, 1 Apr 2021 10:48:59 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CF79820B5680 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1617299340; bh=pggj6kgf28ysJ63Y+IBa5Ll76tHdSXg4Vs39joWWGIQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=FRFn+2Soa89ADRECRu046rfoOhAI4l5N0maNljekL4EuSdDgPcYlW4u6tcKX8qgzr 0xnhWrIGYrSnkHvSLeASKvSx2Ea3A6EHyjgc72dU7WeccAcurQ81rHtRdg1dmRnuUL utvKxMt1Q3mwUcRRGOjFkIxcXDqlI49fRWzJ2F4E= Subject: Re: [RFC PATCH v1 3/4] arm64: Detect FTRACE cases that make the stack trace unreliable To: Mark Brown Cc: mark.rutland@arm.com, jpoimboe@redhat.com, jthierry@redhat.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org References: <77bd5edeea72d44533c769b1e8c0fea7a9d7eb3a> <20210330190955.13707-1-madvenka@linux.microsoft.com> <20210330190955.13707-4-madvenka@linux.microsoft.com> <20210401142759.GJ4758@sirena.org.uk> From: "Madhavan T. Venkataraman" Message-ID: Date: Thu, 1 Apr 2021 12:48:59 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210401142759.GJ4758@sirena.org.uk> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210401_184901_736691_2F0E5772 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/1/21 9:27 AM, Mark Brown wrote: > On Tue, Mar 30, 2021 at 02:09:54PM -0500, madvenka@linux.microsoft.com wrote: > >> + * FTRACE trampolines. >> + */ >> +#ifdef CONFIG_DYNAMIC_FTRACE_WITH_REGS >> + { (unsigned long) &ftrace_graph_call, 0 }, >> +#ifdef CONFIG_FUNCTION_GRAPH_TRACER >> + { (unsigned long) ftrace_graph_caller, 0 }, >> + { (unsigned long) return_to_handler, 0 }, >> +#endif >> +#endif > > It's weird that we take the address of ftrace_graph_call but not the > other functions - we should be consistent or explain why. It'd probably > also look nicer to not nest the ifdefs, the dependencies in Kconfig will > ensure we only get things when we should. > Sorry. I forgot to respond to the nested ifdef comment. I will fix that. Thanks! Madhavan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel