From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0A75C31E46 for ; Wed, 12 Jun 2019 12:33:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8811E20874 for ; Wed, 12 Jun 2019 12:33:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JLWgNL32" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8811E20874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UOnUKGn2t8VeZxZNpRJc2mJSEPMlOHgoZc6EGwMeKF8=; b=JLWgNL32k6PiBkTtZytCNDfPo hsgeXnrnGlJz8NtJWVXTrlOzHX4TlftloAq5rtqONOD3Gg61/J9Fb9URg5pVsLh77ypAvaurYPeBA ioz0SxxztmbvYUz14CMG+2KiSGT2xslaQJN9JAxlqWzOJPcuwRfe19zJyCWhrn0f4PHfQrKCS+PCw 0kj+Xgr5Aou2w5s8lnYJ/XTTskRdj8PblIeu9zj0Tx9oPgky3D66WGq1OTQXXboj4r8teUeikMUBN Xilh8QpqvHWIWat45d0TPoDlbIldKf013HIdR1MYcRb+mtBglatZ+RAXXeH8h30g1zvL7qrj2oCuO nbwOlhxnw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hb2RK-0003Z8-OP; Wed, 12 Jun 2019 12:33:18 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hb2RB-0003Qj-Uo for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2019 12:33:14 +0000 Received: by mail-ed1-f68.google.com with SMTP id w13so25530135eds.4 for ; Wed, 12 Jun 2019 05:33:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/9+BscyBSG8LtxRtL3bsLVsuCvjxfppgNJUSn3pi0BA=; b=ZbTuEAocErNhBEI3gAJT6Yfw5pAaBOeYsjX1LWdVVNs1c6NEx6hNcX0C1PizrvqFOY rY2+Srn6n8qGrCrzVU7iY3SKRP0otoNLYt8KCTrN8cLrxG0MQJXjwEEovmYjdBHEDTlh VO9FNlGS3N9ETk8MR4FiVMGUllPcBeHgM4dIuzzJaLtGq8w1c50HzEChHTZcFy0TRXya jyPBxp9n49LoxA8Vr71f8Cj45H1ii0qLlH7LNzUWslyf9nUklDGH1RuGFzhXpa6JnQLP qskx0qpqpoYkd6b/yA1Moh+n33iZOqmneXTak/P+41rCFy4anYDkDqrkrfENpLDM9oBT 9z2g== X-Gm-Message-State: APjAAAV+bNSdD5iJEF2J8nwfYtmWaxM19xfptgpv+zlYgyHMX0uVQlZg 0WzQ07n8I+UPtysAXC7+nDo1Xg== X-Google-Smtp-Source: APXvYqwH+EIsTHqwWN3f9HxFMK99PgTbuqj4T1Pw/EUS2brCmPFSeeUdToS6/AutI5NLtTDk9/MaKw== X-Received: by 2002:a50:b561:: with SMTP id z30mr32633599edd.87.1560342787019; Wed, 12 Jun 2019 05:33:07 -0700 (PDT) Received: from shalem.localdomain (84-106-84-65.cable.dynamic.v4.ziggo.nl. [84.106.84.65]) by smtp.gmail.com with ESMTPSA id c21sm2784931ejk.79.2019.06.12.05.33.05 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2019 05:33:06 -0700 (PDT) Subject: Re: [PATCH 4/5] drm/connector: Split out orientation quirk detection To: "dbasehore ." References: <20190611040350.90064-1-dbasehore@chromium.org> <20190611040350.90064-5-dbasehore@chromium.org> <87zhmoy270.fsf@intel.com> <01636500-0be5-acf8-5f93-a57383bf4b20@redhat.com> From: Hans de Goede Message-ID: Date: Wed, 12 Jun 2019 14:33:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190612_053310_045925_DC0C53E4 X-CRM114-Status: GOOD ( 25.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Maxime Ripard , Joonas Lahtinen , dri-devel , Thierry Reding , Sam Ravnborg , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , David Airlie , CK Hu , devicetree@vger.kernel.org, Daniel Vetter , Intel Graphics , Maarten Lankhorst , Jani Nikula , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Rodrigo Vivi , Matthias Brugger , Sean Paul , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel , Philipp Zabel Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 12-06-19 02:16, dbasehore . wrote: > On Tue, Jun 11, 2019 at 1:54 AM Hans de Goede wrote: >> >> Hi, >> >> On 11-06-19 10:08, Jani Nikula wrote: >>> On Mon, 10 Jun 2019, Derek Basehore wrote: >>>> This removes the orientation quirk detection from the code to add >>>> an orientation property to a panel. This is used only for legacy x86 >>>> systems, yet we'd like to start using this on devicetree systems where >>>> quirk detection like this is not needed. >>> >>> Not needed, but no harm done either, right? >>> >>> I guess I'll defer judgement on this to Hans and Ville (Cc'd). >> >> Hmm, I'm not big fan of this change. It adds code duplication and as >> other models with the same issue using a different driver or panel-type >> show up we will get more code duplication. >> >> Also I'm not convinced that devicetree based platforms will not need >> this. The whole devicetree as an ABI thing, which means that all >> devicetree bindings need to be set in stone before things are merged >> into the mainline, is done solely so that we can get vendors to ship >> hardware with the dtb files included in the firmware. > > We've posted fixes to the devicetree well after the initial merge into > mainline before, so I don't see what you mean about the bindings being > set in stone. That was just me repeating the official party line about devicetree. > I also don't really see the point. The devicetree is in > the kernel. If there's some setting in the devicetree that we want to > change, it's effectively the same to make the change in the devicetree > versus some quirk setting. The only difference seems to be that making > the change in the devicetree is cleaner. I agree with you that devicetree in practice is easy to update after shipping. But at least whenever I tried to get new bindings reviewed I was always told that I was not allowed to count on that. >> I'm 100% sure that there is e.g. ARM hardware out there which uses >> non upright mounted LCD panels (I used to have a few Allwinner >> tablets which did this). And given my experience with the quality >> of firmware bundled tables like ACPI tables I'm quite sure that >> if we ever move to firmware included dtb files that we will need >> quirks for those too. > > Is there a timeline to start using firmware bundled tables? Nope, as I said "if we ever move to ...". > Since the > quirk code only uses DMI, it will need to be changed anyways for > firmware bundled devicetree files anyways. > > We could consolidate the duplicated code into another function that > calls drm_get_panel_orientation_quirks too. The only reason it's like > it is is because I initially only had the call to > drm_get_panel_orientation_quirk once in the code. Yes if you can add a new helper for the current callers, then I'm fine with dropping the quirk handling from drm_connector_init_panel_orientation_property() Regards, Hans _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel