From: Krzysztof Kozlowski <krzk@kernel.org>
To: Daniel Palmer <daniel@0x0f.com>
Cc: krzk+dt@kernel.org, romain.perier@gmail.com, robh@kernel.org,
conor+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] arm: dts: mstar: infinity: Correct opp table name
Date: Fri, 2 Jan 2026 11:03:39 +0100 [thread overview]
Message-ID: <fe88cb4d-19f9-413a-8cd1-aa75b3b421bc@kernel.org> (raw)
In-Reply-To: <CAFr9PXkn=ZMd6v=yX_KbfynKq7quBKUnCBDJBaU0LyYYMbKEXA@mail.gmail.com>
On 31/12/2025 11:17, Daniel Palmer wrote:
> Hi Krzysztof,
>
> On Wed, 31 Dec 2025 at 18:48, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> I meant, two commits should be rather squashed. If you intend to rename
>> the nodes, fix all names to be generic, not only some.
>
> There are 3 commits that correct node names:
> arm: dts: mstar: breadbee: Correct regulator names
> arm: dts: mstar: breadbee: Correct LED names
> arm: dts: mstar: infinity: Correct opp table name
>
> The top two are in the same dts board file, the bottom one is in a
> different dtsi file for a chip family.
You are right, so it's fine.
> Should I squash all of them into one commit, squash the top two for
> the same board into one commit?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-02 10:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-31 2:54 [PATCH 0/5] Sigmastar DT warnings fixing part 1 Daniel Palmer
2025-12-31 2:54 ` [PATCH 1/5] arm: dts: mstar: breadbee: Correct regulator names Daniel Palmer
2025-12-31 9:49 ` Krzysztof Kozlowski
2025-12-31 2:54 ` [PATCH 2/5] arm: dts: mstar: breadbee: Correct LED names Daniel Palmer
2025-12-31 2:55 ` [PATCH 3/5] arm: dts: mstar: infinity: Correct opp table name Daniel Palmer
2025-12-31 7:47 ` Krzysztof Kozlowski
2025-12-31 8:35 ` Daniel Palmer
2025-12-31 9:48 ` Krzysztof Kozlowski
2025-12-31 10:17 ` Daniel Palmer
2026-01-02 10:03 ` Krzysztof Kozlowski [this message]
2025-12-31 2:55 ` [PATCH 4/5] arm: dts: mstar: v7: Move the reboot node Daniel Palmer
2025-12-31 2:55 ` [PATCH 5/5] arm: dts: mstar: v7: Add sizes and ranges to sram Daniel Palmer
2026-01-02 14:43 ` [PATCH 0/5] Sigmastar DT warnings fixing part 1 Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe88cb4d-19f9-413a-8cd1-aa75b3b421bc@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).