[PATCH 0/5] Sigmastar DT warnings fixing part 1.

[PATCH 0/5] Sigmastar DT warnings fixing part 1.

[Daniel Palmer]

I saw a slide at LPC that had sigmastar in the "hall of shame"
for DT warnings. I finally got some time to look at this so
I have fixed the ones that are obvious and quick to fix.

I'll fix the rest but they might take a bit longer i.e. one
of them is about the register shift for the UART registers,
that'll need the binding to be updated I think?

FWIW this platform isn't dead and I have been rebasing all
of the out of tree stuff that make it useful (Audio support,
display, hardware video decoding etc) but its basically stuck
on rewriting the clock driver so that it is mainline-able.

Some other people have taken the limited support in mainline
and my out of tree stuff and made it run on old MStar MIPS
machines too..

Daniel Palmer (5):
  arm: dts: mstar: breadbee: Correct regulator names
  arm: dts: mstar: breadbee: Correct LED names
  arm: dts: mstar: infinity: Correct opp table name
  arm: dts: mstar: v7: Move the reboot node
  arm: dts: mstar: v7: Add sizes and ranges to sram

 .../mstar-infinity-breadbee-common.dtsi         | 10 +++++-----
 arch/arm/boot/dts/sigmastar/mstar-infinity.dtsi |  2 +-
 arch/arm/boot/dts/sigmastar/mstar-v7.dtsi       | 17 ++++++++++-------
 3 files changed, 16 insertions(+), 13 deletions(-)

-- 
2.51.0

[PATCH 1/5] arm: dts: mstar: breadbee: Correct regulator names

[Daniel Palmer]

The regulator names had a "@<n>" in them so the dt validation
stuff wanted a reg property. Fix the names to match what the regulator
is for and remove the "@<n>" bit.

Signed-off-by: Daniel Palmer <daniel@0x0f.com>
---
 .../boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi b/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi
index 507ff2fba837..aedea0fbbce6 100644
--- a/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi
+++ b/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi
@@ -7,7 +7,7 @@
 #include <dt-bindings/gpio/gpio.h>
 
 / {
-	vcc_core: fixedregulator@0 {
+	vcc_core: reg-core {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc_core";
 		regulator-min-microvolt = <1000000>;
@@ -15,7 +15,7 @@ vcc_core: fixedregulator@0 {
 		regulator-boot-on;
 	};
 
-	vcc_dram: fixedregulator@1 {
+	vcc_dram: reg-dram {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc_dram";
 		regulator-min-microvolt = <1800000>;
@@ -23,7 +23,7 @@ vcc_dram: fixedregulator@1 {
 		regulator-boot-on;
 	};
 
-	vcc_io: fixedregulator@2 {
+	vcc_io: reg-io {
 		compatible = "regulator-fixed";
 		regulator-name = "vcc_io";
 		regulator-min-microvolt = <3300000>;
-- 
2.51.0

[PATCH 2/5] arm: dts: mstar: breadbee: Correct LED names

[Daniel Palmer]

The dt validation stuff whats the names of the leds to match
a regexp.

Prefix the names with "led-" to make the validation happy.

Signed-off-by: Daniel Palmer <daniel@0x0f.com>
---
 .../boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi b/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi
index aedea0fbbce6..3826436a80d0 100644
--- a/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi
+++ b/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi
@@ -33,11 +33,11 @@ vcc_io: reg-io {
 
 	leds {
 		compatible = "gpio-leds";
-		red {
+		led-red {
 			gpios = <&gpio MSC313_GPIO_SR_IO16 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "activity";
 		};
-		yellow {
+		led-yellow {
 			gpios = <&gpio MSC313_GPIO_SR_IO17 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "heartbeat";
 		};
-- 
2.51.0

[PATCH 3/5] arm: dts: mstar: infinity: Correct opp table name

[Daniel Palmer]

The dt validation stuff expects the name of the opp table
to match a regexp and it currently doesn't.

Update the name to match the regexp.

Signed-off-by: Daniel Palmer <daniel@0x0f.com>
---
 arch/arm/boot/dts/sigmastar/mstar-infinity.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sigmastar/mstar-infinity.dtsi b/arch/arm/boot/dts/sigmastar/mstar-infinity.dtsi
index 441a917b88ba..b7d15a3288ad 100644
--- a/arch/arm/boot/dts/sigmastar/mstar-infinity.dtsi
+++ b/arch/arm/boot/dts/sigmastar/mstar-infinity.dtsi
@@ -9,7 +9,7 @@
 #include <dt-bindings/gpio/msc313-gpio.h>
 
 / {
-	cpu0_opp_table: opp_table0 {
+	cpu0_opp_table: opp-table-0 {
 		compatible = "operating-points-v2";
 		opp-shared;
 
-- 
2.51.0

[PATCH 4/5] arm: dts: mstar: v7: Move the reboot node

[Daniel Palmer]

The reboot node is currently inside of soc and that makes
the dt validation stuff complain that it wants some properties
that don't exist for reboot which is just some glue and not
a real device.

Move the node out of soc to fix the warnings.

Signed-off-by: Daniel Palmer <daniel@0x0f.com>
---
 arch/arm/boot/dts/sigmastar/mstar-v7.dtsi | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm/boot/dts/sigmastar/mstar-v7.dtsi b/arch/arm/boot/dts/sigmastar/mstar-v7.dtsi
index 3eeafd8c7121..db661e189eec 100644
--- a/arch/arm/boot/dts/sigmastar/mstar-v7.dtsi
+++ b/arch/arm/boot/dts/sigmastar/mstar-v7.dtsi
@@ -73,6 +73,13 @@ xtal_div2: xtal_div2 {
 		};
 	};
 
+	reboot {
+		compatible = "syscon-reboot";
+		regmap = <&pmsleep>;
+		offset = <0xb8>;
+		mask = <0x79>;
+	};
+
 	soc: soc {
 		compatible = "simple-bus";
 		#address-cells = <1>;
@@ -105,13 +112,6 @@ pmsleep: syscon@1c00 {
 				reg = <0x1c00 0x100>;
 			};
 
-			reboot {
-				compatible = "syscon-reboot";
-				regmap = <&pmsleep>;
-				offset = <0xb8>;
-				mask = <0x79>;
-			};
-
 			rtc@2400 {
 				compatible = "mstar,msc313-rtc";
 				reg = <0x2400 0x40>;
-- 
2.51.0

[PATCH 5/5] arm: dts: mstar: v7: Add sizes and ranges to sram

[Daniel Palmer]

Add some missing properties to the SRAM node to make the dt
validation happy.

Signed-off-by: Daniel Palmer <daniel@0x0f.com>
---
 arch/arm/boot/dts/sigmastar/mstar-v7.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/sigmastar/mstar-v7.dtsi b/arch/arm/boot/dts/sigmastar/mstar-v7.dtsi
index db661e189eec..e50e4000d1ee 100644
--- a/arch/arm/boot/dts/sigmastar/mstar-v7.dtsi
+++ b/arch/arm/boot/dts/sigmastar/mstar-v7.dtsi
@@ -187,6 +187,9 @@ pm_uart: serial@221000 {
 		imi: sram@a0000000 {
 			compatible = "mmio-sram";
 			reg = <0xa0000000 0x10000>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges = <0 0xa0000000 0x10000>;
 		};
 	};
 };
-- 
2.51.0

Re: [PATCH 3/5] arm: dts: mstar: infinity: Correct opp table name

[Krzysztof Kozlowski]

On 31/12/2025 03:55, Daniel Palmer wrote:
> The dt validation stuff expects the name of the opp table
> to match a regexp and it currently doesn't.
> 
> Update the name to match the regexp.
> 
> Signed-off-by: Daniel Palmer <daniel@0x0f.com>


These two should be squashed. Don't align node names with bindings per node.

Best regards,
Krzysztof

Re: [PATCH 3/5] arm: dts: mstar: infinity: Correct opp table name

[Daniel Palmer]

Hi Krzysztof,

On Wed, 31 Dec 2025 at 16:48, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> These two should be squashed. Don't align node names with bindings per node.

Sorry, I cannot parse what that means.

Looking at the example in
Documentation/devicetree/bindings/opp/opp-v2.yaml it looks like it
should just be called opp-table?

Cheers,

Daniel

Re: [PATCH 3/5] arm: dts: mstar: infinity: Correct opp table name

[Krzysztof Kozlowski]

On 31/12/2025 09:35, Daniel Palmer wrote:
> Hi Krzysztof,
> 
> On Wed, 31 Dec 2025 at 16:48, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> These two should be squashed. Don't align node names with bindings per node.
> 
> Sorry, I cannot parse what that means.

I meant, two commits should be rather squashed. If you intend to rename
the nodes, fix all names to be generic, not only some.

Best regards,
Krzysztof

Re: [PATCH 1/5] arm: dts: mstar: breadbee: Correct regulator names

[Krzysztof Kozlowski]

On 31/12/2025 03:54, Daniel Palmer wrote:
> The regulator names had a "@<n>" in them so the dt validation
> stuff wanted a reg property. Fix the names to match what the regulator
> is for and remove the "@<n>" bit.
> 
> Signed-off-by: Daniel Palmer <daniel@0x0f.com>
> ---
>  .../boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi  | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi b/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi
> index 507ff2fba837..aedea0fbbce6 100644
> --- a/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi
> +++ b/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi
> @@ -7,7 +7,7 @@
>  #include <dt-bindings/gpio/gpio.h>
>  
>  / {
> -	vcc_core: fixedregulator@0 {
> +	vcc_core: reg-core {


If renaming this then rather use one of the approved names, so either
"regulator-foo" or "regulator-XvY" (which matches current format
recommendation: 'regulator-[0-9]v[0-9]')

https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml

Best regards,
Krzysztof

Re: [PATCH 3/5] arm: dts: mstar: infinity: Correct opp table name

[Daniel Palmer]

Hi Krzysztof,

On Wed, 31 Dec 2025 at 18:48, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> I meant, two commits should be rather squashed. If you intend to rename
> the nodes, fix all names to be generic, not only some.

There are 3 commits that correct node names:
arm: dts: mstar: breadbee: Correct regulator names
arm: dts: mstar: breadbee: Correct LED names
arm: dts: mstar: infinity: Correct opp table name

The top two are in the same dts board file, the bottom one is in a
different dtsi file for a chip family.
Should I squash all of them into one commit, squash the top two for
the same board into one commit?

Cheers,

Daniel

Re: [PATCH 3/5] arm: dts: mstar: infinity: Correct opp table name

[Krzysztof Kozlowski]

On 31/12/2025 11:17, Daniel Palmer wrote:
> Hi Krzysztof,
> 
> On Wed, 31 Dec 2025 at 18:48, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> I meant, two commits should be rather squashed. If you intend to rename
>> the nodes, fix all names to be generic, not only some.
> 
> There are 3 commits that correct node names:
> arm: dts: mstar: breadbee: Correct regulator names
> arm: dts: mstar: breadbee: Correct LED names
> arm: dts: mstar: infinity: Correct opp table name
> 
> The top two are in the same dts board file, the bottom one is in a
> different dtsi file for a chip family.

You are right, so it's fine.
> Should I squash all of them into one commit, squash the top two for
> the same board into one commit?



Best regards,
Krzysztof

Re: [PATCH 0/5] Sigmastar DT warnings fixing part 1.

[Rob Herring]

On Wed, 31 Dec 2025 11:54:57 +0900, Daniel Palmer wrote:
> I saw a slide at LPC that had sigmastar in the "hall of shame"
> for DT warnings. I finally got some time to look at this so
> I have fixed the ones that are obvious and quick to fix.
> 
> I'll fix the rest but they might take a bit longer i.e. one
> of them is about the register shift for the UART registers,
> that'll need the binding to be updated I think?
> 
> FWIW this platform isn't dead and I have been rebasing all
> of the out of tree stuff that make it useful (Audio support,
> display, hardware video decoding etc) but its basically stuck
> on rewriting the clock driver so that it is mainline-able.
> 
> Some other people have taken the limited support in mainline
> and my out of tree stuff and made it run on old MStar MIPS
> machines too..
> 
> Daniel Palmer (5):
>   arm: dts: mstar: breadbee: Correct regulator names
>   arm: dts: mstar: breadbee: Correct LED names
>   arm: dts: mstar: infinity: Correct opp table name
>   arm: dts: mstar: v7: Move the reboot node
>   arm: dts: mstar: v7: Add sizes and ranges to sram
> 
>  .../mstar-infinity-breadbee-common.dtsi         | 10 +++++-----
>  arch/arm/boot/dts/sigmastar/mstar-infinity.dtsi |  2 +-
>  arch/arm/boot/dts/sigmastar/mstar-v7.dtsi       | 17 ++++++++++-------
>  3 files changed, 16 insertions(+), 13 deletions(-)
> 
> --
> 2.51.0
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/next-20251219 (exact match)
 Base: tags/next-20251219 (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/sigmastar/' for 20251231025502.1139168-1-daniel@0x0f.com:

arch/arm/boot/dts/sigmastar/mstar-infinity-msc313-breadbee_crust.dtb: leds (gpio-leds): led-red:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
	'activity' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'disk-read', 'disk-write', 'timer', 'pattern', 'audio-micmute', 'audio-mute', 'bluetooth-power', 'flash', 'kbd-capslock', 'mtd', 'nand-disk', 'netdev', 'none', 'rc-feedback', 'torch', 'usb-gadget', 'usb-host', 'usbport']
	'activity' does not match '^cpu[0-9]*$'
	'activity' does not match '^hci[0-9]+-power$'
	'activity' does not match '^mmc[0-9]+$'
	'activity' does not match '^phy[0-9]+tx$'
	from schema $id: http://devicetree.org/schemas/leds/leds-gpio.yaml
arch/arm/boot/dts/sigmastar/mstar-infinity3-msc313e-breadbee.dtb: leds (gpio-leds): led-red:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
	'activity' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'disk-read', 'disk-write', 'timer', 'pattern', 'audio-micmute', 'audio-mute', 'bluetooth-power', 'flash', 'kbd-capslock', 'mtd', 'nand-disk', 'netdev', 'none', 'rc-feedback', 'torch', 'usb-gadget', 'usb-host', 'usbport']
	'activity' does not match '^cpu[0-9]*$'
	'activity' does not match '^hci[0-9]+-power$'
	'activity' does not match '^mmc[0-9]+$'
	'activity' does not match '^phy[0-9]+tx$'
	from schema $id: http://devicetree.org/schemas/leds/leds-gpio.yaml