From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 458A2C4743D for ; Wed, 9 Jun 2021 03:09:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1441B6044F for ; Wed, 9 Jun 2021 03:09:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1441B6044F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=bW6T8JZU2FGxEycguvRSzMpeE+3wBzhnxnrw17PMAUU=; b=Ut4uZXh64nPt7J66yalLT9bm+b c5Jj6yEBaGtpcRgtgYzqohkB8/ysMVBmmhnYURpCNNSX2mYhrd0zPdOrZ2fjh0oyn94L39f3EQoo0 a1/N1KL7t8+1ro26U1SZj1biDp4djn9e6ap6AQ/CMmJAg6JkwEL+RkTxOoZuGIw56QEzT32yTZ/pP xi1VJ1VVpT686O3Y3sValRUxMVZ+4VALLJHkNQqKf00wFzf91OVyXV9hBX2gsGW0ZLRIEjOMhHHtb 6PfCkidMqWuQFM4l0zp8/i1B2031TYsZIROx+azcYaDXZAXJWkqz25U1pDE/rFqBBocfezF/5FBL+ sf4Xxvzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqoYj-00BX5S-4U; Wed, 09 Jun 2021 03:07:13 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqoYf-00BX58-5W for linux-arm-kernel@lists.infradead.org; Wed, 09 Jun 2021 03:07:10 +0000 Received: by mail-pg1-x536.google.com with SMTP id l1so18244794pgm.1 for ; Tue, 08 Jun 2021 20:07:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lhOA0nGrbjhRPVswA/mywNHLTKJKSXnKV9s3KRuT9b0=; b=eEmOANjFoGPTyGNLvXOsBxdb0fTnjiOwL3tROU9dOMmgDoC4VLjtO4w3cbWVHjP/hK wahkSdOQe6292A4Zn72SHDGSDQaqSZvso7WyW9u34Vwqv2L5DHF5rRaf9WSCKL+42j6D sTsko0XWv/xQ3arflI694ZIhCh54TuUiXuSReVeG4nsdfYAx1jK8QJf8lwJC1b0ugrvg +RP1QuPDBGV1ZSp/zvIsyRKloDrOWI3p2hrm/8AVOXa2zEeXEX82q0sCAb2jGwMuXF4g /2ReUEHOTSgMrDGy+jyIek6skxY2OZkHy6r6YEa3aAzhdybCiZjSqeTZNjJQ8d8nSY2S ot4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lhOA0nGrbjhRPVswA/mywNHLTKJKSXnKV9s3KRuT9b0=; b=C3PkR/mcojWQzR4vCEUya7qmp1SUqvGPwgPDEtrT77NSQJ/UvuePUTGv1TlkYxp0N0 xY/U9jMyUThthU9mgHNB5ma65oAM71t+i24oOodEq69+N6L1+O6wmePJorAPJkOoUwxB Y69Lvs0rOfWbVjXhDnXEnKX1P2dgEtRsE1cDhbvmo6AZsWXXRSQb5D66EleXby10UyiA cQAVHeqXCDVpZ6rR21t1Z/UTARZfthweM0gel8U5rPu/c91zMTRme6h5lSR/5o6WDl6L XmvE/GTJ9UpbA0bX5F6FpeqK5v5NuxXXcyTj1SI2z4SbDmsVOCTaaA2JHayBOLjpIj7N J5Iw== X-Gm-Message-State: AOAM532sxerMPkRV4N6HQYw01OU6g5ayS9VRh/JXAo0VutbyJmLU+l4D xiEwOWUejmBDipNNL4+XSDw= X-Google-Smtp-Source: ABdhPJwrg5MzG8QRD1JUtBgAuC+Cuk6MZaXdsiHLg5dbQBqrcdPsR4+dfoUF+OL919y4bNLZoHDv+A== X-Received: by 2002:a63:7e11:: with SMTP id z17mr1517467pgc.9.1623208028225; Tue, 08 Jun 2021 20:07:08 -0700 (PDT) Received: from [192.168.1.67] (99-44-17-11.lightspeed.irvnca.sbcglobal.net. [99.44.17.11]) by smtp.gmail.com with ESMTPSA id 78sm12733364pgg.73.2021.06.08.20.07.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jun 2021 20:07:07 -0700 (PDT) Subject: Re: [PATCH 2/2] mmc: sdhci-iproc: Add support for the legacy sdhci controller on the BCM7211 To: Ulf Hansson , Al Cooper Cc: Linux Kernel Mailing List , Adrian Hunter , BCM Kernel Feedback , DTML , Linux ARM , linux-mmc , Nicolas Saenz Julienne , Ray Jui , Rob Herring , Scott Branden References: <20210602192758.38735-1-alcooperx@gmail.com> <20210602192758.38735-2-alcooperx@gmail.com> From: Florian Fainelli Message-ID: Date: Tue, 8 Jun 2021 20:07:05 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210608_200709_263915_33E00824 X-CRM114-Status: GOOD ( 14.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/8/2021 5:40 AM, Ulf Hansson wrote: > On Wed, 2 Jun 2021 at 21:28, Al Cooper wrote: >> >> Add support for the legacy Arasan sdhci controller on the BCM7211 and >> related SoC's. This includes adding a .shutdown callback to increase >> the power savings during S5. > > Please split this into two separate changes. > > May I also ask about the ->shutdown() callback and in relation to S5. > What makes the ->shutdown callback only being invoked for S5? It is not only called for S5 (entered via poweroff on a prompt) but also during kexec or reboot. The poweroff path is via: kernel_power_off() -> kernel_shutdown_prepare() -> device_shutdown() -> .shutdown() For kexec or reboot we do not really care about power savings since we are about to load a new image anyway, however for S5/poweroff we do care about quiescing the eMMC controller in a way that its clocks and the eMMC device can be put into low power mode since we will stay in that mode for seconds/hours/days until someone presses a button on their remote (or other wake-up sources). -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel