From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 630FDC433EF for ; Mon, 14 Feb 2022 09:35:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/umKfBg2m4k/V4DuD5ILKNzieCWj30lmizfjed/yCtI=; b=MxcfixXayda3lN AV/fsql5s1n94LphLFRWw/RBXvB7HNwHz8G1mKtpkeRFceWPjGuwLBW0KD2+bMpztTckdVE/zVjIc 8cnKhSHPYX3sfdCWrg6qCulomqWOhsf3vqulptSUiD4tvUKFZZ/OjL0+aD3amUKv4u+WTjzPYoM3o WvxvkP1+1JzdkAFy5TUJiOGmsEy3/unB9hiXDQSXxMNsbKULYcNbQkgh5z3Sl5QyToIVtjYATBvU/ NsLtJz4WyOt18dox93TRv0YcHuqg9dkK2QxvxWiQhXTW38Xyt20n3rc8lsbUMuq9hxQbWFlBWxW06 aeRiWurS+Q1NGw4pNr0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJXjr-00EGF3-Vn; Mon, 14 Feb 2022 09:33:44 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJXSE-00ECEU-LG; Mon, 14 Feb 2022 09:15:32 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 0CB661F43418 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1644830124; bh=QcBW7EbcVCJj4WVhYdUseyVwWonS1t6LoaXt/1doffQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mFIx8aIDOuNZlJ27i12Qg5ovU1JWkvpMC/M1o0pKVoMQa3MY05a1XMv0AELQLDzXj EJb2TFW7JQ3c2vM+Y9RF86O8uK480YDzyuWew8qusIR8HQGN7cz7/A2j4LFmGjvmAb Oznh1THqcNKn/zBtxt55B4KaOKZIRIBOuUJXXNxyno2FiLgxyTTm/ZlnzaxUN7obDY B+PUP737ecZRBbOChMZOQBwm9Xf44Gzm+tR0F4mcE3ipovG/Ddm+elxqx/FryS5tZe LMK6S2pRy1gxTJ2FtNRS1k/02hjU+aP/AVTnrkzi5NSOwht3na3faBC56kiw2dV/z4 iSewDIdC3OvZw== Message-ID: Date: Mon, 14 Feb 2022 10:15:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v3] drm/mediatek: allow commands to be sent during video mode Content-Language: en-US To: Julien STEPHAN Cc: Mattijs Korpershoek , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , "open list:DRM DRIVERS FOR MEDIATEK" , "moderated list:DRM DRIVERS FOR MEDIATEK" , "moderated list:ARM/Mediatek SoC support" , open list References: <20220214084736.3374211-1-jstephan@baylibre.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220214084736.3374211-1-jstephan@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220214_011530_920368_54637581 X-CRM114-Status: GOOD ( 23.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 14/02/22 09:47, Julien STEPHAN ha scritto: > Mipi dsi panel drivers can use mipi_dsi_dcs_{set,get}_display_brightness() > to request backlight changes. > > This can be done during panel initialization (dsi is in command mode) > or afterwards (dsi is in Video Mode). > > When the DSI is in Video Mode, all commands are rejected. > > Detect current DSI mode in mtk_dsi_host_transfer() and switch modes > temporarily to allow commands to be sent. > > Signed-off-by: Julien STEPHAN > Signed-off-by: Mattijs Korpershoek > --- > Changes in v3: > - increase readability of code and use correct return variable (see > comment https://lore.kernel.org/linux-mediatek/4907bdc1-b4a6-e9ad-5cfa-266fc20c0bec@collabora.com/) > > Changes in v2: > - update commit message to be more descriptive > > > drivers/gpu/drm/mediatek/mtk_dsi.c | 33 ++++++++++++++++++++++-------- > 1 file changed, 24 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 5d90d2eb0019..7f1b2b7ed3fd 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -891,24 +891,33 @@ static ssize_t mtk_dsi_host_transfer(struct mipi_dsi_host *host, > u8 read_data[16]; > void *src_addr; > u8 irq_flag = CMD_DONE_INT_FLAG; > + u32 dsi_mode; > + int ret; > > - if (readl(dsi->regs + DSI_MODE_CTRL) & MODE) { > - DRM_ERROR("dsi engine is not command mode\n"); > - return -EINVAL; > + dsi_mode = readl(dsi->regs + DSI_MODE_CTRL); > + if (dsi_mode & MODE) { > + mtk_dsi_stop(dsi); > + ret = mtk_dsi_switch_to_cmd_mode(dsi, VM_DONE_INT_FLAG, 500); > + if (ret) > + goto restore_dsi_mode; > } > > if (MTK_DSI_HOST_IS_READ(msg->type)) > irq_flag |= LPRX_RD_RDY_INT_FLAG; > > - if (mtk_dsi_host_send_cmd(dsi, msg, irq_flag) < 0) > - return -ETIME; > + ret = mtk_dsi_host_send_cmd(dsi, msg, irq_flag); > + if (ret) > + goto restore_dsi_mode; > > - if (!MTK_DSI_HOST_IS_READ(msg->type)) > - return 0; > + if (!MTK_DSI_HOST_IS_READ(msg->type)) { > + recv_cnt = 0; > + goto restore_dsi_mode; > + } > > if (!msg->rx_buf) { > DRM_ERROR("dsi receive buffer size may be NULL\n"); > - return -EINVAL; > + ret = -EINVAL; > + goto restore_dsi_mode; > } > > for (i = 0; i < 16; i++) > @@ -933,7 +942,13 @@ static ssize_t mtk_dsi_host_transfer(struct mipi_dsi_host *host, > DRM_INFO("dsi get %d byte data from the panel address(0x%x)\n", > recv_cnt, *((u8 *)(msg->tx_buf))); > > - return recv_cnt; > +restore_dsi_mode: > + if (dsi_mode & MODE) { > + mtk_dsi_set_mode(dsi); > + mtk_dsi_start(dsi); > + } > + > + return ret < 0 ? ret: recv_cnt; Nitpick: you've missed a space ... ret : recv_cnt; With that fixed, Reviewed-by: AngeloGioacchino Del Regno > } > > static const struct mipi_dsi_host_ops mtk_dsi_ops = { > -- > 2.35.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel