From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7059C001B0 for ; Tue, 8 Aug 2023 18:32:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7Vv26yMwhaPTeCJNq+Wlf1JoNs4ZrBksPnatXaQJQYE=; b=yc2lHv2MQbvGBp ZhMIZgU7Y6upLLeiwgLKQ4kVkrt2uAXF0PAwDzvbhjOhoiSXUOBF4qsCsX1u7MLT9LZ7OscNyFCpt XqUSTGYdAzjDUANb/EMX3MnwS/uxggPyfat30slMeDNDwlRQcXsACufPU9BLN7GmJGzDKGFgZ16h7 ikcYP4nSGGeez0ALoYSzUoG/kX40zALGVpmMIziyin+9ydVRp+FeIm1W5axcZgSahrVjcm3742n/2 TQ1xh7/q6Mk4sKs00wvOHzT9m8UiX7+6OZtFjaebCl5JGZpUimrb7ycygZU4XkHz8u5lm2nfGL1BH BLgs47tz887qGOHfJ9dQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTRVC-003EQ7-2Z; Tue, 08 Aug 2023 18:32:18 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTRV9-003EPi-1J for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 18:32:17 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 378IW6xp062836; Tue, 8 Aug 2023 13:32:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691519526; bh=fX/sNFKyF1sSp1B1BKJh2rtMZvIKLQqD4XqA88vsY9U=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=YJaBGPe2w4HqYMMUmjND+adsatrfKGsYsQOR1riOE7Yy21KL725zdN0KbqQzQM2QL L5jtbtZ79upaz2dSKVFMYGRrA05Pohx/WgOo1zsHbpggmPXPsSUJGgOucvTsX8woCq /QgsVwS5Zq6s6OlQEa/uKCQAjBxOZdGNgzdvQe80= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 378IW6pu083697 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 8 Aug 2023 13:32:06 -0500 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 8 Aug 2023 13:32:04 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 8 Aug 2023 13:32:05 -0500 Received: from [10.24.69.34] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 378IW11r128141; Tue, 8 Aug 2023 13:32:01 -0500 Message-ID: Date: Wed, 9 Aug 2023 00:02:00 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 1/4] arm64: dts: ti: k3-j784s4-main: Add bootph-pre-ram property for SPL nodes Content-Language: en-US To: Nishanth Menon CC: Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , Udit Kumar , Hari Nagalla , Dasnavis Sabiya , Tom Rini References: <20230807185645.128751-1-a-nandan@ti.com> <20230807185645.128751-2-a-nandan@ti.com> <20230807190739.a33f5piskapfphxh@blatantly> From: Apurva Nandan In-Reply-To: <20230807190739.a33f5piskapfphxh@blatantly> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_113215_549066_6BB4AA88 X-CRM114-Status: GOOD ( 21.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Nishanth, On 08/08/23 00:37, Nishanth Menon wrote: > On 00:26-20230808, Apurva Nandan wrote: >> Add bootph-pre-ram property for all the nodes used in SPL stage, >> for syncing it later to u-boot j784s4 dts. >> >> Signed-off-by: Apurva Nandan >> --- > We need to rework this a little more: > > The approach taken in this series is enable pre-ram for everything. I am > not sure that is the right direction. These patches only enable bootph-pre-ram for the nodes, that already had bootph-pre-ram property in u-boot dts patches for j784s4. And these are selected after removing unnecessary nodes that had this property, so not added for everything. Are there a nodes which seem to have unnecessary bootph-pre-ram property according to you, need to remove? > https://github.com/devicetree-org/dt-schema/blob/e87ba2f515392c2a4694642063efb43023331ff6/dtschema/schemas/bootph.yaml#L70 > > patch #1: board generic changes: patch #1 > patch #2-: board specific change (per board) > > Make sure you use the correct property and document why this is needed > in the section added as well - esp for board generic changes introduced > into SoC.dtsi files. > I am little unclear about what nodes you refer with board generic vs board specific bootph-pre-ram. I have currently added bootph-pre-ram in board EVM dts files if the node is disabled in SoC dtsi and enabled in EVM dts (no point adding bootph-pre-ram in disabled node), or for pinmuxes, etc. What is the segregation you want in the patch, do you want some bootph-pre-ram to be moved from where they are? >> arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> index 2ea0adae6832..aaec569fe91a 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi >> @@ -6,6 +6,7 @@ >> */ >> >> &cbass_main { >> + bootph-pre-ram; > Is this better done where the node is defined? Okay, this I will fix. > >> msmc_ram: sram@70000000 { >> compatible = "mmio-sram"; >> reg = <0x00 0x70000000 0x00 0x800000>; >> @@ -670,6 +671,7 @@ main_sdhci1: mmc@4fb0000 { >> }; >> >> main_navss: bus@30000000 { >> + bootph-pre-ram; >> compatible = "simple-bus"; >> #address-cells = <2>; >> #size-cells = <2>; >> @@ -705,6 +707,7 @@ main_udmass_inta: msi-controller@33d00000 { >> }; >> >> secure_proxy_main: mailbox@32c00000 { >> + bootph-pre-ram; >> compatible = "ti,am654-secure-proxy"; >> #mbox-cells = <1>; >> reg-names = "target_data", "rt", "scfg"; >> -- >> 2.34.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel