From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72FF1C10F14 for ; Tue, 15 Oct 2019 12:20:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 272EE21925 for ; Tue, 15 Oct 2019 12:20:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S9X3ewhT"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=st.com header.i=@st.com header.b="wT13RZFH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 272EE21925 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1oqvaS60Nb3Zh9QTSy6Ep7TwYOMHA+cnvTa4s/4PEh0=; b=S9X3ewhT1eVCUZ J+kYIhrAUs2TacTXK9UbuzrD8he8HcwHnIqGad+sJVARX419Ce6iJH42pbYea0GguvXrSWQgRJ+Ii wGkigyA+E8WPiUisSk6Zt/JOJca0CcpwZjRTUgMqG+TLa9AFW8UwHghpGLevWpokHCXjOxraIPZZV Ydk8QHtmOBcr3mdt18+52kf2/T9pv/Sp4UpUr9QGoxiJtA1+/lts6skUSA3v9NJVnPwyNoyzUEb47 TTS/JfJ06FIfo5lMUDifyoO6ZyKrQgALqk2FSCrFlqyO+GjiH3mXQaii02dJvhjRuumY9YubyOblc FWtLSD3L7RFnJYLrhYFw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKLnz-0006oH-Ny; Tue, 15 Oct 2019 12:19:59 +0000 Received: from mx07-00178001.pphosted.com ([62.209.51.94]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKLnw-0006nb-5t for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2019 12:19:58 +0000 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x9FCFfur020735; Tue, 15 Oct 2019 14:19:50 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=GY+Z3B65hMOM3krVOFPaOVbaCL0W6CEn6gdWPrTcNGY=; b=wT13RZFHBJiJAsVW+eHMLBZ6iLAGOs6M+M4pgUjoeqkgh8IlFUkFEhN69cRJE5JGkSjK HmIBFufIHqjRhS7mpBUurahLVCtQ0gckdXJ4f3qdt8lhi+5N0v1EpzS3DjRadMIsBtKi urA2v46AjAzThSd1rgeWf8cfdSyGoBMyZnFMp1SOFwC6olJqR7N/cpUfzcXSte5uHtfo qR5PZMQd3Y5d04ZG7CWYE426JgN3q3b6Cee/2ngxzdRW8L/wgy5Z4wMAcztuQinSM2Zj ehL/rjetibrsYZoARIEHI3GWf74zMoAQeHpj6M04GUn7Au00aBcb/FzsSHeanYEcGDzx BQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 2vk4kx02w5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2019 14:19:50 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 0BC22100034; Tue, 15 Oct 2019 14:19:49 +0200 (CEST) Received: from Webmail-eu.st.com (Safex1hubcas24.st.com [10.75.90.94]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id E528E2C7936; Tue, 15 Oct 2019 14:19:49 +0200 (CEST) Received: from SAFEX1HUBCAS23.st.com (10.75.90.46) by Safex1hubcas24.st.com (10.75.90.94) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 15 Oct 2019 14:19:49 +0200 Received: from [10.48.0.192] (10.48.0.192) by webmail-ga.st.com (10.75.90.48) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 15 Oct 2019 14:19:49 +0200 Subject: Re: [PATCH] i2c: i2c-stm32f7: fix first byte to send in slave mode To: , References: <1569857281-19419-1-git-send-email-fabrice.gasnier@st.com> From: Fabrice Gasnier Message-ID: Date: Tue, 15 Oct 2019 14:19:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1569857281-19419-1-git-send-email-fabrice.gasnier@st.com> Content-Language: en-US X-Originating-IP: [10.48.0.192] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-15_05:2019-10-15,2019-10-15 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191015_051956_670780_9BA8F0DF X-CRM114-Status: GOOD ( 17.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.torgue@st.com, linux-kernel@vger.kernel.org, alain.volmat@st.com, linux-i2c@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/30/19 5:28 PM, Fabrice Gasnier wrote: > The slave-interface documentation [1] states "the bus driver should > transmit the first byte" upon I2C_SLAVE_READ_REQUESTED slave event: > - 'val': backend returns first byte to be sent > The driver currently ignores the 1st byte to send on this event. > > Fixes: 60d609f30de2 ("i2c: i2c-stm32f7: Add slave support") > > [1] https://www.kernel.org/doc/Documentation/i2c/slave-interface > > Signed-off-by: Fabrice Gasnier > --- Hi Wolfram, all, Gentle reminder on this patch. Thanks in advance ! Best Regards, Fabrice > drivers/i2c/busses/i2c-stm32f7.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c > index 266d1c2..0af9219 100644 > --- a/drivers/i2c/busses/i2c-stm32f7.c > +++ b/drivers/i2c/busses/i2c-stm32f7.c > @@ -1192,6 +1192,8 @@ static void stm32f7_i2c_slave_start(struct stm32f7_i2c_dev *i2c_dev) > STM32F7_I2C_CR1_TXIE; > stm32f7_i2c_set_bits(base + STM32F7_I2C_CR1, mask); > > + /* Write 1st data byte */ > + writel_relaxed(value, base + STM32F7_I2C_TXDR); > } else { > /* Notify i2c slave that new write transfer is starting */ > i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel