From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6969BC433FE for ; Fri, 21 Oct 2022 14:30:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TLzrZaTDgjXY8bMznil8R5btpcXPjBEHtkHI95j7+m4=; b=m2woxxCSJlcrrf OnVXoyZ7lPlip1u7v/ou4YgPCSLMlnBXlwn8Y1iFveTWZ4peeD+qXG+suEqLix9T33P4qkTza0/GC zCjRc296tETXXV1/kSq7nKQwn1m/KbzeAoljK4d6gqeIsHOSdI1+O1quZ7l6F/3l+FmZwwHAaeZnT R66fxTAF/8mFZNkhz3xRwZEQ/J+4RlXAY17iAn8tZhyDAeI9R+DJM/oPRAyWKBERKra/RiXPR7OHG gPlOSvrjBuJfDoO/ogYl8pk5MzVVjYOlVkLwMQKuDXyb1XlxHzBvFREryr3VW7gy/g7Ii2Ejqa0TH wyiaSEylJnGA/dSrgUMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olt1g-008TzU-VA; Fri, 21 Oct 2022 14:29:33 +0000 Received: from mail-qv1-xf2e.google.com ([2607:f8b0:4864:20::f2e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olt1e-008Tyz-A3 for linux-arm-kernel@lists.infradead.org; Fri, 21 Oct 2022 14:29:31 +0000 Received: by mail-qv1-xf2e.google.com with SMTP id h10so1908258qvq.7 for ; Fri, 21 Oct 2022 07:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zYhXx3JshQE/tuoCTDyLMashoUzdUo4pZcMqABkRo/M=; b=srn3zByRrvEg+Yl6vV3ME0TTHd3gSfIVYc5ZsM/gQ0sujv8ybmnhpgntT0M6CLvr4P m/RzgyED/1GoDGFqUlL3LFyZgVLHf2kd4IOVgVaSQg2DCWp2il/4PLd7C2F3kVEEX79N nYke2DF0zLQX9jgzJm6HL3QMEw9CewFh3MPpKG5pu1vWUhzC7NEtPzbnnicUmuCSq8SS x7GbK2dbutqxSpzqpV5t9smW102A9VVnGQ2MOuDQ8sAKz4MTKPex7eTSjWRJ0M6m/J2R 7qnWcwXvMysRYCIvyFb4tfcjoGcLX1dAAikcq1J3fnjo2oP1dyuMLUL09n97fmm9WWbv kU3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zYhXx3JshQE/tuoCTDyLMashoUzdUo4pZcMqABkRo/M=; b=jT7+eVzVCY5BtiJXzH4cXkJ1Rnt2gjVisQBp0I/RGg9UCvPdeZkcTBPynr3qDjNYy0 EYUl0M9ozmAbK3jzUj3YuWNQ1zCE/fCGhNAz+vXY7CPvlIWmYf6Mm4Nwb/ksD8e7R/hf erKdiMThlHWEwAsC+Ov+mz3IkY2gF0FcCCTES1enLMFtK76Cd9t3JmpqmGjvqEyhIi8g 9TEo7RyzUBZ05OVFqQoRjnVo2kHyOWIUOpYNHhKIzx8HfJRY1Zn17aGW07CPoOK5TbFL ZhUqeXntRcAwSEl5SeN1btS7Uh/12PttfdXinrQahbZMSkOGcMuwvb/Ma2o0tiWohPDu yz8Q== X-Gm-Message-State: ACrzQf3yHtFqubhQ6obPtQC4upQENJD9YPIBR+V73w+hDxEeJAGx4uMN 88K7xQNGmnMvH6czcdSvKDntgg== X-Google-Smtp-Source: AMsMyM5rkcPzQyOOQTpTuNGSU0Y+0j9z9JKh5icS5aTFsqI2snnDhTn3uBhW8R+XpbEZuMtOlufWhw== X-Received: by 2002:a0c:e449:0:b0:4b9:cfc3:b31a with SMTP id d9-20020a0ce449000000b004b9cfc3b31amr5680781qvm.35.1666362568431; Fri, 21 Oct 2022 07:29:28 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id x6-20020ac86b46000000b0035ba48c032asm7936410qts.25.2022.10.21.07.29.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Oct 2022 07:29:27 -0700 (PDT) Message-ID: Date: Fri, 21 Oct 2022 10:29:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH net-next v5 5/5] ARM: dts: qcom: ipq4019: Add description for the IPQESS Ethernet controller Content-Language: en-US To: Vladimir Oltean , Maxime Chevallier Cc: "davem@davemloft.net" , Rob Herring , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "thomas.petazzoni@bootlin.com" , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , "linux-arm-kernel@lists.infradead.org" , Luka Perkov , Robert Marko References: <20221021124556.100445-1-maxime.chevallier@bootlin.com> <20221021124556.100445-1-maxime.chevallier@bootlin.com> <20221021124556.100445-6-maxime.chevallier@bootlin.com> <20221021124556.100445-6-maxime.chevallier@bootlin.com> <20221021142057.zbc3xfny4hfdshei@skbuf> From: Krzysztof Kozlowski In-Reply-To: <20221021142057.zbc3xfny4hfdshei@skbuf> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221021_072930_383454_BD934B72 X-CRM114-Status: GOOD ( 14.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/10/2022 10:20, Vladimir Oltean wrote: > On Fri, Oct 21, 2022 at 02:45:56PM +0200, Maxime Chevallier wrote: >> @@ -591,6 +592,51 @@ wifi1: wifi@a800000 { >> status = "disabled"; >> }; >> >> + gmac: ethernet@c080000 { > > Pretty random ordering in this dts, you'd expect nodes are sorted by > address... Good point. > >> + compatible = "qcom,ipq4019-ess-edma"; >> + reg = <0xc080000 0x8000>; >> + resets = <&gcc ESS_RESET>; >> + reset-names = "ess"; >> + clocks = <&gcc GCC_ESS_CLK>; >> + clock-names = "ess"; >> + interrupts = , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + , >> + ; > > 32 interrupts, and no interrupt-names? :) There is no requirement for names, because entries must be ordered. Also Linux driver simply does not use them as it is slower to map, then just by index. For few other Qualcomm drivers we dropped the names as well. > >> + >> + status = "disabled"; >> + > > Could you drop these 2 blank lines? They aren't generally added between > properties. > ... and put status at the end. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel