From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44034C982DA for ; Fri, 18 Sep 2026 13:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:References:Content-Type: Content-Transfer-Encoding:In-Reply-To:From:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DmavpybYN0LBa3BilD0E1eX3g1b+G3rHrs0swG4JQog=; b=DTP+VMT57TFTRKgmD+V2I4TloU 3lUlLyuAm8P0q+u2NBzRaPS4oDISH78roLQA8wm3Mo0ziGmUiN4ffzelWSgDu/TkTXr0QhdO+ANMy v7mZvcozBj7KU2Yp3YHYDaNrXweijpCl8kw0l6Jrn6POB/XPZpsMDA8byMAZlvD5P1LsQrvTe84mW v1kTAO6lbVMSkuvN5KbnclNvYttDuqJ82JBLgWVrPOA/+3e/eoObubvKVk/Yqy344VSWnI+ZzvXbm Yu6giQsPFYYVAI7/Hri9CeapIUmzJ0+McDxL98ssEDq3t89ZExUtyCmdWp1eTC3hZ1dubkBF2cJhX FjyWxhjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7YlW-0000000EZPh-1y0J; Fri, 18 Sep 2026 13:36:34 +0000 Received: from mailout4.samsung.com ([203.254.224.34]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7YlQ-0000000EZOG-40jW for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2026 13:36:32 +0000 Received: from epcas5p2.samsung.com (unknown [182.195.41.40]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20260918133623epoutp04401cd311b2f7863705622bc9ba283653~WbcJ4qOr01229312293epoutp04H for ; Fri, 18 Sep 2026 13:36:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20260918133623epoutp04401cd311b2f7863705622bc9ba283653~WbcJ4qOr01229312293epoutp04H DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1789738583; bh=DmavpybYN0LBa3BilD0E1eX3g1b+G3rHrs0swG4JQog=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=hTRqG8yRJaM4O2m3d0ZvEYN9GaqgUYb84dNJdYaBvCCz0cVJh4FFo3d5BBkV6W31o Y88XAzzWNm9lSxFYewVJY2elCLojWV4jIy2BPdvCYXaU2MHNJ+rfYtgSnAqL2zj6i1 9BAuoI1wrYTjMaRVsBafTTwea5ZeGQc9AavCzXhQ= Received: from epsnrtp01.localdomain (unknown [182.195.42.153]) by epcas5p2.samsung.com (KnoxPortal) with ESMTPS id 20260918133623epcas5p2a0d653ee2ad5d6f01b37f0089059b8ba~WbcJGrl-n0578205782epcas5p2r; Fri, 18 Sep 2026 13:36:23 +0000 (GMT) Received: from epcas5p2.samsung.com (unknown [182.195.38.88]) by epsnrtp01.localdomain (Postfix) with ESMTP id 4hmYYf0mpMz6B9m5; Fri, 18 Sep 2026 13:36:22 +0000 (GMT) Received: from epsmtip2.samsung.com (unknown [182.195.34.31]) by epcas5p3.samsung.com (KnoxPortal) with ESMTPA id 20260918133621epcas5p38bcaad0af7a96839fea53c06c57d10f3~WbcHtMVS91576415764epcas5p3D; Fri, 18 Sep 2026 13:36:21 +0000 (GMT) Received: from [107.122.5.126] (unknown [107.122.5.126]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20260918133618epsmtip22c2e800475d63ed12ae7e900b295f553~WbcExuej70030600306epsmtip2F; Fri, 18 Sep 2026 13:36:18 +0000 (GMT) Message-ID: Date: Fri, 18 Sep 2026 19:06:17 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] dt-bindings: usb: Introduce samsung,snps-dwc3 To: Krzysztof Kozlowski Cc: peter.griffin@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, robh@kernel.org, conor+dt@kernel.org, Thinh.Nguyen@synopsys.com, mani@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jh0801.jung@samsung.com, h10.kim@samsung.com, dh10.jung@samsung.com, akash.m5@samsung.com, hongpooh.kim@samsung.com, eomji.oh@samsung.com, shijie.cai@samsung.com, muhammed.ali@samsung.com, thiagu.r@samsung.com Content-Language: en-US From: Selvarasu Ganesan In-Reply-To: <20260918-burgundy-marmoset-of-focus-c9b9a7@quoll> Content-Transfer-Encoding: 8bit X-CMS-MailID: 20260918133621epcas5p38bcaad0af7a96839fea53c06c57d10f3 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" CMS-TYPE: 105P cpgsPolicy: CPGSC10-542,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20260916122354epcas5p401fd6470d6cef75951af732b03aa5970 References: <20260916122229.2604003-1-selvarasu.g@samsung.com> <20260916122229.2604003-3-selvarasu.g@samsung.com> <20260918-burgundy-marmoset-of-focus-c9b9a7@quoll> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260918_063629_616109_5C963EBF X-CRM114-Status: GOOD ( 21.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/18/2026 3:24 PM, Krzysztof Kozlowski wrote: > On Wed, Sep 16, 2026 at 05:52:28PM +0530, Selvarasu Ganesan wrote: >> +maintainers: >> + - Krzysztof Kozlowski >> + - Selvarasu Ganesan >> + >> +description: >> + Describes the DWC3 USB controller block implemented on Samsung Exynos SoCs. >> + >> +select: >> + properties: >> + compatible: >> + contains: >> + const: samsung,snps-dwc3 >> + required: >> + - compatible > This select is not needed. > >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - samsung,exynos8855-dwc3 >> + - const: samsung,snps-dwc3 > And this fallback is not really accurate. Samsung does not have snps > device, because snps is a vendor. Anyway, generic fallbacks should go > away, drop, so you are left with samsung,exynos8855-dwc3 only. Hi Krzysztof, Thanks for your review comments. And We apologize for our repeated below explanation, but we wanted to ensure our intentions were clear for each point to avoid any misunderstanding. The original intent of the generic fallback was to support existing Exynos dwc3 bindings from a parent/child representation from (samsung,exynos-dwc3.yaml), and upcoming SoCs (Exynos 8865, 9955, and 9965) can use this flattened representation without requiring a unique compatible string for every project in the dwc3-generic-plat driver of_match_table. We referred to qcom,snps-dwc3 as a helpful reference for this approach. As seen in samsung,exynos-dwc3.yaml, our existing bindings already support multiple SoCs with diverse clock requirements within a single file. Similarly, we plan to use a single flattened Samsung binding to manage these diverse clock requirements. for different SoCs. Regarding the migration for current and future SoCs, would you prefer, Option A: A single flattened binding file using a common fallback compatible string (instead of samsung,snps-dwc3) to minimize of_match_table entries, and if/then constraints to handle diverse clock requirements. Option B: Separate binding files for each individual SoCs. Could you please let us know your preferred approach? Once confirmed, we will address your other review comments based on the selected approach. Thanks, Selva > Filename should be then samsung,exynos8855-dwc3.yaml. > >> + >> + reg: >> + maxItems: 1 >> + >> + power-domains: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + description: | >> + Several clocks are used, depending on the variant. Typical ones are: >> + - ref: Reference clock for SOF/ITP generation. >> + - bus: Bus (APB) clock for register access. > You have only one variant, no? Or you mean one SoC has different > variants? > >> + minItems: 1 >> + maxItems: 4 > Nope, you to list items. > >> + >> + clock-names: >> + minItems: 1 >> + maxItems: 4 >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - interrupts >> + >> +allOf: >> + - $ref: snps,dwc3-common.yaml# >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: samsung,exynos8855-dwc3 >> + then: >> + properties: >> + clocks: >> + minItems: 2 >> + maxItems: 2 > How can it be two if you have ONLY one device in the binding and that > device has between 1 and 4? > > This entire if is redundant, no? How many clocks do you actually have > there? > >> + clock-names: >> + items: >> + - const: ref >> + - const: bus >> + >> +unevaluatedProperties: false > Best regards, > Krzysztof