From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAFD4C636D7 for ; Wed, 15 Feb 2023 17:35:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U98i5SdefV940qeSSvbkS7XVq8G0sSq1v2HI3Kl/+A8=; b=sX/Qla1UmA0Bjr qs93BC8I2DqzPVwtXs/MUPXjl545SxvUwZlWjmxVven4EonWeLDkZ8a28ZT8MJWBAoPlv9xtMuFbO k1rXGnnNGf2/dDnTMigLaUet6KELK0ODYonVrQNIWyW0uhgU+UCgXM232wsh4SV9X16Gjoqe4LZGk wRC10pLDUVIxqLHIz6pszuB7+aK4zwymp+yvVG+17WmFHoKzlyxL4C0L4Np8J31N01/JZ83dHSCU/ ucRBJ/YFbRbgzM8PtGgqUXUOB9WdcUX3/jqMRN2hI4XNIiCV6WfCATcAdYOeLawvzNf064msdjxJS PfIi518b7AnNJHp82PbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSLfc-006hrl-Oz; Wed, 15 Feb 2023 17:34:17 +0000 Received: from mail-pj1-f47.google.com ([209.85.216.47]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pSLfZ-006hqJ-UM; Wed, 15 Feb 2023 17:34:15 +0000 Received: by mail-pj1-f47.google.com with SMTP id d8-20020a17090ad98800b002344fa17c8bso2535392pjv.5; Wed, 15 Feb 2023 09:34:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+7RJUFWr8yFaYxrhdiEcn2oKMmIGGDkUJslynTZp+P4=; b=McVrKIqel2sGMhljIOl+3uw230BLyiIFTJJn07gx7Cvn/+EqGQdswtsO4jPVKTSwha A0V4nHG6iNiSxE2OpgyIx0gaWU6sN7KhKWsWLW+ulZsaJXTJYDfHDN7tAQJ+S+vMvBY/ bTmHwvyd3FPErcrYOrk2kjLiOO+6YNF1drbU9yDPWDoivm7nmyM6n5ZRGpZKXuZOu2F1 W7Ua2BLEF7K5rE/59ybjHP0W63jg0Audz+CFF1E26JH+wH9QX8T5MAkwrGPNDfO2A7+t k9Vv8B8pv6JPxMVnXur+PsZOO/bGcNBI26JQU4oP83Mj1Biu5rzRsAT/p7xMP3c1yr5T /8UA== X-Gm-Message-State: AO0yUKVE+w2i/QIt6hwFV9GzXscKdt7Wo9SBvj9Nzaxy6XTwT9tzC0Of CrV1uWIHAv7RHed33ZyHbQA= X-Google-Smtp-Source: AK7set8KLjD29nGYSoiZcDjoRn7yIAWLQdb0khrbWiYyRjTHemXuKmGovegMmhMZOXZujT+FAiP9yg== X-Received: by 2002:a17:903:24f:b0:19a:b2ee:cf41 with SMTP id j15-20020a170903024f00b0019ab2eecf41mr3717131plh.59.1676482451156; Wed, 15 Feb 2023 09:34:11 -0800 (PST) Received: from ?IPV6:2620:15c:211:201:f2b7:9a62:c95d:fb83? ([2620:15c:211:201:f2b7:9a62:c95d:fb83]) by smtp.gmail.com with ESMTPSA id l5-20020a170902d34500b0019a6fe0f975sm5076016plk.267.2023.02.15.09.34.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Feb 2023 09:34:10 -0800 (PST) Message-ID: Date: Wed, 15 Feb 2023 09:34:07 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 1/2] scsi: ufs: core: Fix mcq tag calcualtion Content-Language: en-US To: Po-Wen Kao , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Matthias Brugger Cc: wsd_upstream@mediatek.com, peter.wang@mediatek.com, stanley.chu@mediatek.com, alice.chao@mediatek.com, chun-hung.wu@mediatek.com, cc.chou@mediatek.com, chaotian.jing@mediatek.com, jiajie.hao@mediatek.com, mason.zhang@mediatek.com, quic_asutoshd@quicinc.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230215123750.15785-1-powen.kao@mediatek.com> From: Bart Van Assche In-Reply-To: <20230215123750.15785-1-powen.kao@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230215_093414_012471_F8D624A5 X-CRM114-Status: GOOD ( 15.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/15/23 04:37, Po-Wen Kao wrote: > Transfer command descriptor is allocated in ufshcd_memory_alloc() > and referenced by transfer request descriptor with stride size > sizeof_utp_transfer_cmd_desc() > instead of > sizeof(struct utp_transfer_cmd_desc). > > Consequently, computing tag by address offset should also refer to the > same stride. > > Signed-off-by: Po-Wen Kao > --- > drivers/ufs/core/ufs-mcq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c > index 31df052fbc41..3a27fa4b0024 100644 > --- a/drivers/ufs/core/ufs-mcq.c > +++ b/drivers/ufs/core/ufs-mcq.c > @@ -265,7 +265,7 @@ static int ufshcd_mcq_get_tag(struct ufs_hba *hba, > addr = (le64_to_cpu(cqe->command_desc_base_addr) & CQE_UCD_BA) - > hba->ucdl_dma_addr; > > - return div_u64(addr, sizeof(struct utp_transfer_cmd_desc)); > + return div_u64(addr, sizeof_utp_transfer_cmd_desc(hba)); > } > > static void ufshcd_mcq_process_cqe(struct ufs_hba *hba, Reviewed-by: Bart Van Assche _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel