From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB881C433EF for ; Sun, 17 Apr 2022 17:47:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6dA6fOexw1pls+n6ElQXX3IXcD+s4QgYRLXftVMvJdw=; b=VFv31317IcrM07 Ca0LAI1r8Zy0+paKC3LTkdV9+9sJPVgQTqrsQlqYQf6d37uZzHl1Gza1Q4yNAKMGX6wHl85I6v3LK 0Xkq/zI2RyKplPv4vXnEt2vphSRlTHCAZ/+C5ImOaZWd/lZ2UZMwLoWhdAtidx/t+xR7UXBUwdb1T h9Dzroyjk8z4IJFtZwEg0PZL4+pqIH6FVeRIEqqe/i9CD6t/YTQbp73C+1B/oNyBsd2D0/Oo7a//b XEMRkYUv5TfBwFoFHcEnMQG5QsVH2tkhKs6K57N5H0MA6JgbqGyuhO++yvZKXp9HW6bSC+XAdf9Uv vXs2uvGY1gDkBcIqsGcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ng8yJ-00EkRx-Mc; Sun, 17 Apr 2022 17:46:03 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ng8yG-00EkRR-PO; Sun, 17 Apr 2022 17:46:02 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4ADF860A1A; Sun, 17 Apr 2022 17:45:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A800BC385A4; Sun, 17 Apr 2022 17:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650217558; bh=VkPYYsr5x5r7c4+l7JlyJX/Yd5KqB5sSgJ/zXSaOseo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JCo6nyxiiUA2mR2upbI050ANjFm/PZqRuitD4XzsWQ62DVGmvDyU9lmz9oKwjG2ly +AtIeoriiNAQqQf4tvR+REkdHneBKmWe2oGcqpqMMNEUsQeWyyz0CJVsWXZSwjqs07 zn8Tcc+5pf0ZBzF6vfRA6OszCn18n0NUFYI9C178YvncinZZ9tycRORNxmKUBwrI7A ZIuWzTgM1Sfjwn1SteNZhiLG1V1u1xOm2XWuIPyOWSUUye+zX6WvQVRoOTJFc+SdSb nWQQD+DR3SnSCSGB0nl2i4DWJKgIn/XQm2A99RYneN6pi6h/cJMXF5jhlv8FUT23Xb 6iE6LAzUqB6yQ== Message-ID: Date: Sun, 17 Apr 2022 19:45:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add Hardkernel ODROID-M1 board Content-Language: en-US To: Peter Geis Cc: Dongjin Kim , Heiko Stuebner , devicetree , arm-mail-list , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List References: <20220329094446.415219-1-tobetter@gmail.com> <20220329094446.415219-2-tobetter@gmail.com> <2a5f002f-8a61-e5b0-a574-ee99591c4c12@kernel.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220417_104600_910666_443D0872 X-CRM114-Status: GOOD ( 15.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/04/2022 14:07, Peter Geis wrote: >>> + dc_12v: dc-12v { >> >> Generic node name, so "regulator" or "regulator-0" > > Unfortunately, this advice breaks the regulator-fixed driver, which it > seems cannot cope with a bunch of nodes all named "regulator". What exactly cannot cope? You cannot have different device nodes with the same name but this is not a limitation of regulator but devicetree spec. > Setting the regulators as regulator-0 -1 -2 leads to fun issues where > the regulator numbering in the kernel doesn't match the node numbers. There are no "node numbers"... maybe you mean unit addresses? But there are none here. > It also makes it more fun when additional regulators need to be added > and everything gets shuffled around. Usually adding - in subsequent DTS files - means increasing the numbers so if you have regulator-[012] then just use regulator-[345] in other files. I see potential mess when you combine several DTSI files, each defining regulators, so in such case "some-name-regulator" (or reversed) is also popular approach. > If naming these uniquely to avoid confusion and collisions is such an > issue, why is it not caught by make W=1 dtbs_check? Patches are welcome. :) Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel