From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Felipe Balbi <balbi@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Jerome Audu <jerome.audu@st.com>, Felipe Balbi <felipe@balbi.sh>
Subject: Re: [PATCH v3] usb: dwc3: st: Rely on child's compatible instead of name
Date: Mon, 24 Oct 2022 09:16:38 +0200 [thread overview]
Message-ID: <ff2c969d-532e-8f18-041d-14c34e88eee9@foss.st.com> (raw)
In-Reply-To: <Y1PFaOEbPVDN7313@kroah.com>
On 10/22/22 12:26, Greg Kroah-Hartman wrote:
> On Fri, Sep 30, 2022 at 04:20:18PM +0200, patrice.chotard@foss.st.com wrote:
>> From: Patrice Chotard <patrice.chotard@foss.st.com>
>>
>> To ensure that child node is found, don't rely on child's node name
>> which can take different value, but on child's compatible name.
>>
>> Fixes: f5c5936d6b4d ("usb: dwc3: st: Fix node's child name")
>> Cc: Jerome Audu <jerome.audu@st.com>
>> Reported-by: Felipe Balbi <felipe@balbi.sh>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> ---
>> v3: - rebase on correct branch
>> v2: - add missing reported-by
>> - add Fixes
>> ---
>> drivers/usb/dwc3/dwc3-st.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
>> index 6c14a79279f9..fea5290de83f 100644
>> --- a/drivers/usb/dwc3/dwc3-st.c
>> +++ b/drivers/usb/dwc3/dwc3-st.c
>> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
>> /* Manage SoftReset */
>> reset_control_deassert(dwc3_data->rstc_rst);
>>
>> - child = of_get_child_by_name(node, "usb");
>> + child = of_get_compatible_child(node, "snps,dwc3");
>> if (!child) {
>> dev_err(&pdev->dev, "failed to find dwc3 core node\n");
>> ret = -ENODEV;
>> --
>> 2.25.1
>>
>
> Is this still needed for 6.1-final?
Yes, still needed for v6.1.
Thanks
Patrice
>
> thanks,
>
> greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-10-24 7:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 14:20 [PATCH v3] usb: dwc3: st: Rely on child's compatible instead of name patrice.chotard
2022-10-22 10:26 ` Greg Kroah-Hartman
2022-10-24 7:16 ` Patrice CHOTARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff2c969d-532e-8f18-041d-14c34e88eee9@foss.st.com \
--to=patrice.chotard@foss.st.com \
--cc=balbi@kernel.org \
--cc=felipe@balbi.sh \
--cc=gregkh@linuxfoundation.org \
--cc=jerome.audu@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).