From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F141C38A2D for ; Mon, 24 Oct 2022 07:18:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gY+F8fPqpjos+lgh+2TW7lIGfPKBFSQUG4np2cVyUHI=; b=dDOmMFSwJ+6W0t C+4sEsUs9lJmqGjfXz18E7DwPcGr1DWFxgU9+GlPtdb0nfYgDYmTcAl5O9dTg47CV68YFQkAT5XA4 nmcwU7sHyHdUULJt3AZ2X7XBBABFWAUsSo2KK7UpV2RVWlWiLieSUmWFBrP1BMfDWEcYn+v64Sq9m VUbGEbEbVzxF2PIZREWjIFtRTLd7ftjPxpz3Rh1i9Oe92lPOuMGLtOH/t7n9H9Q5czjbKWXtqMm+u qd+i8V/v3W45xqB09mZSjCJPZuJprwl52tzWEEoI7seALmDIPUMbx04lDbFAvwFlsYwRX2vX7SNNo KYA8CK7ex6F3oR+n45qw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1omri7-00HSIe-8v; Mon, 24 Oct 2022 07:17:23 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1omri4-00HSGB-IL for linux-arm-kernel@lists.infradead.org; Mon, 24 Oct 2022 07:17:22 +0000 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29NLeKsd010847; Mon, 24 Oct 2022 09:16:55 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=RGsQrACxVaiQ/PqYuY2b2GnpiqpCXdRkFoPEvUnvhcw=; b=zB9GoWQcvHm20Je2/l5foUJXJkxACJFDuypPhjL11OVGyW36PsI+qBMY57EHuEnJjIzq qo4fW5FYlaVE4mGXjqny+4CM2bcBRfjx07DwSvKNCuZIOm5OUPoiAU5UyS4yIdNx3U5w FijVzsUL+QZJw2/JzruM4+h447bLSRzkywiMQPIhG/EGwf1HkVfyIRUc4nSHHxvY9bXg v07HlHbvGfkAANoBBm2WLms9trQx56j52JOXtAwC3V0HBE8g9hvsP72+2RXV/fnxB1Sv QZez3mD2Hj4f97EYdYOc3M69F+NHYNIkazy9Wn+Gn9JKNeBAerFpDthaapYcWyCAfprU Ew== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3kc7dk1cb5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 24 Oct 2022 09:16:55 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id E7121100039; Mon, 24 Oct 2022 09:16:48 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id A89102132E7; Mon, 24 Oct 2022 09:16:48 +0200 (CEST) Received: from [10.201.21.72] (10.201.21.72) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct 2022 09:16:48 +0200 Message-ID: Date: Mon, 24 Oct 2022 09:16:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3] usb: dwc3: st: Rely on child's compatible instead of name To: Greg Kroah-Hartman CC: Felipe Balbi , , , , Jerome Audu , Felipe Balbi References: <20220930142018.890535-1-patrice.chotard@foss.st.com> Content-Language: en-US From: Patrice CHOTARD In-Reply-To: X-Originating-IP: [10.201.21.72] X-ClientProxiedBy: SHFCAS1NODE1.st.com (10.75.129.72) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-24_01,2022-10-21_01,2022-06-22_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221024_001721_020170_17BE053B X-CRM114-Status: GOOD ( 18.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/22/22 12:26, Greg Kroah-Hartman wrote: > On Fri, Sep 30, 2022 at 04:20:18PM +0200, patrice.chotard@foss.st.com wrote: >> From: Patrice Chotard >> >> To ensure that child node is found, don't rely on child's node name >> which can take different value, but on child's compatible name. >> >> Fixes: f5c5936d6b4d ("usb: dwc3: st: Fix node's child name") >> Cc: Jerome Audu >> Reported-by: Felipe Balbi >> Signed-off-by: Patrice Chotard >> --- >> v3: - rebase on correct branch >> v2: - add missing reported-by >> - add Fixes >> --- >> drivers/usb/dwc3/dwc3-st.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c >> index 6c14a79279f9..fea5290de83f 100644 >> --- a/drivers/usb/dwc3/dwc3-st.c >> +++ b/drivers/usb/dwc3/dwc3-st.c >> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev) >> /* Manage SoftReset */ >> reset_control_deassert(dwc3_data->rstc_rst); >> >> - child = of_get_child_by_name(node, "usb"); >> + child = of_get_compatible_child(node, "snps,dwc3"); >> if (!child) { >> dev_err(&pdev->dev, "failed to find dwc3 core node\n"); >> ret = -ENODEV; >> -- >> 2.25.1 >> > > Is this still needed for 6.1-final? Yes, still needed for v6.1. Thanks Patrice > > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel