* [PATCH v3] usb: dwc3: st: Rely on child's compatible instead of name
@ 2022-09-30 14:20 patrice.chotard
2022-10-22 10:26 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: patrice.chotard @ 2022-09-30 14:20 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, linux-arm-kernel, linux-usb,
linux-kernel
Cc: patrice.chotard, Jerome Audu, Felipe Balbi
From: Patrice Chotard <patrice.chotard@foss.st.com>
To ensure that child node is found, don't rely on child's node name
which can take different value, but on child's compatible name.
Fixes: f5c5936d6b4d ("usb: dwc3: st: Fix node's child name")
Cc: Jerome Audu <jerome.audu@st.com>
Reported-by: Felipe Balbi <felipe@balbi.sh>
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
v3: - rebase on correct branch
v2: - add missing reported-by
- add Fixes
---
drivers/usb/dwc3/dwc3-st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
index 6c14a79279f9..fea5290de83f 100644
--- a/drivers/usb/dwc3/dwc3-st.c
+++ b/drivers/usb/dwc3/dwc3-st.c
@@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
/* Manage SoftReset */
reset_control_deassert(dwc3_data->rstc_rst);
- child = of_get_child_by_name(node, "usb");
+ child = of_get_compatible_child(node, "snps,dwc3");
if (!child) {
dev_err(&pdev->dev, "failed to find dwc3 core node\n");
ret = -ENODEV;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v3] usb: dwc3: st: Rely on child's compatible instead of name
2022-09-30 14:20 [PATCH v3] usb: dwc3: st: Rely on child's compatible instead of name patrice.chotard
@ 2022-10-22 10:26 ` Greg Kroah-Hartman
2022-10-24 7:16 ` Patrice CHOTARD
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2022-10-22 10:26 UTC (permalink / raw)
To: patrice.chotard
Cc: Felipe Balbi, linux-arm-kernel, linux-usb, linux-kernel,
Jerome Audu, Felipe Balbi
On Fri, Sep 30, 2022 at 04:20:18PM +0200, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
>
> To ensure that child node is found, don't rely on child's node name
> which can take different value, but on child's compatible name.
>
> Fixes: f5c5936d6b4d ("usb: dwc3: st: Fix node's child name")
> Cc: Jerome Audu <jerome.audu@st.com>
> Reported-by: Felipe Balbi <felipe@balbi.sh>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
> v3: - rebase on correct branch
> v2: - add missing reported-by
> - add Fixes
> ---
> drivers/usb/dwc3/dwc3-st.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
> index 6c14a79279f9..fea5290de83f 100644
> --- a/drivers/usb/dwc3/dwc3-st.c
> +++ b/drivers/usb/dwc3/dwc3-st.c
> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
> /* Manage SoftReset */
> reset_control_deassert(dwc3_data->rstc_rst);
>
> - child = of_get_child_by_name(node, "usb");
> + child = of_get_compatible_child(node, "snps,dwc3");
> if (!child) {
> dev_err(&pdev->dev, "failed to find dwc3 core node\n");
> ret = -ENODEV;
> --
> 2.25.1
>
Is this still needed for 6.1-final?
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3] usb: dwc3: st: Rely on child's compatible instead of name
2022-10-22 10:26 ` Greg Kroah-Hartman
@ 2022-10-24 7:16 ` Patrice CHOTARD
0 siblings, 0 replies; 3+ messages in thread
From: Patrice CHOTARD @ 2022-10-24 7:16 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Felipe Balbi, linux-arm-kernel, linux-usb, linux-kernel,
Jerome Audu, Felipe Balbi
On 10/22/22 12:26, Greg Kroah-Hartman wrote:
> On Fri, Sep 30, 2022 at 04:20:18PM +0200, patrice.chotard@foss.st.com wrote:
>> From: Patrice Chotard <patrice.chotard@foss.st.com>
>>
>> To ensure that child node is found, don't rely on child's node name
>> which can take different value, but on child's compatible name.
>>
>> Fixes: f5c5936d6b4d ("usb: dwc3: st: Fix node's child name")
>> Cc: Jerome Audu <jerome.audu@st.com>
>> Reported-by: Felipe Balbi <felipe@balbi.sh>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> ---
>> v3: - rebase on correct branch
>> v2: - add missing reported-by
>> - add Fixes
>> ---
>> drivers/usb/dwc3/dwc3-st.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
>> index 6c14a79279f9..fea5290de83f 100644
>> --- a/drivers/usb/dwc3/dwc3-st.c
>> +++ b/drivers/usb/dwc3/dwc3-st.c
>> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
>> /* Manage SoftReset */
>> reset_control_deassert(dwc3_data->rstc_rst);
>>
>> - child = of_get_child_by_name(node, "usb");
>> + child = of_get_compatible_child(node, "snps,dwc3");
>> if (!child) {
>> dev_err(&pdev->dev, "failed to find dwc3 core node\n");
>> ret = -ENODEV;
>> --
>> 2.25.1
>>
>
> Is this still needed for 6.1-final?
Yes, still needed for v6.1.
Thanks
Patrice
>
> thanks,
>
> greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-24 7:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-30 14:20 [PATCH v3] usb: dwc3: st: Rely on child's compatible instead of name patrice.chotard
2022-10-22 10:26 ` Greg Kroah-Hartman
2022-10-24 7:16 ` Patrice CHOTARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).