From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Sriranjani P <sriranjani.p@samsung.com>,
Chanho Park <chanho61.park@samsung.com>
Subject: Re: [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850
Date: Fri, 25 Nov 2022 15:49:11 +0100 [thread overview]
Message-ID: <ff33d45c-f4ad-49f3-24b6-b15b4af5aa83@linaro.org> (raw)
In-Reply-To: <CAPLW+4nSLP4ZpnzYrOfMu0uOQ0OYnWsnZ=sUppxts6O_3-yYZg@mail.gmail.com>
On 25/11/2022 15:38, Sam Protsenko wrote:
> On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even
>> though Linux currently does not enable them and relies on bootloader.
>>
>
> Not sure if this description is correct. Of course, there is no driver
> for "samsung,exynos850-sysreg" compatible at the moment, so the next
> compatible from the list ("syscon") is used for Exynos850. And
> "syscon" driver (drivers/mfd/syscon.c) actually does control the
> clocks. I remember adding "clocks" property to Exynos850 dts to fix
> actual problem. Also, the "clocks" property is not described in
> Documentation/devicetree/bindings/mfd/syscon.yaml, didn't really check
> if it's ok or it's just missing.
>
> Other than that comment:
>
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Ah, then commit msg is not good. I'll update it and maybe the clocks
should be required for Exynos850?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-25 14:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221125112237epcas5p42180c4d081cce89e14ac0975a94cdbc4@epcas5p4.samsung.com>
2022-11-25 11:21 ` [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433 Krzysztof Kozlowski
2022-11-25 11:21 ` [PATCH 2/4] dt-bindings: soc: samsung: exynos-sysreg: split from syscon Krzysztof Kozlowski
2022-11-25 14:05 ` Lee Jones
2022-11-25 14:15 ` Sam Protsenko
2022-11-25 14:32 ` Sriranjani P
2022-11-26 13:07 ` Krzysztof Kozlowski
2022-11-25 16:56 ` Alim Akhtar
2022-11-25 11:22 ` [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433 Krzysztof Kozlowski
2022-11-25 14:22 ` Sam Protsenko
2022-11-25 14:47 ` Krzysztof Kozlowski
2022-11-25 14:57 ` Sam Protsenko
2022-11-25 15:01 ` Krzysztof Kozlowski
2022-11-25 16:40 ` Alim Akhtar
2022-11-25 14:33 ` Sriranjani P
2022-11-25 17:06 ` Alim Akhtar
2022-11-26 13:08 ` Krzysztof Kozlowski
2022-11-25 11:22 ` [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850 Krzysztof Kozlowski
2022-11-25 14:33 ` Sriranjani P
2022-11-25 14:38 ` Sam Protsenko
2022-11-25 14:49 ` Krzysztof Kozlowski [this message]
2022-11-25 15:01 ` Sam Protsenko
2022-11-25 14:22 ` [PATCH 1/4] arm64: dts: exynos: add dedicated SYSREG compatibles to Exynos5433 Sam Protsenko
2022-11-25 14:29 ` Sriranjani P
2022-11-25 16:51 ` Alim Akhtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff33d45c-f4ad-49f3-24b6-b15b4af5aa83@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=chanho61.park@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=sriranjani.p@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).