From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F1E2C4332F for ; Fri, 25 Nov 2022 14:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BdP+JKH66A36FGhDjijHeu7omkX6MawhsAIhNosCzjc=; b=WPI9ENKEXxUJXa QJAuEhLv0zstn/oQneJ4r5onEUdsk43g0tO9zJRORVxxbDruHVP5Ou4JapCp+CV4VptNsw47phOk+ sSWvNQW9dznFSxpsCWZMZkGEppzKtofX9OAVDr6hHChNq1dCgZ072p4ri3k8S7jxcgibSx3Xlh4xb qE+5Nm6DfmY14hrborGkZd1e7Yt7WaU6Wf5Of6BasgqtlIZ8HZdKfzQtlVESdJ66DWq4FnhOd5ndg YRRCamW/jpJgWxJoHcLGtE6S8Jel7Z/+71YSrYCGoDW/P7TD1b9bzLJT1ynl4xhTFBN9BsOk8xB52 zCRDrNWI9ZEkkDLPglVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyaAB-00HGkt-Pd; Fri, 25 Nov 2022 14:58:48 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oya0w-00HBzB-Og for linux-arm-kernel@lists.infradead.org; Fri, 25 Nov 2022 14:49:16 +0000 Received: by mail-lf1-x129.google.com with SMTP id j4so7285330lfk.0 for ; Fri, 25 Nov 2022 06:49:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xNPy40s2BPmi7d6v+ulfkIvVTaVgsEKVuTaAekdgNxg=; b=IlJ05o48+8OuRyWJoc3IhN7eIiMk98yN/eF/6MaEBN5+wjylbStpKcIbn5X7QveH7X 7NXABP5aoGsvaySi86ydt5sCb/KGRm+Dw+ECWZe45Kwl3o8EHW4ZTbDVpymhS0h2qDRn GQhkJPEvBOd/ooKkRE02SZVZaG6PSM5wfFBSUQOtjmWRobu3w7gfSyYTdJyJ2rHV+uAL zHU8wCDqszwD2nYgLXksic6mmtnsBO6LXcb3dsCZRtBRArGG3dKFPkVqEwwn8XMcimHn iq5oe6UMv9y1l/6sjdLod/Kyz1Tg/YCS3oh6IO1Li9jnsybwwtqWTawCA/zQe9KWCq4M aICg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xNPy40s2BPmi7d6v+ulfkIvVTaVgsEKVuTaAekdgNxg=; b=IAtxot9J2nyn6VI3M9IoPp1RQOPaQaftUxWKE6V9WJJ5JOn1lCI6HWDfQJUXzakHHr /Ns3Qbd0mAdkyWOiHqxJWCFyruCL6++6JtlW8aJR7T0xz0jTG9Qf1Gp/zM+OTtLVlqeL HNS1KTXBGPXIr3YOcv3Ey8pYovmLpUO415Ie3XEZ9AvUjsPg/T7Zbb4GavzizNzmppp2 u75YgzCXWHiScgrl2Mfjy3HgCBEj22uMHG/6TLYyRovix6stOGrLTtnreTXz4sdr5lhT eSGQ6X/GkE+d9OJuhD2JxjOOct8fZfD8e8Zj7x0HuyDWy4686t+rGf5N2rIESMmGpDRP XZgA== X-Gm-Message-State: ANoB5plSVuX6eALTlZPOJ4xsDRTQ5TeDDY3HE1GYat/lRA0o2m2seNoL LCFIzx5kz2rvlEL4FuK7rlDWfQ== X-Google-Smtp-Source: AA0mqf4bce/D1OJeUf4UCKOv4zGJQnRoVTveEJVWArehvP51fU5aC7O5xk7KIGrSeEQmFBAgmaEZpg== X-Received: by 2002:ac2:51b6:0:b0:4ae:8510:646f with SMTP id f22-20020ac251b6000000b004ae8510646fmr13550031lfk.432.1669387753066; Fri, 25 Nov 2022 06:49:13 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id v12-20020a056512348c00b004994c190581sm555549lfr.123.2022.11.25.06.49.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 06:49:12 -0800 (PST) Message-ID: Date: Fri, 25 Nov 2022 15:49:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 4/4] dt-bindings: soc: samsung: exynos-sysreg: add clocks for Exynos850 Content-Language: en-US To: Sam Protsenko Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Sriranjani P , Chanho Park References: <20221125112201.240178-1-krzysztof.kozlowski@linaro.org> <20221125112201.240178-4-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221125_064914_863700_30CB3FC6 X-CRM114-Status: GOOD ( 15.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/11/2022 15:38, Sam Protsenko wrote: > On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski > wrote: >> >> Exynos850 has dedicated clock for accessing SYSREGs. Allow it, even >> though Linux currently does not enable them and relies on bootloader. >> > > Not sure if this description is correct. Of course, there is no driver > for "samsung,exynos850-sysreg" compatible at the moment, so the next > compatible from the list ("syscon") is used for Exynos850. And > "syscon" driver (drivers/mfd/syscon.c) actually does control the > clocks. I remember adding "clocks" property to Exynos850 dts to fix > actual problem. Also, the "clocks" property is not described in > Documentation/devicetree/bindings/mfd/syscon.yaml, didn't really check > if it's ok or it's just missing. > > Other than that comment: > > Reviewed-by: Sam Protsenko > >> Signed-off-by: Krzysztof Kozlowski Ah, then commit msg is not good. I'll update it and maybe the clocks should be required for Exynos850? Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel