Re: [PATCH] arm64: dts: rockchip: Add dtsi file for RK3399S SoC variant

Dragan Simic
2024-10-11T07:04:47Z

Hello Heiko,

On 2024-10-10 22:24, Heiko Stübner wrote:
> Am Mittwoch, 9. Oktober 2024, 16:06:00 CEST schrieb Dragan Simic:
>> The way the introduced RK3399S SoC variant dtsi file (rk3399s.dtsi) is
>> named
>> diverges from the way the two already present RK3399 SoC variant dtsi
>> files
>> (rk3399-op1.dtsi and rk3399-t.dtsi) are named, but that simply follows
>> the
>> commonly used and/or the official RK3399 SoC variant names.
>
> This is my only gripe with this ;-) .
>
> I.e. looking through simple google, the rk3399t also seems to be
> written
> without "-" most of the time.
>
> Though for me it would make the most sense to just go with "rk3399-s"
> here for some sort of clear style between -s -t and -op1

Believe it or not, the inconsistency of having no dash before the "s"
has bothered me too. :) Let's add the dash, which I'll do in the v2.