From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EBD0C282C4 for ; Tue, 12 Feb 2019 15:41:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5873A217FA for ; Tue, 12 Feb 2019 15:41:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k1/zjXGu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5873A217FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y27m4sLxqXSPi8WyDwrKCHajLcqZPF+MA+rf1jlSoMk=; b=k1/zjXGu5hcnA1 KKtYoRVehjiBvNay/Z2xYyvFy6XWLiyizFXwvz+0aXfL4hzqnk3xmxuIQFLJUj4JfArH22gAfcJWN KtJP6ZzVSX7/kOmLiT7rNCvtZFFjViVXDIvlxhRBpd6WQUIJo6K0p1WF2ORxV1KzlwJW1e3jgBjIl VcU3967tX7Nc1Elew/akyw3dyuuGVy4uE+IAUTno7UTEZzqipqGsJDMTSV3YRpigP4ri0sZQxhFpj A9iAStski/lOKXcbbWuTjD8RweGO08QOgZpM21olH7Abv8b7qJEmoB83G/x4tuVyPRCh9eNr2tY4B OkF7uUgw1p2kllEC9gjQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtaBe-0005V6-Gj; Tue, 12 Feb 2019 15:41:30 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtaBa-0005Ug-QK for linux-arm-kernel@lists.infradead.org; Tue, 12 Feb 2019 15:41:28 +0000 X-Originating-IP: 90.88.30.68 Received: from aptenodytes (aaubervilliers-681-1-89-68.w90-88.abo.wanadoo.fr [90.88.30.68]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 3D54340004; Tue, 12 Feb 2019 15:41:23 +0000 (UTC) Message-ID: Subject: Re: [PATCH v3 4/8] drm/sun4i: dsi: Fix front vs back porch calculation From: Paul Kocialkowski To: Maxime Ripard , Maarten Lankhorst , Sean Paul Date: Tue, 12 Feb 2019 16:41:22 +0100 In-Reply-To: <90c2375b8a853cae0dcc135cedb47edbc26168d8.1549896081.git-series.maxime.ripard@bootlin.com> References: <90c2375b8a853cae0dcc135cedb47edbc26168d8.1549896081.git-series.maxime.ripard@bootlin.com> Organization: Bootlin User-Agent: Evolution 3.30.5 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190212_074127_013456_E12FC208 X-CRM114-Status: GOOD ( 13.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bbrezillon@kernel.org, dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Thomas Petazzoni , Jagan Teki , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, 2019-02-11 at 15:41 +0100, Maxime Ripard wrote: > Since I always confuse the back and front porches, a few miscalculation > slipped through. Fix them. > > Signed-off-by: Maxime Ripard Food for thoughts: everything indicates that backporch does not count sync length for the DSI registers (while it does for TCON). So all these changes look good! Reviewed-by: Paul Kocialkowski Cheers, Paul > --- > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > index 506f2e8cf454..2518a0d7567c 100644 > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > @@ -477,7 +477,7 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi, > */ > #define HBP_PACKET_OVERHEAD 6 > hbp = max((unsigned int)HBP_PACKET_OVERHEAD, > - (mode->hsync_start - mode->hdisplay) * Bpp - HBP_PACKET_OVERHEAD); > + (mode->htotal - mode->hsync_end) * Bpp - HBP_PACKET_OVERHEAD); > > /* > * The frontporch is set using a blanking packet (4 bytes + > @@ -485,7 +485,7 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi, > */ > #define HFP_PACKET_OVERHEAD 6 > hfp = max((unsigned int)HFP_PACKET_OVERHEAD, > - (mode->htotal - mode->hsync_end) * Bpp - HFP_PACKET_OVERHEAD); > + (mode->hsync_start - mode->hdisplay) * Bpp - HFP_PACKET_OVERHEAD); > > /* > * hblk seems to be the line + porches length. > @@ -531,8 +531,8 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi, > regmap_write(dsi->regs, SUN6I_DSI_BASIC_SIZE0_REG, > SUN6I_DSI_BASIC_SIZE0_VSA(mode->vsync_end - > mode->vsync_start) | > - SUN6I_DSI_BASIC_SIZE0_VBP(mode->vsync_start - > - mode->vdisplay)); > + SUN6I_DSI_BASIC_SIZE0_VBP(mode->vtotal - > + mode->vsync_end)); > > regmap_write(dsi->regs, SUN6I_DSI_BASIC_SIZE1_REG, > SUN6I_DSI_BASIC_SIZE1_VACT(mode->vdisplay) | -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel