linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: Rob Herring <robh@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Li Yang <leoyang.li@nxp.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: layerscape: Fix GICv3 ITS node names
Date: Thu, 9 Feb 2023 13:28:11 +0000	[thread overview]
Message-ID: <ff471140-5bbb-fb64-f000-eb7ba97dd74e@arm.com> (raw)
In-Reply-To: <20230208183437.2283665-1-robh@kernel.org>

On 2023-02-08 18:34, Rob Herring wrote:
> The GICv3 ITS is an MSI controller, therefore its node name should be
> 'msi-controller'.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Note that this exposes an issue that #msi-cells is missing. In turn, the
> use of msi-parent in PCI nodes is wrong and should be msi-map according
> to my sources (Robin M), but I have no idea what is correct there.

This is a funny one, since AIUI those "msi-parent" properties are now 
really only there for the bootloader to pick up the phandle to build a 
proper "msi-map" property[1][2]. As such, I imagine it should *probably* 
be OK to add a dummy argument so that "#msi-cells = <1>" can be 
correctly specified, however I can't claim to be an expert on these 
systems and whether there are any other bootloader behaviours that also 
need to be supported.

Thanks,
Robin.

[1] 
https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/net/fsl-mc/mc.c#L328
[2] 
https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/pci/pcie_layerscape_fixup.c

>   arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
>   arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 2 +-
>   arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 2 +-
>   arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 2 +-
>   4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 1b33cabb4e14..dd1c8f60fad1 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -131,7 +131,7 @@ gic: interrupt-controller@6000000 {
>   		interrupt-controller;
>   		interrupts = <GIC_PPI 9 (GIC_CPU_MASK_RAW(0xf) |
>   					 IRQ_TYPE_LEVEL_LOW)>;
> -		its: gic-its@6020000 {
> +		its: msi-controller@6020000 {
>   			compatible = "arm,gic-v3-its";
>   			msi-controller;
>   			reg = <0x0 0x06020000 0 0x20000>;/* GIC Translater */
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index 260d045dbd9a..6dd680fb1b22 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -123,7 +123,7 @@ gic: interrupt-controller@6000000 {
>   		#size-cells = <2>;
>   		ranges;
>   
> -		its: gic-its@6020000 {
> +		its: msi-controller@6020000 {
>   			compatible = "arm,gic-v3-its";
>   			msi-controller;
>   			reg = <0x0 0x6020000 0 0x20000>;
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> index 348d9e3a9125..d2f5345d0560 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> @@ -60,7 +60,7 @@ gic: interrupt-controller@6000000 {
>   		interrupt-controller;
>   		interrupts = <1 9 0x4>;
>   
> -		its: gic-its@6020000 {
> +		its: msi-controller@6020000 {
>   			compatible = "arm,gic-v3-its";
>   			msi-controller;
>   			reg = <0x0 0x6020000 0 0x20000>;
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index 50c19e8405d5..ea6a94b57aeb 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -395,7 +395,7 @@ gic: interrupt-controller@6000000 {
>   		interrupt-controller;
>   		interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
>   
> -		its: gic-its@6020000 {
> +		its: msi-controller@6020000 {
>   			compatible = "arm,gic-v3-its";
>   			msi-controller;
>   			reg = <0x0 0x6020000 0 0x20000>;

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-02-09 13:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08 18:34 [PATCH] arm64: dts: layerscape: Fix GICv3 ITS node names Rob Herring
2023-02-09 13:28 ` Robin Murphy [this message]
2023-03-13  7:39 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff471140-5bbb-fb64-f000-eb7ba97dd74e@arm.com \
    --to=robin.murphy@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).