From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAC53C61DA4 for ; Thu, 9 Feb 2023 13:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mpCCCtVVdgMUP9aGE7HIlfSjLAXES8ZcBtCIa9QLWpE=; b=Z9uLxOnVqKopDb oh9NhXvz01Yb8Gu4w/iovBhdfpA7Fxu0/3cMv5QTDdPbuqCxtIK8Kq7q20yg8puk9/Z1nTEn2mbNf TKRC43lHcpGb2cUYJJoQphBZxTefx3gGIaVUCd/hD6wOFfVY0UALwU4YT5Zoto4NokvbW4Q4AN/j0 XVCVHKQaRLl3IS1BkCK0V19EL5NylSYLBCaEfk0QVk4KgMMas5OUAb0glRlyg1kRLMU5QmYjGXQGJ bTsI3ZgqD2xTXJVsx1uvwuir6aqCmYICEda7ko8YZiYdlOfmu3P3yyTUZegtrNtyFK+JXrND8tqpf hBAbcVybJRPNVE0iwMXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQ6yi-001g4j-KM; Thu, 09 Feb 2023 13:28:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pQ6ye-001g3i-32 for linux-arm-kernel@lists.infradead.org; Thu, 09 Feb 2023 13:28:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 464641477; Thu, 9 Feb 2023 05:29:15 -0800 (PST) Received: from [192.168.1.110] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B500B3F703; Thu, 9 Feb 2023 05:28:31 -0800 (PST) Message-ID: Date: Thu, 9 Feb 2023 13:28:11 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] arm64: dts: layerscape: Fix GICv3 ITS node names To: Rob Herring , Shawn Guo , Li Yang , Krzysztof Kozlowski Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230208183437.2283665-1-robh@kernel.org> Content-Language: en-GB From: Robin Murphy In-Reply-To: <20230208183437.2283665-1-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230209_052840_285770_7C363A7F X-CRM114-Status: GOOD ( 16.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-02-08 18:34, Rob Herring wrote: > The GICv3 ITS is an MSI controller, therefore its node name should be > 'msi-controller'. > > Signed-off-by: Rob Herring > --- > Note that this exposes an issue that #msi-cells is missing. In turn, the > use of msi-parent in PCI nodes is wrong and should be msi-map according > to my sources (Robin M), but I have no idea what is correct there. This is a funny one, since AIUI those "msi-parent" properties are now really only there for the bootloader to pick up the phandle to build a proper "msi-map" property[1][2]. As such, I imagine it should *probably* be OK to add a dummy argument so that "#msi-cells = <1>" can be correctly specified, however I can't claim to be an expert on these systems and whether there are any other bootloader behaviours that also need to be supported. Thanks, Robin. [1] https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/net/fsl-mc/mc.c#L328 [2] https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/pci/pcie_layerscape_fixup.c > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +- > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 2 +- > arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 2 +- > arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 1b33cabb4e14..dd1c8f60fad1 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -131,7 +131,7 @@ gic: interrupt-controller@6000000 { > interrupt-controller; > interrupts = IRQ_TYPE_LEVEL_LOW)>; > - its: gic-its@6020000 { > + its: msi-controller@6020000 { > compatible = "arm,gic-v3-its"; > msi-controller; > reg = <0x0 0x06020000 0 0x20000>;/* GIC Translater */ > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > index 260d045dbd9a..6dd680fb1b22 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi > @@ -123,7 +123,7 @@ gic: interrupt-controller@6000000 { > #size-cells = <2>; > ranges; > > - its: gic-its@6020000 { > + its: msi-controller@6020000 { > compatible = "arm,gic-v3-its"; > msi-controller; > reg = <0x0 0x6020000 0 0x20000>; > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi > index 348d9e3a9125..d2f5345d0560 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi > @@ -60,7 +60,7 @@ gic: interrupt-controller@6000000 { > interrupt-controller; > interrupts = <1 9 0x4>; > > - its: gic-its@6020000 { > + its: msi-controller@6020000 { > compatible = "arm,gic-v3-its"; > msi-controller; > reg = <0x0 0x6020000 0 0x20000>; > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > index 50c19e8405d5..ea6a94b57aeb 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > @@ -395,7 +395,7 @@ gic: interrupt-controller@6000000 { > interrupt-controller; > interrupts = ; > > - its: gic-its@6020000 { > + its: msi-controller@6020000 { > compatible = "arm,gic-v3-its"; > msi-controller; > reg = <0x0 0x6020000 0 0x20000>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel