From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9A45C4332F for ; Tue, 20 Dec 2022 10:51:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g4To4fBa0ov1L0saC4OeLXHLbA7nvTs2n7Z1yRX9yQc=; b=D/t1bQ6xJuciwS QHTFFcQz1yjINner/3yhqtwRhFdBSQzaQPTeSGQOlUlw02w0oEPe/sRGDDytIgT3w8vp2WzN/hiVR fGsqys4ZBRCyJ/2RbUonkkXs28muAmyVhWtLTkdBNc2xAgFYYh7YSEsRAdimIWr2uhkWhAbrNDGVS Im4/DXbtwjT3oDPMSLrL09ZcCEvLXy6xstYht4UfGlIGvE/mP75NPs1uFryuXd2M18RYH1LABs634 G/sGfJ7NTXmuultyfYty0vQS+JTFUdH/KhhKINUIhvdBrsXxOxNvegn5YM5eAPeYYm2ql+qtGbcFF gfsyoq0/bo1XPgAcqI6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7aCN-00DTKD-On; Tue, 20 Dec 2022 10:50:15 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7aCH-00DTFx-7X for linux-arm-kernel@lists.infradead.org; Tue, 20 Dec 2022 10:50:12 +0000 Received: by mail-lf1-x132.google.com with SMTP id m29so17764599lfo.11 for ; Tue, 20 Dec 2022 02:50:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9gfcuA14rqPUTUjjsVp9VcIwRZasaVKQdRygjZ2irTU=; b=anpeRiNM7FlnxT5gtmKwEo9mEc9aOuR5M4DaPXbt9wiIelhZdcKyYLsH612lT0gdbn k4QJetrOLBEGyAF5BB/xzz09GIr8IYoOPuni7OuY50H3Je9KBocnD21s1cDJLacRSOCt HxEoPB81hUQCY/IhV7rb28/FHCgqP+9h7g/RY8Zb2N0fXTc8w+Dk6Oiro79nAhSNsI2R 5vQPplpMQBhj2Run4kIKddQzon2gMb8F20JP4rR3ynDsUph9i5Gkx5DrGM9bR658Flqu 2oOVfMSYawPY18055kSFOQ//Q6uFcPFnScZlUFTeHHAKEPW6nNpR3GzDUMIRWWa5MAjU JWXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9gfcuA14rqPUTUjjsVp9VcIwRZasaVKQdRygjZ2irTU=; b=q8Ran6rEKc2xjCBAO661d2seC/0XkNKDMRtwOP56YF8FRZBbKI5Uv2Ubcg+kHTTZHd IciZ92VWp5L4+RWMBzaMEtbVCIiMb6ubjhgBGmV6y3RO8FAt97t02U/G01XPPQZ3+eu3 rCjTGJxpHIhAinSZLgUsngKxOqXvhJ5rKYF97JYvLeb+bpeJPVZl43fJ+xFQtVhfBxUz bUuIQD4RHQ6yin0jYvAtF10+BlpElWTmOzlnu8PdJUm8vegr8lH8qXe6kGgX7wK4O5Oa wUpkONTp/+PPMNqvjaOKjDpxb7pHkfFzS8MixLs7d0LKJNzC0rVuOIfF9EiWw/UFat0Q nxtQ== X-Gm-Message-State: AFqh2krdIi1lzi9CTZVxX5Z1FFZFWBBPzkDWT2s2dWwRtd/fRP8f2b4c edko+AgqvY3oq2eoPbisIa+26g== X-Google-Smtp-Source: AMrXdXuW0FVi+JBWXdCwrMCPwlIJkB9K57igjb8vvaYBBu5oPOgHP59tcGGEBi0Ow1zr3U4zP9sWhQ== X-Received: by 2002:a05:6512:308a:b0:4c0:91d0:e7bc with SMTP id z10-20020a056512308a00b004c091d0e7bcmr5642377lfd.26.1671533407452; Tue, 20 Dec 2022 02:50:07 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id m8-20020a056512358800b004b5284a92f9sm1404763lfr.208.2022.12.20.02.50.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Dec 2022 02:50:06 -0800 (PST) Message-ID: Date: Tue, 20 Dec 2022 11:50:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes Content-Language: en-US To: Bhavya Kapoor , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org, kristo@kernel.org, nm@ti.com References: <20221220101249.46450-1-b-kapoor@ti.com> From: Krzysztof Kozlowski In-Reply-To: <20221220101249.46450-1-b-kapoor@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221220_025010_301116_F8884F95 X-CRM114-Status: GOOD ( 17.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/12/2022 11:12, Bhavya Kapoor wrote: > J721s2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes > for 8 channel ADCs for J721s2 SoC. > > Signed-off-by: Bhavya Kapoor > --- > .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++ > .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 42 ++++++++++++++++++- > 2 files changed, 55 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts > index a7aa6cf08acd..67593aa69327 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts > @@ -309,3 +309,17 @@ &mcu_mcan1 { > pinctrl-0 = <&mcu_mcan1_pins_default>; > phys = <&transceiver2>; > }; > + > +&tscadc0 { > + status = "okay"; > + adc { > + ti,adc-channels = <0 1 2 3 4 5 6 7>; > + }; > +}; > + > +&tscadc1 { > + status = "okay"; > + adc { > + ti,adc-channels = <0 1 2 3 4 5 6 7>; > + }; > +}; > \ No newline at end of file This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel