linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/7] gpio: brcmstb: consolidate interrupt domains
Date: Sat, 28 Oct 2017 09:56:22 -0700	[thread overview]
Message-ID: <ff7a5f19-9f64-7872-6a77-57779e24d45c@gmail.com> (raw)
In-Reply-To: <20171024195451.30535-7-opendmb@gmail.com>



On 10/24/2017 12:54 PM, Doug Berger wrote:
> The GPIOLIB IRQ chip helpers were very appealing, but badly broke
> the 1:1 mapping between a GPIO controller's device_node and its
> interrupt domain.
> 
> When another device-tree node references a GPIO device as its
> interrupt parent, the irq_create_of_mapping() function looks for
> the irq domain of the GPIO device and since all bank irq domains
> reference the same GPIO device node it always resolves to the irq
> domain of the first bank regardless of which bank the number of
> the GPIO should resolve. This domain can only map hwirq numbers
> 0-31 so interrupts on GPIO above that can't be mapped by the
> device-tree.
> 
> This commit effectively reverts the patch from Gregory Fong [1]
> that was accepted upstream and replaces it with a consolidated
> irq domain implementation with one larger interrupt domain per
> GPIO controller instance spanning multiple GPIO banks based on
> an earlier patch [2] also submitted by Gregory Fong.
> 
> [1] https://patchwork.kernel.org/patch/6921561/
> [2] https://patchwork.kernel.org/patch/6347811/
> 
> Fixes: 19a7b6940b78 ("gpio: brcmstb: Add interrupt and wakeup source support")
> Signed-off-by: Doug Berger <opendmb@gmail.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

-- 
Florian

  parent reply	other threads:[~2017-10-28 16:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24 19:54 [PATCH v2 0/7] gpio: brcmstb: improved interrupt and wake support Doug Berger
2017-10-24 19:54 ` [PATCH v2 1/7] gpio: brcmstb: Do not use gc->pin2mask() Doug Berger
2017-10-28 16:54   ` Florian Fainelli
2017-10-24 19:54 ` [PATCH v2 2/7] gpio: brcmstb: allow all instances to be wakeup sources Doug Berger
2017-10-31  9:28   ` Linus Walleij
2017-10-24 19:54 ` [PATCH v2 3/7] gpio: brcmstb: release the bgpio lock during irq handlers Doug Berger
2017-10-31  9:29   ` Linus Walleij
2017-10-24 19:54 ` [PATCH v2 4/7] gpio: brcmstb: switch to handle_level_irq flow Doug Berger
2017-10-31  9:30   ` Linus Walleij
2017-10-24 19:54 ` [PATCH v2 5/7] gpio: brcmstb: correct the configuration of level interrupts Doug Berger
2017-10-31  9:31   ` Linus Walleij
2017-10-24 19:54 ` [PATCH v2 6/7] gpio: brcmstb: consolidate interrupt domains Doug Berger
2017-10-26 23:44   ` Gregory Fong
2017-10-28 16:56   ` Florian Fainelli [this message]
2017-10-31  9:34   ` Linus Walleij
2017-10-24 19:54 ` [PATCH v2 7/7] gpio: brcmstb: implement suspend/resume/shutdown Doug Berger
2017-10-26 23:51   ` Gregory Fong
2017-10-28 16:58   ` Florian Fainelli
2017-10-31  9:52   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff7a5f19-9f64-7872-6a77-57779e24d45c@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).