From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3934FC46CD2 for ; Tue, 9 Jan 2024 10:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dkHehFPtbGs+lEcIhMiTi2jYT/a/02IOtHgI46e/LoY=; b=E5yXAzZYSuksAb ir4ro1F+vDqWcfTiApl4WpepTgSuD3O4Vigh9Kv9FmZYGuZjY6hehKdTLQN7wnqOaJedQpnVnDTY5 U7FHIQl8XjjNz3AQ2N+si5USDt9BYgmUQi7kf237rNJoGmz4wJczNL2biBPEpujzL3ICSDobQFmJ3 6i4O7aozBLdlKodRpkD1eCl+YoHlFtIkk71fbRVkITaNpxd5gZI33fb/EWkUphYaEAxydaK0sony0 SR1faSQMhh3vtMKqqMNu+s1YijtdS8TpN3TRSBNU4uN7L8sor5HRBF+p4a5OwDJ23ex1c41/FTYHs ntoGQzUd2och+kF53uxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rN9dc-007fMg-2S; Tue, 09 Jan 2024 10:47:16 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rN9dY-007fJ6-39; Tue, 09 Jan 2024 10:47:14 +0000 X-UUID: 6ee253daaedc11eeafd70d0b34820190-20240109 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=hZ4atKULKmr38EldIdUWJZzcudaGRLqjKWY7mfo1OoQ=; b=EKGdwkX2QzQkxhb4kH5IrAUfkQMneBoLtZNBTxj3W4ki51ggBaU1wdtjZ2ksyYBUAliW48hAT753mIcENqjfRYB7xkV6ZXc3HfS2O8xu3JsO1Re4vWIeEcgfQvA32Ym/OSQEBJuyPeFaiyE/vyMeLuXbX+a/ImKrBTwSwF/F1I4=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.35,REQID:c6636f13-fb2a-4cd4-9115-d960f9ebe555,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:5d391d7,CLOUDID:828da782-8d4f-477b-89d2-1e3bdbef96d1,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO, DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULS X-UUID: 6ee253daaedc11eeafd70d0b34820190-20240109 Received: from mtkmbs14n2.mediatek.inc [(172.21.101.76)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 893299607; Tue, 09 Jan 2024 03:47:07 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Tue, 9 Jan 2024 18:46:31 +0800 Received: from APC01-PSA-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Tue, 9 Jan 2024 18:46:31 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X5ttJ8AZNDe0f3tgYFgCssOOJ7jhCulfzM6W+DPTMT9Wan4xfo87aeoS2Rb3nYatmjUAA65mcWzM8qWWY58r1nXdXcW+AcNWzSWajcr+bTh5DFpmuNn/DagMIwYHR/E+EYvIBxQSiaE0Gu1IAdgTxHkB+KO72NtWxlMj2ydtPhyo/hqCNSqm+43Kw5dCZ27XBeowYh5nvtnkCrAmRjqmDYiL7GSPiVYoue+V+Iq7xjaeO+0TtCUDPw9El+9zHRcm48fl1U4K/VeHnzXeQCPAyMMKZVuEcvW6eRQSfQq6TYgjeYpzb0HPy+UQaOP6RWdq2bXjptEYCvN1IC9KCorwZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hZ4atKULKmr38EldIdUWJZzcudaGRLqjKWY7mfo1OoQ=; b=JlEgZiWcFo8MAmE1gxnTY3XylsWWQIlsWWY9l559Q85YLCp0JO54zBetpOXUF4Zs8nf4gMKO/dlwhEStfLMMHBSJ67HrZkfwNuqYX/26VQ6CtEjRXJhJWB+7Ab/lgN55Kawow4w48QiSofC6LzOhT0ETaMrTw9n7t4Eh2iDSFEIOR4uHgQZCbjN844dBpBM6XJ4GqX0raFxjKTw9iI5oPMCG0LiayRrAchqP7O/DhBZ1uPc8dkb65cEgWD9wmGNDGZmiIilNllgKgmhNhky5C31prHxNoH+Ltlax6VKvKZKwJJ7rHuFokITvwzGhiTp6cF+7STiny3kpJrhDRzhuUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hZ4atKULKmr38EldIdUWJZzcudaGRLqjKWY7mfo1OoQ=; b=Q+da2FQ8U/D9YnEwU1A17oIJnO4HdeOipgmL27SwRN4RXyEQ9ccr5pKv1n+j/bsI9Z5hQPKfiHiMU0HpyOXVwEFQUqetpUsOaCe9Qsro/OwSg/IiF7/2e3FelUATkL0mhHI1VqMSeY9HI2BpHyQWS+H3mu13sZ/WThGJFFNzPIY= Received: from TYZPR03MB5566.apcprd03.prod.outlook.com (2603:1096:400:53::7) by JH0PR03MB8843.apcprd03.prod.outlook.com (2603:1096:990:a5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.21; Tue, 9 Jan 2024 10:46:28 +0000 Received: from TYZPR03MB5566.apcprd03.prod.outlook.com ([fe80::ccc5:b092:efbe:6134]) by TYZPR03MB5566.apcprd03.prod.outlook.com ([fe80::ccc5:b092:efbe:6134%7]) with mapi id 15.20.7159.020; Tue, 9 Jan 2024 10:46:28 +0000 From: =?utf-8?B?WmhpIE1hbyAo5q+b5pm6KQ==?= To: "mchehab@kernel.org" , "krzysztof.kozlowski@linaro.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" CC: "heiko@sntech.de" , "gerald.loacker@wolfvision.net" , "tomi.valkeinen@ideasonboard.com" , "yunkec@chromium.org" , "linux-kernel@vger.kernel.org" , "dan.scally@ideasonboard.com" , "linux-media@vger.kernel.org" , =?utf-8?B?U2hlbmduYW4gV2FuZyAo546L5Zyj55S3KQ==?= , "hdegoede@redhat.com" , "linus.walleij@linaro.org" , "andy.shevchenko@gmail.com" , =?utf-8?B?WWF5YSBDaGFuZyAo5by16ZuF5riFKQ==?= , "bingbu.cao@intel.com" , "jacopo.mondi@ideasonboard.com" , "jernej.skrabec@gmail.com" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , Project_Global_Chrome_Upstream_Group , "conor+dt@kernel.org" , "10572168@qq.com" <10572168@qq.com>, "sakari.ailus@linux.intel.com" , "hverkuil-cisco@xs4all.nl" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "laurent.pinchart@ideasonboard.com" , "angelogioacchino.delregno@collabora.com" , "macromorgan@hotmail.com" Subject: Re: [PATCH 1/2] media: i2c: Add GC08A3 image sensor driver Thread-Topic: [PATCH 1/2] media: i2c: Add GC08A3 image sensor driver Thread-Index: AQHaKM07MRhkqnzY9kyFxe9G5PmOILCdekUAgDQGUAA= Date: Tue, 9 Jan 2024 10:46:28 +0000 Message-ID: References: <20231207052016.25954-1-zhi.mao@mediatek.com> <20231207052016.25954-2-zhi.mao@mediatek.com> <1d58c2b9-4206-409c-b312-87f4fb649512@linaro.org> In-Reply-To: <1d58c2b9-4206-409c-b312-87f4fb649512@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB5566:EE_|JH0PR03MB8843:EE_ x-ms-office365-filtering-correlation-id: 6e7b1633-3ecc-4fd8-07c5-08dc11003c03 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q0zf7gUvsBGT0hhGG2LPO1Jg6rgBzKdHaKT2SRHsk3enRdZ5o4yts3KCPnip/TBslXazOgWFk0hxxxk/XVh35iYHPoh2ElvUxdeNAmXrF1RyqZbNhNRcfzNxIDoPM1Q7MLVZq/CG/ECQohJ7NERlsuRoGn+S3HhQdTkhc3ZGKY4R3FHRKJsifNDuwzD5rE5xm71UblHTHv076/7CIOTQqEBJ9xyp+p0qlUOWKVCMBdipZQOYSoqzh9RW1ZQciIyQtvZve61SI+s2HLAm8MDK1Jwb0NTqPlijAidl2KRUzhFL87ArrrAanHGJoqFDW8BCcEgAk9Ds4h6G1qFuQB5uDOLAUO3XfNryvAvBcxcbNb6fCEJ4lBf5wFb/sRdWSxP7kwdnC1Vcdte/GmRMwMcXuW1W+S3VcHoXdpfp8+RaKJ2nyQzDcLVGHP677oN5t4zHpwDuMLg2gGUKRS0LXGyeyd7IvbqCefEtW4EoXLCqS7G96DW57NZxVaW4sTRNtACOMKopMqZWD/pyQvm5aXiUj5hjUAxtaOqG4IQwnUcaUkr028xWXxV8uZQ43Qv25kZcmBgZWYPq33Eru5M7LWoMf4t+jpqkWXlGYTxXJzVCa3n67v8VPqADBEZzXpA1O4bfcx++kf2w1op6rUuSzzUCnHUwPKZwR1LRvUtIEd2a1PF6vu444D8Y67BZSvmQrq5M x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB5566.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(39860400002)(346002)(396003)(376002)(136003)(230922051799003)(230173577357003)(230273577357003)(1800799012)(64100799003)(186009)(451199024)(6486002)(26005)(2616005)(478600001)(71200400001)(122000001)(38100700002)(6512007)(966005)(6506007)(53546011)(8676002)(66556008)(66946007)(54906003)(110136005)(8936002)(66446008)(66476007)(91956017)(76116006)(64756008)(316002)(83380400001)(4326008)(5660300002)(7416002)(2906002)(41300700001)(36756003)(86362001)(38070700009)(85182001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QS9jTGwraFIvaXJUWXVhRmthbmJjbkQwRFVmNlhIT1YvRXNlV2NxVFVwbWMy?= =?utf-8?B?d2xvNExnSEZRYW9MY2JYZ1hlQUsrNlJpYWc0NUNXM1hnUC9Qa3QwSXdGdVdJ?= =?utf-8?B?N3lEajFwV2RnR28vcHA2aXo1ZW1sUmdDSjAwengxTjBHeFJzUVA5Vjc5cGUx?= =?utf-8?B?TWt6eFBBQW9SWWhheGdGRE0yVXd4REJtQkRCOE84YjVmR2tHNStJMmROQmo3?= =?utf-8?B?LzlNNG5jSWl3dzBrOTRNVmRpdE5vWHIyV1B1aUlpVzFTbVRnWldIa1gxR3Vu?= =?utf-8?B?YlZZYm51WlI4SnhHcmpqYnZtUUExSVVTWG5QNWpXb0hjZGF1TG9DSzE3bkJM?= =?utf-8?B?RnRJeUJJbm1LS2pXUldFbWJRdVcrT0RsQkxIN05PcEN4bU0yZUx5Rmp1WXFw?= =?utf-8?B?ellHcDgzeVJBdmdQT3RDb2c3N2tCYjloWmU0ZU02NGoxSkRtWkovOGhVR1ZJ?= =?utf-8?B?ZjZHL2l5K1RsdEJkdzFEN1hCVms3SnJEQThsTm42WWZVL1FxUFYrUFNsVU1W?= =?utf-8?B?MTRMREpuZ3gwOFBYZWtiWmEzV0dnd3NoNWs5WFlCZ2JmU3RpdFRkQjlYamVw?= =?utf-8?B?QU9PcFB6Uy9VUExlOG01QUtNKzNxWE1WanhJUlNxSjVmTGxXaXZBcjVLOGVj?= =?utf-8?B?RW55WU4wb3duc3A1U2FRMzlJeXM0Ujlwa0graWpSTlBYLzBpeHA3ZUdPdnJz?= =?utf-8?B?ZVdTNUN6RDRJUHZYdlUwNUcxd1VxZFA1VnNzT0J5WEFZTU9nbFhwRzVGSno0?= =?utf-8?B?RTlGQnhnV08weHluL0ljNzNNM1lSV2xPdnlZVGlCRmNPT3pkUWJ1elI0ajlY?= =?utf-8?B?WS82dEdOMUNnTFhGNi9mSSsyM0lFVmQzaGZYMTRxTVlLWnhscm52bVdnSGh3?= =?utf-8?B?NVd2MTZnYy9wdGFUOVdOaWNJNy9od2QyODRoV3JFT1hGb2pZQy9lcU41clpG?= =?utf-8?B?NVVxMmljeXkxb3VjSmRUdE94SWhTdXVFSVR0QmJSNXJIZVNYd2tBUnpld1FU?= =?utf-8?B?K0s4eHBEQi9pQmsrTGUvNzJzbVAzYTRNWHFYLy9EbnVMV0xTMzdRQnd2eUt0?= =?utf-8?B?OWVEZUFGY1hIc2ttajN3dkcrU2QzaXlvL1d5eVQzRG96VFBJbFRqZmt4N3pS?= =?utf-8?B?Y01UNTZpUWo4dTluUlhHUDZFZ2ZXdTA1aGFzdW5TdEtITlNTWUtnMVN1QkJl?= =?utf-8?B?YlVVcHJKQ3AyakxabE1hemFYMXdLY1l4RFcxZjVzS1hoeVZiblhqTy9aMHpr?= =?utf-8?B?YUQ3MVJwbGlnVUtlOFpuUDE3V1pyWEltSkM3RkdTdW8ySmtxNlkwVzVsUGNs?= =?utf-8?B?dWZsMUhYdUg4cGJsa3VjWHA1MDhTWU1VbElQejFXamtkMVJvemlETmxQUWt5?= =?utf-8?B?WEsycWJkN2Q1bjRad2VwY2o4NEd5OEpkNFg3SjFhZWpNK3M2aWdaM0ZwWDFW?= =?utf-8?B?YU1sNTEvc1Z1TzhpanpqUG1nZlYzNDB2SjFySTMxM3RjVFJNalozMmtkRXYr?= =?utf-8?B?MWJXWWI3TVNvUWIzVkRWNE5vWjk1aWNTRG1SYXNyd3YzL2dPdTB2bmd2Y1VR?= =?utf-8?B?dGxQOEpBdlFNZERLK2ZzWG02b2dCK3VQMW9sSEt2dGFQamRNaGFHendlTnZZ?= =?utf-8?B?a093OHE0MDZNb2pVUHFRV1lNeFFwUGlNMW9oUDA4aHJOR3FGVmJ0L0xRam56?= =?utf-8?B?RFlZYWF4UTkvS0F0UHJMbzBVem41SmlwT1dkYWRuY0JCdFMvKzNycExiZms5?= =?utf-8?B?VXdFdjdBY1doZXJrNnhUdHZLTGx1L2ZsWmxuVE1KVFY0VzlnUXFGTTdrYzRN?= =?utf-8?B?Zk9BMUNHeHVjOFVUa2FveEhoK3FFNm1wdklad211clU1UTNKd0Nad3RVYlhJ?= =?utf-8?B?RzF2a3pwai9GSmJsNHdMWUhOaVgwbS94YVNnTmc3Tzg2QjAwclR4QUdXam9h?= =?utf-8?B?L2M5KzlRcXdCdExVRVpGNWV6MWZoQm5CQVNncWs5ZVR6dWpHUmV0M2ovUmor?= =?utf-8?B?bVdlVmhUc0RBaTNDUzBGVGcyMmtPb2UwWjg3d0swc2tRK04rOTdYQUlsajRi?= =?utf-8?B?RmZUSDJEdUlCemJYWmxVandQQmJQOGs0SUpid1dKTnRNaDNSaGZOeXNLUWhH?= =?utf-8?B?akc3MDhlTndsZ2dIdit1TXJnS091ZDd5SWNSbHhReUNOQWpzdU4yZHFOUVdX?= =?utf-8?B?T2c9PQ==?= Content-ID: <5BEF480D3AD7B74BBC3D1A4C04B0EAF1@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB5566.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e7b1633-3ecc-4fd8-07c5-08dc11003c03 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2024 10:46:28.4209 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LV8AsB7R/hyl0y29rzVUWVVzI0oXxd8S7AVZak4gXmxba18Au0DxgNjNBA+5YZJWu8pbpWuNBkjRI6K4GPv2rw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR03MB8843 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240109_024713_081527_DA4AD323 X-CRM114-Status: GOOD ( 19.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2023-12-07 at 09:18 +0100, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 07/12/2023 06:20, Zhi Mao wrote: > > Add a V4L2 sub-device driver for Galaxycore GC08A3 image sensor. > > > > Reviewed-By: yunkec@chromium.org > > I don't see review given here: > > https://lore.kernel.org/linux-media/20231123115104.32094-1-zhi.mao@mediatek.com/ > > This does not look like real review. Where was it performed? How > thorough was it? How many review iterations did it include? Why > there > is no name but anonymous review? > [mtk]: Sorry, I removed this "Reviewed-By:" messge. please review patch:v3 > > > > Signed-off-by: Zhi Mao > > --- > > drivers/media/i2c/Kconfig | 14 + > > drivers/media/i2c/Makefile | 1 + > > drivers/media/i2c/gc08a3.c | 1888 > ++++++++++++++++++++++++++++++++++++ > > 3 files changed, 1903 insertions(+) > > create mode 100644 drivers/media/i2c/gc08a3.c > > > > ... > > > +static inline struct gc08a3 *to_gc08a3(struct v4l2_subdev *sd) > > +{ > > +return container_of(sd, struct gc08a3, sd); > > +} > > + > > +static int gc08a3_power_on(struct device *dev) > > +{ > > +struct i2c_client *client = to_i2c_client(dev); > > +struct v4l2_subdev *sd = i2c_get_clientdata(client); > > +struct gc08a3 *gc08a3 = to_gc08a3(sd); > > +int ret; > > + > > +gpiod_set_value_cansleep(gc08a3->enable_gpio, 0); > > Why do you put make enable GPIO low? That's not how enable GPIO is > supposed to work... > [mtk]: fixed in patch:v3 > > +usleep_range(GC08A3_MIN_SLEEP_US, GC08A3_MAX_SLEEP_US); > > + > > +ret = regulator_bulk_enable(GC08A3_NUM_SUPPLIES, gc08a3- > >supplies); > > +if (ret < 0) { > > +dev_err(gc08a3->dev, "failed to enable regulators: %d\n", ret); > > +return ret; > > +} > > + > > +ret = clk_prepare_enable(gc08a3->xclk); > > +if (ret < 0) { > > +regulator_bulk_disable(GC08A3_NUM_SUPPLIES, gc08a3->supplies); > > +dev_err(gc08a3->dev, "clk prepare enable failed\n"); > > +return ret; > > +} > > + > > +usleep_range(GC08A3_MIN_SLEEP_US, GC08A3_MAX_SLEEP_US); > > + > > +gpiod_set_value_cansleep(gc08a3->enable_gpio, 1); > > +usleep_range(GC08A3_MIN_SLEEP_US, GC08A3_MAX_SLEEP_US); > > + > > +return 0; > > +} > > + > > +static int gc08a3_power_off(struct device *dev) > > +{ > > +struct i2c_client *client = to_i2c_client(dev); > > +struct v4l2_subdev *sd = i2c_get_clientdata(client); > > +struct gc08a3 *gc08a3 = to_gc08a3(sd); > > + > > +gpiod_set_value_cansleep(gc08a3->enable_gpio, 0); > > How making enable GPIO low is related to power off? Enable means you > turn on some feature, not shutdown. Look at common GPIO consumer > bindings in the kernel. > [mtk]:Here, we rename it to "reset-pin", according to sensor power off sequence in sepc, we should pull low this pin. > > ... > > > +static int gc08a3_probe(struct i2c_client *client) > > +{ > > +struct device *dev = &client->dev; > > +struct gc08a3 *gc08a3; > > +int ret; > > + > > +ret = gc08a3_parse_fwnode(dev); > > +if (ret) > > +return ret; > > + > > +gc08a3 = devm_kzalloc(dev, sizeof(*gc08a3), GFP_KERNEL); > > +if (!gc08a3) > > +return -ENOMEM; > > + > > +gc08a3->dev = dev; > > + > > +gc08a3->xclk = devm_clk_get(dev, NULL); > > +if (IS_ERR(gc08a3->xclk)) > > +return dev_err_probe(dev, PTR_ERR(gc08a3->xclk), > > + "failed to get xclk\n"); > > Misaligned indentation > [mtk]: fixed in patch:v3 > > + > > +ret = clk_set_rate(gc08a3->xclk, GC08A3_DEFAULT_CLK_FREQ); > > +if (ret) > > +return dev_err_probe(dev, ret, > > + "failed to set xclk frequency\n"); > > Misaligned indentation [mtk]: fixed in patch:v3 > > > + > > +ret = gc08a3_get_regulators(dev, gc08a3); > > +if (ret < 0) > > +return dev_err_probe(dev, ret, > > + "failed to get regulators\n"); > > Misaligned indentation > [mtk]: fixed in patch:v3 > > + > > +gc08a3->enable_gpio = devm_gpiod_get(dev, "enable", > GPIOD_OUT_LOW); > > +if (IS_ERR(gc08a3->enable_gpio)) > > +return dev_err_probe(dev, PTR_ERR(gc08a3->enable_gpio), > > + "failed to get gpio\n"); > > Misaligned indentation... probably entire code is misaligned. > [mtk]: fixed in patch:v3 > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel