Re: [PATCH 1/2] media: i2c: Add GC08A3 image sensor driver

Conor Dooley
2023-12-07T17:45:18Z

[-- Attachment #1.1: Type: text/plain, Size: 1076 bytes --]

On Thu, Dec 07, 2023 at 01:30:35PM +0100, Krzysztof Kozlowski wrote:
> On 07/12/2023 12:34, Sakari Ailus wrote:
> >> + ret = gc08a3_parse_fwnode(dev);
> >> + if (ret)
> >> + return ret;
> >> +
> >> + gc08a3 = devm_kzalloc(dev, sizeof(*gc08a3), GFP_KERNEL);
> >> + if (!gc08a3)
> >> + return -ENOMEM;
> >> +
> >> + gc08a3->dev = dev;
> >> +
> >> + gc08a3->xclk = devm_clk_get(dev, NULL);
> >> + if (IS_ERR(gc08a3->xclk))
> >> + return dev_err_probe(dev, PTR_ERR(gc08a3->xclk),
> >> + "failed to get xclk\n");
> >> +
> >> + ret = clk_set_rate(gc08a3->xclk, GC08A3_DEFAULT_CLK_FREQ);
> >
> > Please see:
> > <URL:https://hverkuil.home.xs4all.nl/spec/driver-api/camera-sensor.html#devicetree>.
>
>
> Oh, that's cool it was documented!
>
> The canonical link would be:
> https://www.kernel.org/doc/html/latest/driver-api/media/camera-sensor.html#devicetree

I believe this is that answer to the "why are these needed" that I asked
on the previous version and never got a response to. Instead, they were
just removed from the binding etc.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]