From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35BECC433EF for ; Tue, 22 Mar 2022 18:38:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R7asbk81OW41B7xWtRpzb+AJjQHg0wqhU29UY421c5o=; b=wF4QR+SddzIqQP I7U2AqKjPWcFm8UrVzSes/Z0tEzIZKpjfZN8u6swf598gyj3ym7Mt+hoSUliLmTZXSrp/M3jzTWhU tXPPDUISTfMg4e4kt7fmKXLhX3PbBYnLxtBQhjCIhnHN6iU1Z2s3SntWUyWWUF9/GVB2DmOyt2sMG +aROmncIyJtoy3C3/Y7mdRrckPsWal9lhAoIm1D4QLqoqHgJ0mcDkbJBLG0MIswuOvVbVGm9jFDrb yiIQykShqy0LIp/1DQiUf186OxamTKP+KYBS/JgQF+j6bnklAe3tpN/hJI0BXRyzl083qJhkf4m+S eobHk6l3V7vYjY7qOKDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWjNE-00BtDl-G9; Tue, 22 Mar 2022 18:36:52 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nWjMx-00Bt4T-EK for linux-arm-kernel@lists.infradead.org; Tue, 22 Mar 2022 18:36:38 +0000 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 2EA843F950 for ; Tue, 22 Mar 2022 18:36:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1647974190; bh=5jtpXxEom/a/jiH/sFwvBmFkIoAoceZfaQ8rDmnOzv8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P77Zx83eCkbeGAI7Xa56eWSHvVAR+qUsvcY7Q7b/SQqbisA5NrvS2oQwFdqNoF9w6 1OSeGzVzUsPSjnBWwvHTh51SATZ3O0OF6/QoPR/LPTr9YrhEheMxsfQsJHUWdAIqRA 0hYL9waibdfpX1tpr/MMIqx6Yh4nNpJ0NRi9mrA9uMzlQBUOA+Zcd2G1rYhutOjOUp Z3Y0SqbHjvR9HAXevtlpAZY7YfnQV5naVc9hhS9MGqrprivyO22eCesl/sl6ao56t1 6u+iFXwpBhtd0Z75soB31D1lPAeNRHwRErT+faNA6GtIF+ldmV1hV/Dk5TbX6/YWjX YBifecyXscntg== Received: by mail-ed1-f71.google.com with SMTP id z22-20020a50cd16000000b0041960ea8555so1067258edi.2 for ; Tue, 22 Mar 2022 11:36:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=5jtpXxEom/a/jiH/sFwvBmFkIoAoceZfaQ8rDmnOzv8=; b=66EsdUTN4Uxrryh6bEb2nQR8MEqMHKGbHuYdoYSdbmV97K2dH7D7K2BX/WTGyFr6nB +T5SdOfslB6EHa0x9HnrTTTsSWJsXWn1GC/IAyQNF+K+n4mY45oleuIKJ6L2TwkwAnmM njuyUasveeqEvA/2BHUF18IiziEsREg6w6WK82ZXpUi7Xvlv40KJ5X987uhrcA/4uQHq RPfgVf200q51Cb4PfOd6h5hauAGBexjEhVI1Eil1gGBidLRFSx9zciCWBsXX7xVoAtGD h9iHnPxtbArbdV9v/6FcQjrSygNiFBNHn5PuSKQYkJBw1mCNNN4yYopTj6hlypNO/Xgc cODw== X-Gm-Message-State: AOAM532tdhrRkTRAOV4PlvkXQ6xzwsYNLq8DJJ+0iujTd5XgGZJaOhLo rPkptP5F3qGDDY+4SWSu34O05mcm/dQDCosWzPVeRD8ri4nYKA9FZPzBHIl2sC7ae+b3vJwVFfJ L/xubhmuxchifCg8+TTtLRqs7CGtfqHi+x92c40PET4vwuoVAU0pl X-Received: by 2002:a05:6402:1941:b0:413:2555:53e3 with SMTP id f1-20020a056402194100b00413255553e3mr30164493edz.164.1647974184172; Tue, 22 Mar 2022 11:36:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXjJuzBLH9hbRDSjsXFrbLCVkaIICKYGv+IQ5EfXGkXfhv1U2vMFYP/O//lEDRT2Fv/Gfc1w== X-Received: by 2002:a05:6402:1941:b0:413:2555:53e3 with SMTP id f1-20020a056402194100b00413255553e3mr30164440edz.164.1647974183906; Tue, 22 Mar 2022 11:36:23 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id d4-20020a1709067a0400b006d6e3ca9f71sm8816466ejo.198.2022.03.22.11.36.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Mar 2022 11:36:23 -0700 (PDT) Message-ID: Date: Tue, 22 Mar 2022 19:36:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 00/18] dt-bindings: irqchip: include generic schema Content-Language: en-US To: Rob Herring References: <20220317115542.450032-1-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220322_113635_645356_6263B239 X-CRM114-Status: GOOD ( 19.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Bert Vermeulen , Geert Uytterhoeven , Neil Armstrong , Lokesh Vutla , Paul Walmsley , Jiaxun Yang , Cristian Ciocaltea , Paul Cercueil , Daniel Palmer , Sagar Kadam , linux-riscv@lists.infradead.org, Mark-PK Tsai , Paul Burton , Marc Zyngier , openbmc@lists.ozlabs.org, John Crispin , Birger Koblitz , linux-oxnas@groups.io, devicetree@vger.kernel.org, Jason Cooper , Manivannan Sadhasivam , linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org, =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= , Krzysztof Halasa , Santosh Shilimkar , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Tero Kristo , Linus Walleij , Joakim Zhang , Claudiu Beznea , Dinh Nguyen , Michael Walle , Palmer Dabbelt , Krzysztof Kozlowski , Imre Kaloz , =?UTF-8?Q?Andreas_F=c3=a4rber?= , Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/03/2022 19:53, Rob Herring wrote: > On Thu, Mar 17, 2022 at 12:55:24PM +0100, Krzysztof Kozlowski wrote: >> Hi, >> >> The DTS patches can be picked up independently. >> >> Best regards, >> Krzysztof >> >> Krzysztof Kozlowski (18): >> ARM: dts: nspire: use lower case hex addresses in node unit addresses >> ARM: dts: ox820: align interrupt controller node name with dtschema >> ARM: dts: socfpga: align interrupt controller node name with dtschema >> dt-bindings: irqchip: actions,owl-sirq: include generic schema >> dt-bindings: irqchip: fsl: include generic schema >> dt-bindings: irqchip: ingenic: include generic schema >> dt-bindings: irqchip: intel,ixp4xx: include generic schema >> dt-bindings: irqchip: kontron,sl28cpld: include generic schema >> dt-bindings: irqchip: loongson: include generic schema >> dt-bindings: irqchip: microchip,eic: include generic schema >> dt-bindings: irqchip: mrvl,intc: include generic schema >> dt-bindings: irqchip: mstar,mst-intc: include generic schema >> dt-bindings: irqchip: mti,gic: include generic schema >> dt-bindings: irqchip: nuvoton,wpcm450-aic: include generic schema >> dt-bindings: irqchip: realtek,rtl-intc: include generic schema >> dt-bindings: irqchip: renesas: include generic schema >> dt-bindings: irqchip: sifive: include generic schema >> dt-bindings: irqchip: ti: include generic schema > > I'm somewhat on the fence about these. Originally only devices with a > bus or child nodes included a common schema. For 'simple' providers > with mainly a '#-cells' property, we had to set the > constraints on the number of cells anyways, so referencing another > schema doesn't save anything. It is nice to declare the 'class' of the > device though. > > It makes the schema be applied twice (if the node name matches). That's > not all bad because it finds cases of wrong node name. However, > sometimes we have devices which are multiple providers and can't set the > node name. So those can't reference interrupt-controller.yaml. Indeed there were cases of MSI and interrupt controller. > > It also means that 'interrupt-map' for example is now valid. That could > be fixed by splitting 'interrupt-map' related properties to its own > schema. Yes, that's a side effect. Maybe my series should be abandoned. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel