From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4223FC3A59B for ; Fri, 30 Aug 2019 14:17:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CB862341B for ; Fri, 30 Aug 2019 14:17:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EO0kB0jZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CB862341B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FOk6pTCbog0h42Q9KUUAOxgtJhCiS0opjfQNs1rmpH8=; b=EO0kB0jZ9b2juC FTZ6y+m0jXj9E6f1GkrCLlLnKd+8JC7TUUohRxgJdeExjV7mZarSaq2LJnl3PuC+Apkih7kUoOo4V D/jyM1WtmnE0yocaGoW4hRMjERQ0LQ5b560OnW9TeNx+G7MILM9gotOzRhW6mTOsBrxgK3l5qlhpo k24yoSnKRrvAUalepuMSXUAYU1voCdNjrvIuUzuvKUcCaqXkDF8EFtuE8PNIhRgbOWU4z/duqoJiH qtiMDzE7ToH+bc8P+NYYk7zGr/Lf02KOdhgyx2IwbzVcujYr0mlW/64qzmTqv5gpzMhengldaY1Du ++acfI+5nlM+JvzMeIDg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i3hhv-0004Kx-8W; Fri, 30 Aug 2019 14:16:55 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i3hhs-0004KY-QW for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2019 14:16:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4BC1B344; Fri, 30 Aug 2019 07:16:52 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3B4383F703; Fri, 30 Aug 2019 07:16:49 -0700 (PDT) Subject: Re: [PATCH v2 5/8] lib: vdso: Remove checks on return value for 32 bit vDSO From: Vincenzo Frascino To: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20190830135902.20861-1-vincenzo.frascino@arm.com> <20190830135902.20861-6-vincenzo.frascino@arm.com> Message-ID: Date: Fri, 30 Aug 2019 15:16:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190830135902.20861-6-vincenzo.frascino@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190830_071652_906185_FF75FB25 X-CRM114-Status: GOOD ( 17.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, 0x7f454c46@gmail.com, salyzyn@android.com, paul.burton@mips.com, luto@kernel.org, tglx@linutronix.de, will@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/08/2019 14:58, Vincenzo Frascino wrote: > Since all the architectures that support the generic vDSO library have > been converted to support the 32 bit fallbacks it is not required > anymore to check the return value of __cvdso_clock_get*time32_common() > before updating the old_timespec fields. > > Remove the related checks from the generic vdso library. > > Cc: Thomas Gleixner > CC: Andy Lutomirski Forgot to add to this patch: Suggested-by: Andy Lutomirski > References: c60a32ea4f45 ("lib/vdso/32: Provide legacy syscall fallbacks") > Signed-off-by: Vincenzo Frascino > --- > lib/vdso/gettimeofday.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/lib/vdso/gettimeofday.c b/lib/vdso/gettimeofday.c > index 2c4b311c226d..d5bc16748f81 100644 > --- a/lib/vdso/gettimeofday.c > +++ b/lib/vdso/gettimeofday.c > @@ -129,10 +129,10 @@ __cvdso_clock_gettime32(clockid_t clock, struct old_timespec32 *res) > if (unlikely(ret)) > return clock_gettime32_fallback(clock, res); > > - if (likely(!ret)) { > - res->tv_sec = ts.tv_sec; > - res->tv_nsec = ts.tv_nsec; > - } > + /* For ret == 0 */ > + res->tv_sec = ts.tv_sec; > + res->tv_nsec = ts.tv_nsec; > + > return ret; > } > #endif /* BUILD_VDSO32 */ > @@ -238,10 +238,10 @@ __cvdso_clock_getres_time32(clockid_t clock, struct old_timespec32 *res) > if (unlikely(ret)) > return clock_getres32_fallback(clock, res); > > - if (likely(!ret)) { > - res->tv_sec = ts.tv_sec; > - res->tv_nsec = ts.tv_nsec; > - } > + /* For ret == 0 */ > + res->tv_sec = ts.tv_sec; > + res->tv_nsec = ts.tv_nsec; > + > return ret; > } > #endif /* BUILD_VDSO32 */ > -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel