From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2F22C388F9 for ; Tue, 27 Oct 2020 14:56:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3212322264 for ; Tue, 27 Oct 2020 14:56:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="w+zP9aAk"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="y/8MoCDm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3212322264 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aThRAgXU7foZuPVxkJOlCsYBf2/lqIcO5zx75ipC32k=; b=w+zP9aAkHVP4fMFwv1aVdG6VF xsm6kSwV0cD8zmRcXQSnKLXLdSK1utDcMR2+019Vv76+AoqJBym2BcL0Y4ADNwT5Vtv42k1jlWBvf sV1uAoibx9Qpr9OXc/Ci0UqaH5UHa1+sFP/EYDijf40+nK5Mu6E7P0p1k/xrL7M2sQPl8km+QgQB6 VfyJvjiRwdbTxQHpGsW4omLVDIogIlz4NpjcMdQ0cPDlEYd4F5vtXF5bk04NydC+n9OG/XWicAThS pr+Tprs6Qsdj5k8VxlVmR61hRvMYe3Wvx7dphTzTQAezrg+GvATM6LPvRo5hfwehJWe07dSbyAJlm jc4ZMXnTg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXQNu-0004IB-Iw; Tue, 27 Oct 2020 14:55:38 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kXQNs-0004Hd-30 for linux-arm-kernel@lists.infradead.org; Tue, 27 Oct 2020 14:55:37 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 09REtY8K103316; Tue, 27 Oct 2020 09:55:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1603810534; bh=GETjUaNBxIQa48fzWEmCGlAA4gPzYeNK+MzMSCrBzcc=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=y/8MoCDm4Ky7HOFZa7NpHpgwdk7+6e/U3IhyG/AwfevNABzLfm+8RGXTws6Ji3eZW 5F2T2QRBH5/uB22Mc2q5C9jktJUwl3lYBqkvcJa3MukgwXoJCftkhfpIY9XCJw1uus hb75HRF1bXkcznFJ7rO/yGSSrWWtZq1bAqFfMHDM= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 09REtY38024543 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 27 Oct 2020 09:55:34 -0500 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 27 Oct 2020 09:55:34 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 27 Oct 2020 09:55:34 -0500 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 09REtWjj119312; Tue, 27 Oct 2020 09:55:32 -0500 Subject: Re: [PATCH 4/4] arm64: dts: ti: am654-base-board: fix clock node name To: Nishanth Menon References: <20201027104132.105485-1-tomi.valkeinen@ti.com> <20201027104132.105485-5-tomi.valkeinen@ti.com> <20201027123941.tgkqxx4rk56sl5tf@crafty> From: Tomi Valkeinen Message-ID: Date: Tue, 27 Oct 2020 16:55:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201027123941.tgkqxx4rk56sl5tf@crafty> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201027_105536_256856_DCE01F1D X-CRM114-Status: GOOD ( 22.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tero Kristo , devicetree@vger.kernel.org, Kishon Vijay Abraham I , linux-arm-kernel@lists.infradead.org, Swapnil Jakhade Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/10/2020 14:39, Nishanth Menon wrote: > On 12:41-20201027, Tomi Valkeinen wrote: >> The fixed clock for OV5640 is named 'clock' which is a very generic name >> and easily leads to conflicts. I encountered this with a similarly named >> fixed-clock node in k3-am654-evm-tc358876.dtso, which then overrode the >> OV5640 fixed clock, causing OV5640 not to work when tc358876 overlay had >> been loaded. >> >> Rename the node to 'fixed-clock-ov5640'. >> >> Signed-off-by: Tomi Valkeinen >> --- >> arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts >> index d12dd89f3405..6801dbddeac5 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts >> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts >> @@ -55,7 +55,7 @@ sw6 { >> }; >> }; >> >> - clk_ov5640_fixed: clock { >> + clk_ov5640_fixed: fixed-clock-ov5640 { >> compatible = "fixed-clock"; >> #clock-cells = <0>; >> clock-frequency = <24000000>; >> -- >> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. >> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >> > > I think you could post this independently as well. > > https://github.com/devicetree-org/devicetree-specification/blob/v0.3/source/devicetree-basics.rst#generic-names-recommendation > > There is a strong desire to use standard node names and > clock is recommended. even though there are tons of fixed-clock > compatible clocks in the kernel today, as of v5.10-rc1: > > $ git grep fixed-clock- arch/arm64/boot/dts/ > $ git grep fixed-clock- arch/arm/boot/dts/ > > As a node name is not used. Do you want to see how other > platforms are trying to resolve similar issues? There doesn't seem to be a standard: $ git grep -B2 fixed-clock arch/arm/boot/dts/ The node names are just about everything. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel