From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8855C7EE2A for ; Fri, 27 Jun 2025 20:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:Message-ID:Mime-Version:In-Reply-To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=UQtNA0hS1YdwM8TLVBpaF+KBYsznLZdF9AooNXo/LEo=; b=RUqR/a8LlpqiUw kWvUBmU+HylY/DLz8s4Npz2FZ2fb+/A03BlPrd2IfEjN963naAu2ltyfNk6sbetoqlNJpSJJzInoh 8CgYVX6pNaEgJPE0Lw8jKRtWaDvBXV2A6JxBkB19sYeYxf6RQAW66kSrk4buteHgvqNcPQ6q5WRrf D9tg++cWHd7TLo2rZ4FPWPDfYN+Fzg8/RdQWVUGG0A6OYUUB7g3+bB9rhkbeb1ZmZ+1i/670D7x5s 2TJHOh/hwQsa92lGqfLQ/TYQP8B7y0kRiXJiVI3bs2GF//Cd8LDyJmv7VGxM92e2NW7sxiYvZcvHB JOIqlcFrxyrG6UzgZZbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uVG1i-0000000FnP7-3Z2b; Fri, 27 Jun 2025 20:50:26 +0000 Received: from mail-il1-x14a.google.com ([2607:f8b0:4864:20::14a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uVFxK-0000000Fmfg-18ZS for linux-arm-kernel@lists.infradead.org; Fri, 27 Jun 2025 20:45:55 +0000 Received: by mail-il1-x14a.google.com with SMTP id e9e14a558f8ab-3df2d0b7c7eso3026475ab.2 for ; Fri, 27 Jun 2025 13:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1751057153; x=1751661953; darn=lists.infradead.org; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date:from:to :cc:subject:date:message-id:reply-to; bh=UQtNA0hS1YdwM8TLVBpaF+KBYsznLZdF9AooNXo/LEo=; b=3R72+keZ9/+d0DeYtjP4B7/9OZp2aVFzCixy6BzuAedH1A19HW8DRhA3LNwSb+fmI9 IJCO7Sc2YHJiKnKP7zCpUrXMFMR+6Dpf40WVnHaLllCLMKSpBK7yR1XyQhJdgW7ji45C bHQPlvA6ixuA8j/pymntbAKdQEul6jprfsCZD816o0F1RijosempvPnoXmln6SYCowMd W/OnGNcUZyjw1rVnvcKLOfK32cwnjTiOUh9dGHkH/oAcMBtiBNhogm75pA2Rl9FRQt4H SjSSYGKxR30BmFm9BrYOTzvsNlxtEekjJXoXwmKBEi+ff/fYQQbQdHuDTG738M2Iu4GT hq9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751057153; x=1751661953; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UQtNA0hS1YdwM8TLVBpaF+KBYsznLZdF9AooNXo/LEo=; b=DzIPkWzZI9GsM072vF42w6MLQ+cFaQVpDjn4QCSFwIpsutvRauHMF+nehm2dZyKZDR 3pqudxRdbJL8XUvnMrk1LxuXkPygp4JbnmJXByp/V4kQQ2eyqwdBTFld1lEMU3cG8VGJ j6OV2HH4rXGd9TR5l9fNSCQeLEu/7YpY1l7QfoAyfE7uGhtNrZZaaYENb0IQopmd/nvL ETCDA4sEy7qtSEbg2X+uVRPe2YDS6PBKdEzagzKNY4/KsOAw1P2ta8UanacnSFxG7Lpk 7uQi9udaJTJsZd1J8naaoPta7E/wfnf5X427Ltqh8uZEf9mK4s84fgStwi9N7nEluZ60 IGjg== X-Forwarded-Encrypted: i=1; AJvYcCU0ipldaKkWwBhjmYIvUZ6WxUkM7+pqNkrw33Zqi9Y0r5s2ybcMYZjVvPIparwCdqsBdUrghLMc522BrSiLXMus@lists.infradead.org X-Gm-Message-State: AOJu0YwjS562P9VqwqkhFLYhUJn+RQ7nG0PmmDsCItKAsQmqbmTcfc05 9USrEXu2F9t5dlh+cX0aDuyZRNJoceXKm4My8qwp7RjnrL6UF7vdQs/wd6uUXKMtZ6fl/Kp8MVL t3tiaXbJ9zgqIYtv1SDg/P2f60g== X-Google-Smtp-Source: AGHT+IG8ubvH3kPztAj1ao94LgGUW1XY/gBYCn7CffcpcGKKkMXZJW+TsDn1nh7iOVmLnOgs9jfVsOn7IAe78nE95w== X-Received: from ilbec16.prod.google.com ([2002:a05:6e02:4710:b0:3dd:77db:e2f7]) (user=coltonlewis job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6e02:12e8:b0:3df:154d:aa60 with SMTP id e9e14a558f8ab-3df4acf7b61mr59890785ab.22.1751057152711; Fri, 27 Jun 2025 13:45:52 -0700 (PDT) Date: Fri, 27 Jun 2025 20:45:51 +0000 In-Reply-To: <86sejlb9ba.wl-maz@kernel.org> (message from Marc Zyngier on Fri, 27 Jun 2025 14:31:05 +0100) Mime-Version: 1.0 Message-ID: Subject: Re: [PATCH v3 03/22] KVM: arm64: Define PMI{CNTR,FILTR}_EL0 as undef_access From: Colton Lewis To: Marc Zyngier Cc: kvm@vger.kernel.org, pbonzini@redhat.com, corbet@lwn.net, linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, mizhang@google.com, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, mark.rutland@arm.com, shuah@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250627_134554_307587_87C7E884 X-CRM114-Status: GOOD ( 13.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc. Thanks for the review. Marc Zyngier writes: > On Thu, 26 Jun 2025 21:04:39 +0100, > Colton Lewis wrote: >> Because KVM isn't fully prepared to support these yet even though the >> host PMUv3 driver does, define them as undef_access for now. >> Signed-off-by: Colton Lewis >> --- >> arch/arm64/kvm/sys_regs.c | 3 +++ >> 1 file changed, 3 insertions(+) >> diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c >> index 76c2f0da821f..99fdbe174202 100644 >> --- a/arch/arm64/kvm/sys_regs.c >> +++ b/arch/arm64/kvm/sys_regs.c >> @@ -3092,6 +3092,9 @@ static const struct sys_reg_desc sys_reg_descs[] = >> { >> { SYS_DESC(SYS_SVCR), undef_access, reset_val, SVCR, 0, .visibility = >> sme_visibility }, >> { SYS_DESC(SYS_FPMR), undef_access, reset_val, FPMR, 0, .visibility = >> fp8_visibility }, >> + { SYS_DESC(SYS_PMICNTR_EL0), undef_access }, > $ jq -r --arg FEAT "FEAT_PMUv3_ICNTR" -f ./dumpfeat.jq Features.json > (FEAT_PMUv3_ICNTR --> v8Ap8) > (FEAT_PMUv3_ICNTR --> FEAT_PMUv3p9) > ((FEAT_PMUv3_ICNTR && FEAT_AA64EL2) --> FEAT_FGT2) > If you have FEAT_PMUv3_ICNTR, then you have FEAT_FGT2. If you have > FEAT_FGT2, then we already trap and UNDEF PMICNTR_EL0 without any > further handling since 4bc0fe0898406 ("KVM: arm64: Add sanitisation > for FEAT_FGT2 registers"). >> + { SYS_DESC(SYS_PMICFILTR_EL0), undef_access }, > Same thing. >> + >> { PMU_SYS_REG(PMCR_EL0), .access = access_pmcr, .reset = reset_pmcr, >> .reg = PMCR_EL0, .get_user = get_pmcr, .set_user = set_pmcr }, >> { PMU_SYS_REG(PMCNTENSET_EL0), > So none of this is actually required. Thanks for the context. I'll take this patch out.