[PATCH] ARM: LPC32XX: Update PHY3250 MTD partition info

[PATCH] ARM: LPC32XX: Update PHY3250 MTD partition info

[Ben Gardiner]

Adding the two other partitions of the phycore3250's nand flash:
u-boot and the u-boot environment partitions. The former can be useful
if you are feeling adventurous and would like to upgrade u-boot. The
later is very useful for userspace utilities like fw_setenv which can
be used to modify the bootargs for the next reboot or insert many other
useful scripts.

In addition, adding these partitions brings the mtdblock numbers back
to what they were with the 2.6.27.8 release of the linux kernel shipped
with the phycore3250 evm.

Signed-off-by: Ben Gardiner <bengardiner@nanometrics.ca>
---
 arch/arm/mach-lpc32xx/phy3250.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-lpc32xx/phy3250.c b/arch/arm/mach-lpc32xx/phy3250.c
index b908d17..2672b63 100644
--- a/arch/arm/mach-lpc32xx/phy3250.c
+++ b/arch/arm/mach-lpc32xx/phy3250.c
@@ -345,6 +345,16 @@ static int nandwp_enable(int enable)
 #define BLK_SIZE (512 * 32)
 static struct mtd_partition __initdata phy3250_nand_partition[] = {
 	{
+		.name	= "phy3250-uboot",
+		.offset	= 0,
+		.size	= (BLK_SIZE * 90)
+	},
+	{
+		.name	= "phy3250-ubt-env",
+		.offset	= (BLK_SIZE * 90),
+		.size	= (BLK_SIZE * 10)
+	},
+	{
 		.name	= "phy3250-kernel",
 		.offset	= (BLK_SIZE * 100),
 		.size	= (BLK_SIZE * 256)
-- 
1.6.3.3

[PATCH] ARM: LPC32XX: Update PHY3250 MTD partition info

[Kevin Wells]

 
Hi Ben,

Thanks for posting these. The MTD support is currently
only available on our GIT server, although we plan on
getting the MTD patches into the mtd subtree soon..

> Adding the two other partitions of the phycore3250's nand flash:
> u-boot and the u-boot environment partitions. The former can be useful
> if you are feeling adventurous and would like to upgrade u-boot. The
> later is very useful for userspace utilities like fw_setenv which can
> be used to modify the bootargs for the next reboot or insert many other
> useful scripts.
> 
> In addition, adding these partitions brings the mtdblock numbers back
> to what they were with the 2.6.27.8 release of the linux kernel shipped
> with the phycore3250 evm.
> 
> Signed-off-by: Ben Gardiner <bengardiner@nanometrics.ca>
> ---
>  arch/arm/mach-lpc32xx/phy3250.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-lpc32xx/phy3250.c b/arch/arm/mach-
> lpc32xx/phy3250.c
> index b908d17..2672b63 100644
> --- a/arch/arm/mach-lpc32xx/phy3250.c
> +++ b/arch/arm/mach-lpc32xx/phy3250.c
> @@ -345,6 +345,16 @@ static int nandwp_enable(int enable)
>  #define BLK_SIZE (512 * 32)
>  static struct mtd_partition __initdata phy3250_nand_partition[] = {
>  	{
> +		.name	= "phy3250-uboot",
> +		.offset	= 0,
> +		.size	= (BLK_SIZE * 90)
> +	},
> +	{
> +		.name	= "phy3250-ubt-env",
> +		.offset	= (BLK_SIZE * 90),
> +		.size	= (BLK_SIZE * 10)
> +	},
> +	{
>  		.name	= "phy3250-kernel",
>  		.offset	= (BLK_SIZE * 100),
>  		.size	= (BLK_SIZE * 256)

This partitioning scheme isn't set it stone yet. We'll look at it
again once we get those patches up for review.

> --
> 1.6.3.3

thanks,
Kevin

[PATCH] ARM: LPC32XX: Update PHY3250 MTD partition info

[H Hartley Sweeten]

On Thursday, April 15, 2010 5:18 PM, Kevin Wells wrote:
> Hi Ben,
>
> Thanks for posting these. The MTD support is currently
> only available on our GIT server, although we plan on
> getting the MTD patches into the mtd subtree soon..
>
>> Adding the two other partitions of the phycore3250's nand flash:
>> u-boot and the u-boot environment partitions. The former can be useful
>> if you are feeling adventurous and would like to upgrade u-boot. The
>> later is very useful for userspace utilities like fw_setenv which can
>> be used to modify the bootargs for the next reboot or insert many other
>> useful scripts.
>> 
>> In addition, adding these partitions brings the mtdblock numbers back
>> to what they were with the 2.6.27.8 release of the linux kernel shipped
>> with the phycore3250 evm.
>> 
>> Signed-off-by: Ben Gardiner <bengardiner@nanometrics.ca>
>> ---
>>  arch/arm/mach-lpc32xx/phy3250.c |   10 ++++++++++
>>  1 files changed, 10 insertions(+), 0 deletions(-)
>> 
>> diff --git a/arch/arm/mach-lpc32xx/phy3250.c b/arch/arm/mach-
>> lpc32xx/phy3250.c
>> index b908d17..2672b63 100644
>> --- a/arch/arm/mach-lpc32xx/phy3250.c
>> +++ b/arch/arm/mach-lpc32xx/phy3250.c
>> @@ -345,6 +345,16 @@ static int nandwp_enable(int enable)
>>  #define BLK_SIZE (512 * 32)
>>  static struct mtd_partition __initdata phy3250_nand_partition[] = {
>>  	{
>> +		.name	= "phy3250-uboot",
>> +		.offset	= 0,
>> +		.size	= (BLK_SIZE * 90)
>> +	},
>> +	{
>> +		.name	= "phy3250-ubt-env",
>> +		.offset	= (BLK_SIZE * 90),
>> +		.size	= (BLK_SIZE * 10)
>> +	},
>> +	{
>>  		.name	= "phy3250-kernel",
>>  		.offset	= (BLK_SIZE * 100),
>>  		.size	= (BLK_SIZE * 256)
>
> This partitioning scheme isn't set it stone yet. We'll look at it
> again once we get those patches up for review.

The last two offsets could just be:

	.offset	= MTDPART_OFS_APPEND,

That way then automatically align to the next block offset.  It's
cleaner and will make changing the partitioning scheme easier.

Regards,
Hartley

[PATCH] ARM: LPC32XX: Update PHY3250 MTD partition info

[Ben Gardiner]

On Thu, Apr 15, 2010 at 8:35 PM, H Hartley Sweeten
<hartleys@visionengravers.com> wrote:
> On Thursday, April 15, 2010 5:18 PM, Kevin Wells wrote:
>> Hi Ben,
>>
>> Thanks for posting these. The MTD support is currently
>> only available on our GIT server, although we plan on
>> getting the MTD patches into the mtd subtree soon..
>> This partitioning scheme isn't set it stone yet. We'll look at it
>> again once we get those patches up for review.

Ok. Please consider including Linux access to the u-boot environment
(at least) and u-boot in the MTD partitions that are set in stone.

> The last two offsets could just be:
>
> ? ? ? ?.offset = MTDPART_OFS_APPEND,
>
> That way then automatically align to the next block offset. ?It's
> cleaner and will make changing the partitioning scheme easier.

Cool. Thanks for the tip, Hartley.

Regards,
Ben Gardiner

-- 
Ben Gardiner
Nanometrics Inc.
+1 (613) 592-6776 x239
http://www.nanometrics.ca