From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75459C433E2 for ; Fri, 4 Sep 2020 19:30:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC648207EA for ; Fri, 4 Sep 2020 19:30:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dxGnTMRN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC648207EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-reply-to:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sjw0kueUBzXkeWD7YSB9SU8sfAGcp6ov2PN7j8P3aOc=; b=dxGnTMRNtm/UxcwgHOqxo3CS0 pjh0HeB/DbSvhY0oeNnFcJWIONwYeBb1s3P2N/kLK0uw1/r2fU1Fv4n3nKqV81qd1Q/31yJGcT/bc MYK5bzqoTfdL0380NT4p/aJnSOdY0DVtJkfSjkDd5o9Lm5YB7RJfz/3WSzdNXYg6+8S1ZDJdAfA+H DPJ/4MMHntF+9L8qm+jwS1+nsdTpRi/agtrO0X/aShpfV4xmDfp24V5IIshkfKS2WRSm+fjkoGevF 5W/++E0dUx/x+5SIzB/y6q8I6mvoTkE6HMTGjt0d79km8rZfNTrU4/cY0PHBtbSJqXUBfOB8yohfZ M6b7NNPDg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEHOM-0006Sc-G3; Fri, 04 Sep 2020 19:28:58 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEHOJ-0006Rw-HX for linux-arm-kernel@lists.infradead.org; Fri, 04 Sep 2020 19:28:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4F6591045; Fri, 4 Sep 2020 12:28:47 -0700 (PDT) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 68F433F68F; Fri, 4 Sep 2020 12:28:46 -0700 (PDT) References: <20200903183206.104838-1-maz@kernel.org> <20200903183206.104838-2-maz@kernel.org> User-agent: mu4e 0.9.17; emacs 26.3 From: Valentin Schneider To: Marc Zyngier Subject: Re: [PATCH v2 1/4] genirq: Walk the irq_data hierarchy when resending an interrupt In-reply-to: <20200903183206.104838-2-maz@kernel.org> Date: Fri, 04 Sep 2020 20:28:38 +0100 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200904_152855_628774_127602FF X-CRM114-Status: GOOD ( 17.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Gleixner , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jason Cooper Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, On 03/09/20 19:32, Marc Zyngier wrote: > On resending an interrupt, we only check the topmost irqchip for > a irq_retrigger callback. However, this callback could be implemented > at a lower level. Use irq_chip_retrigger_hierarchy() in this case. > Rookie wording question here; re-reading this I'm questioning which way is up. >From an irq_data hierarchy PoV, the topmost chip (i.e. last ->parent) should be the root irqchip. However, the irq_desc we get from irq_to_desc() ought to hold the irq_data for the lowermost irqchip in that irq_data hierarchy. Is it that here by "topmost" you instead mean topmost of the irqchip stack on top of the root (IOW furthest away from the root)? > Signed-off-by: Marc Zyngier > --- > kernel/irq/resend.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/kernel/irq/resend.c b/kernel/irq/resend.c > index c48ce19a257f..8ccd32a0cc80 100644 > --- a/kernel/irq/resend.c > +++ b/kernel/irq/resend.c > @@ -86,6 +86,18 @@ static int irq_sw_resend(struct irq_desc *desc) > } > #endif > > +static int try_retrigger(struct irq_desc *desc) > +{ > + if (desc->irq_data.chip->irq_retrigger) > + return desc->irq_data.chip->irq_retrigger(&desc->irq_data); > + > +#ifdef CONFIG_IRQ_DOMAIN_HIERARCHY > + return irq_chip_retrigger_hierarchy(&desc->irq_data); > +#else > + return 0; > +#endif > +} > + > /* > * IRQ resend > * > @@ -113,8 +125,7 @@ int check_irq_resend(struct irq_desc *desc, bool inject) > > desc->istate &= ~IRQS_PENDING; > > - if (!desc->irq_data.chip->irq_retrigger || > - !desc->irq_data.chip->irq_retrigger(&desc->irq_data)) > + if (!try_retrigger(desc)) > err = irq_sw_resend(desc); > > /* If the retrigger was successfull, mark it with the REPLAY bit */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel