From: Valentin Schneider <valentin.schneider@arm.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Jason Cooper <jason@lakedaemon.net>,
linux-pci@vger.kernel.org,
Gregory Clement <gregory.clement@bootlin.com>,
linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Laurentiu Tudor <laurentiu.tudor@nxp.com>
Subject: Re: [PATCH 5/9] fsl-msi: Provide default retrigger callback
Date: Wed, 26 Aug 2020 12:16:47 +0100 [thread overview]
Message-ID: <jhj7dtlejxc.mognet@arm.com> (raw)
In-Reply-To: <20200824102317.1038259-6-maz@kernel.org>
Hi Marc,
Many thanks for picking this up!
Below's the only comment I have, the rest LGTM.
On 24/08/20 11:23, Marc Zyngier wrote:
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
> drivers/bus/fsl-mc/fsl-mc-msi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bus/fsl-mc/fsl-mc-msi.c b/drivers/bus/fsl-mc/fsl-mc-msi.c
> index 8edadf05cbb7..5306ba7dea3e 100644
> --- a/drivers/bus/fsl-mc/fsl-mc-msi.c
> +++ b/drivers/bus/fsl-mc/fsl-mc-msi.c
> @@ -144,6 +144,8 @@ static void fsl_mc_msi_update_chip_ops(struct msi_domain_info *info)
> */
> if (!chip->irq_write_msi_msg)
> chip->irq_write_msi_msg = fsl_mc_msi_write_msg;
> + if (!chip->irq_retrigger)
> + chip->irq_retrigger = irq_chip_retrigger_hierarchy;
AFAICT the closest generic hook we could use here is
msi_create_irq_domain() -> msi_domain_update_chip_ops()
which happens just below the fsl-specific ops update.
However, placing a default .irq_retrigger callback in there would affect any
and all MSI domain. IOW that would cover PCI and platform MSIs (covered by
separate patches in this series), but also some x86 ("dmar" & "hpet") and
TI thingies.
I can't tell right now how bad of an idea it is, but I figured I'd throw
this out there.
> }
>
> /**
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-26 11:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 10:23 [PATCH 0/9] irqchip/gic: generalize use of HW-based retriggering Marc Zyngier
2020-08-24 10:23 ` [PATCH 1/9] irqchip/gic-v2, v3: Implement irq_chip->irq_retrigger() Marc Zyngier
2020-08-24 10:23 ` [PATCH 2/9] irqchip/git-v3-its: Implement irq_retrigger callback for device-triggered LPIs Marc Zyngier
2020-08-24 10:23 ` [PATCH 3/9] PCI/MSI: Provide default retrigger callback Marc Zyngier
2020-08-25 19:44 ` Bjorn Helgaas
2020-08-24 10:23 ` [PATCH 4/9] platform-msi: " Marc Zyngier
2020-08-24 10:23 ` [PATCH 5/9] fsl-msi: " Marc Zyngier
2020-08-26 11:16 ` Valentin Schneider [this message]
2020-08-26 16:37 ` Marc Zyngier
2020-08-26 17:52 ` Marc Zyngier
2020-08-24 10:23 ` [PATCH 6/9] irqchip/mbigen: Use hierarchy retrigger helper Marc Zyngier
2020-08-24 10:23 ` [PATCH 7/9] irqchip/mvebu-icu: " Marc Zyngier
2020-08-24 10:23 ` [PATCH 8/9] irqchip/mvebu-sei: " Marc Zyngier
2020-08-24 10:23 ` [PATCH 9/9] irqchip/gic-v2, v3: Prevent SW resends entirely Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jhj7dtlejxc.mognet@arm.com \
--to=valentin.schneider@arm.com \
--cc=bhelgaas@google.com \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).