From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EA09C433DF for ; Wed, 26 Aug 2020 11:18:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D772F20786 for ; Wed, 26 Aug 2020 11:18:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="biuF7bNG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D772F20786 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-reply-to:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m2mW1jctKA8pc2qMbn/vvSptUIXGH5ibzWnC/zDdrrA=; b=biuF7bNGfsHvnDatgTRgB+Crt PReKYs1E0+aPTd7OBI1S6BiGaqZ6ErKW4TMqZmkSxNEn/YKAqt6siJiAW67Yi5B0+exZHhYA6Cd6w 2b0TRy+su0VAmwGFhS4VlYIif+2Bwgkg/8JaqzOWMQVJqEFSgj6d1IUs3ga7rMhPA0EDrtap53bWF JbzFRTuFJdy5bEv+x+e+uKx6nvooqT5KA/16NEyXQ3FXnwQwFIYpY+RzeLgAWLxxR0x3EvKka14Ei 2aCLVFLdyPXka3K6lbnW3qveo2Vg3CUA/fBcIoSwUgm3DpzxA4L/9trVnnQ7kAc9SengX4xZhICP1 RIhm5TrNQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAtQF-0004SD-4p; Wed, 26 Aug 2020 11:16:55 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAtQD-0004Rk-Aq for linux-arm-kernel@lists.infradead.org; Wed, 26 Aug 2020 11:16:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C2ADE1FB; Wed, 26 Aug 2020 04:16:50 -0700 (PDT) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8BE143F71F; Wed, 26 Aug 2020 04:16:49 -0700 (PDT) References: <20200824102317.1038259-1-maz@kernel.org> <20200824102317.1038259-6-maz@kernel.org> User-agent: mu4e 0.9.17; emacs 26.3 From: Valentin Schneider To: Marc Zyngier Subject: Re: [PATCH 5/9] fsl-msi: Provide default retrigger callback In-reply-to: <20200824102317.1038259-6-maz@kernel.org> Date: Wed, 26 Aug 2020 12:16:47 +0100 Message-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200826_071653_433457_38C46207 X-CRM114-Status: GOOD ( 15.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Cooper , linux-pci@vger.kernel.org, Gregory Clement , linux-kernel@vger.kernel.org, Bjorn Helgaas , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Laurentiu Tudor Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, Many thanks for picking this up! Below's the only comment I have, the rest LGTM. On 24/08/20 11:23, Marc Zyngier wrote: > Signed-off-by: Marc Zyngier > --- > drivers/bus/fsl-mc/fsl-mc-msi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/bus/fsl-mc/fsl-mc-msi.c b/drivers/bus/fsl-mc/fsl-mc-msi.c > index 8edadf05cbb7..5306ba7dea3e 100644 > --- a/drivers/bus/fsl-mc/fsl-mc-msi.c > +++ b/drivers/bus/fsl-mc/fsl-mc-msi.c > @@ -144,6 +144,8 @@ static void fsl_mc_msi_update_chip_ops(struct msi_domain_info *info) > */ > if (!chip->irq_write_msi_msg) > chip->irq_write_msi_msg = fsl_mc_msi_write_msg; > + if (!chip->irq_retrigger) > + chip->irq_retrigger = irq_chip_retrigger_hierarchy; AFAICT the closest generic hook we could use here is msi_create_irq_domain() -> msi_domain_update_chip_ops() which happens just below the fsl-specific ops update. However, placing a default .irq_retrigger callback in there would affect any and all MSI domain. IOW that would cover PCI and platform MSIs (covered by separate patches in this series), but also some x86 ("dmar" & "hpet") and TI thingies. I can't tell right now how bad of an idea it is, but I figured I'd throw this out there. > } > > /** _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel